[Pkg-electronics-devel] Bug#694015: Bug#694015: geda-gaf: diff for NMU version 1:1.6.2-4.3

[gregor herrmann]

On Sun, 20 Jan 2013 14:02:31 +0200, أحمد المحمودي wrote:

> On Sat, Jan 19, 2013 at 05:19:17PM +0100, gregor herrmann wrote:
> > +# Replace documentation directory with symlink
> > +docdir=/usr/share/doc/geda
> > +target=geda-doc
> > +
> > +if [ -d $docdir ] && [ ! -L $docdir ]; then
> > +	if rmdir $docdir 2>/dev/null; then
> > +		ln -sf $target $docdir
> > +	fi
> > +fi
> ---end quoted text---
> 
>   Are you sure about this fix ?
>   I think target should be /usr/share/doc/geda-doc rather than just 
>   'geda-doc'

I admit that it looks a bit surprising, but it's like in other
packages, and I've tested
(a) this ln syntax manually [0]
(b) and installing the new package in a chroot after making sure that
    /usr/share/doc/geda is a directory, and it was a symlink
    afterwards.

But if you like to write it differently I'm happy to cancel the NMU
or upload a version where $target is the full path.

Cheers,
gregor


[0]

% mkdir /tmp/geda
% mkdir /tmp/geda-doc
% ls -ld /tmp/geda*
drwxrwxr-x 2 gregoa gregoa 40 Jan 20 14:05 /tmp/geda
drwxrwxr-x 2 gregoa gregoa 40 Jan 20 14:05 /tmp/geda-doc

% rmdir /tmp/geda
% ln -sf geda-doc /tmp/geda
% ls -ld /tmp/geda*
lrwxrwxrwx 1 gregoa gregoa  8 Jan 20 14:06 /tmp/geda -> geda-doc
drwxrwxr-x 2 gregoa gregoa 40 Jan 20 14:05 /tmp/geda-doc
 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Beatles: Glass Onion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-electronics-devel/attachments/20130120/77d865d2/attachment.pgp>