[Pkg-electronics-devel] New version of gnusim8085 - 1.4.1

[Carsten Schoenert]

Hello Onkar,

no need to CC me, I'm subscribed to the list as well.

Am 01.08.18 um 00:04 schrieb Onkar Shinde:
...
> Please go ahead. I have never done this before so I don't want to mess
> things up. I would rather watch and learn.
>
>     You bumped Standards-Versions to 4.1.5, you are sure there are no
>     further changes needed? So please mention this then.
>
> I verified the differences between the 3.9.1 and 4.1.5 and found nothing
> that needs to be taken care for this package.

If there's no need for changes then it is helpful for other people if
you then communicate this. Please keep in mind that commit messages are
intended to explain why the change(s) was made. Try to think what would
another person will think once it's reading the commit messages and
later on the changelog file. That's what I mostly do while writing these
messages.

...
>     Why stick with debhelper 9? Current version is 11.
>
> It was more of what is the minimum version requested by policy. I did
> not find anything specific in version 11 which I wanted to use and hence
> kept at 9. Also looking at [1], it sounds like package build will break
> if we bump to 11.

Did you have tested this? :) And if why not?
The referenced bug isn't important for gnusim8085, it uses simply no
systemd things.

>     The cdbs package is for sure not needed anymore. If yes get rid of this
>     need.

The package builds just fine with debhelper 11, I added the needed
changes and these are quite a small bunch.

> First attempt at packaging after so many years so did not want to major
> changes. I will consider getting rid of cdbs with next upstream release.

I don't understand really why wait to for anything? If you intent or
doing the update of the package all the above and previous mentioned
suggestion can be done while the package preparation. And some of them
are also recent policy. There is no need to rush a new version to
people, it doesn't matter if they wait a few days longer.

>     debian/watch should be bumped to version 4.
> 
> Will you do this for me if you are looking into importing upstream source

The version bump is just increasing from 3 to 4 within the file, I've
done this together with my other changes. See below.

...
>     And I personally suggest to make the package ready for maintaining it by
>     git-buildpackage.
> 
> Will try to learn about this. :-)

It's really not difficult, you find a offline documentation once you
have installed the package. Or use the public websites.

--------

I reworked the whole git tree and after some unsuccessful trying I just
imported all the possible history by 'gbp import-dscs' with reapplying
your last commit on top of this. And then I've added some further
modifications like removing the CDBS stuff and migrating the package
over to debhelper 11. The resulting package builds fine and only a few
lines of Lintian output is left.

> W: gnusim8085 source: changelog-should-mention-nmu
> W: gnusim8085 source: source-nmu-has-incorrect-version-number 1.4.1-2
> I: gnusim8085 source: testsuite-autopkgtest-missing
> I: gnusim8085: spelling-error-in-binary usr/bin/gnusim8085 Convertion Conversion
> I: gnusim8085: spelling-error-in-binary usr/bin/gnusim8085 progam program
> I: gnusim8085: extended-description-is-probably-too-short
> I: gnusim8085: desktop-entry-lacks-keywords-entry usr/share/applications/GNUSim8085.desktop

As a unfortunate side effect I've deleted the old git tree on Salsa and
pushed the newly created try to the recreated project. But as the old
tree wasn't that useful that should be no big concern.

-- 
Regards
Carsten Schoenert