[Pkg-electronics-devel] gnucap package.

[Carsten Schoenert]

Hello Felix,

Am 04.03.2018 um 18:57 schrieb Felix Salfelder:
> Hi there.

You are welcome!

> On Sat, Aug 13, 2016 at 12:23:13PM +0200, Felix Salfelder wrote:
>> I have shaped up the gnucap package [1] quite a bit. There's a lot of
>> new stuff, such as a shared library package. The package is
>> lintian-clean except for the symbols file.
> 
> I have packaged the latest release (Oct 17). Same repository. Don't know
> how to proceed.
> 
> The package is also here [2]. Looking for a sponsor, just in case..

Thanks for taking care of this package, I had a quick view into the tree.
First of all, two important technical points I see with the tree you
have given.
It is missing a tag for the usptream version you are referencing in your
changelog, I assume you mean 519303bf that should be then signed tagged
as '0.36_20171003'.

> git tag -u 0x[your_key_id] upstream/0.36_20171003 -m "Upstream version 0.36~20171003" 519303bf34ef0b2d42b8d8299f6f3048400bafb5

Next the pristine-tar commit is also missing for this upstream version
in the git tree too. You just need to call

> $ pristine-tar commit ../gnucap_0.36~20171003.orig.tar.gz
Looking afterwards at the output of lintian I'd say the packaging could
be more improved. Most of the issues are easy to fix.

> I: gnucap source: vcs-field-uses-insecure-uri vcs-git git://anonscm.debian.org/pkg-electronics/gnucap.git

Means simple the git protocol isn't save here. Have a look at
https://lintian.debian.org/tags/vcs-field-uses-insecure-uri.html
This could be switched to the pkg-electronics place there the package
would be placed on Salsa. Take a look at existing packages on Salsa.

> I: gnucap source: debian-rules-parses-dpkg-parsechangelog (line 4)

Also please have a look at the explanation for this tag of Lintian. You
can also look at other packages how this can be fixed. For example

> https://salsa.debian.org/giraffe-team/kopano-webapp/commit/966ae5fc8abfa98b296f3d279f509abba3759ca4

Take a look into the mk files which is included to see how to use this
helper.

> I: gnucap source: out-of-date-standards-version 3.9.8 (released 2016-04-06) (current is 4.1.3)

Quite self explaining.
You need to look at the changes to the Debian policy since 3.9.8 and
decide if you need to modify the packaging to reflect the recent policy
version. In doubt just ask.

> https://www.debian.org/doc/debian-policy/#version-3-9-8

> I: gnucap source: testsuite-autopkgtest-missing

Can be ignored for now.

> I: gnucap source: debian-watch-uses-insecure-uri http://gnucap.org/archive/gnucap-(.*)\.tar\.gz

It's the same as the first tag from that list.

> I: libgnucap0: hardening-no-bindnow usr/lib/x86_64-linux-gnu/libgnucap.so.0
> I: gnucap-default-plugins0: hardening-no-bindnow usr/lib/x86_64-linux-gnu/gnucap0/gnucap-default-plugins.so
> I: gnucap: hardening-no-bindnow usr/bin/gnucap
> I: gnucap: hardening-no-bindnow usr/bin/gnucap-modelgen

Can also be ignored for now.

> I: libgnucap0: no-symbols-control-file usr/lib/x86_64-linux-gnu/libgnucap.so.0

Can be done but needs a bit of deeper knowledge.
The wiki gives a explanation how to fix this. Not necessary for now I'd say.

>> I: libgnucap0: no-symbols-control-file usr/lib/x86_64-linux-gnu/libgnucap.so.
> W: gnucap-default-plugins0: missing-depends-line

That's a serious problem which needs to be fixed, otherwise the plugins
may be not usable because of not added needed depended libraries for
using them.
You will need to add a override for dh_shlibdeps in debian/rules and add
the needed call so dh_shlibdeps can find the needed dependencies. Have a
look at the man page and existing packages on Salsa e.g. kopanocore

> https://salsa.debian.org/giraffe-team/kopanocore/blob/debian/sid/debian/rules#L119
Note also you can use DH_VERBOSE in debian/rules to see more verbosely
what the debhelper sequencers are doing, it's mostly more helpful in
case you see not directly why something is happen (or not happen).

If you have further question please tell us, if the package is more
clean we can talk about sponsoring.

-- 
Regards
Carsten Schoenert