[Pkg-electronics-devel] gnucap package.

[Carsten Schoenert]

Hi Felix,

Am 08.03.2018 um 20:48 schrieb Felix Salfelder:
>> Great. The packaging looks good so far, I can't say much about the -dev
>> packages you have created and how useful they are. I have no deeper
>> knowledge about gnucap, maybe some other member here on the list could
>> say something helpful criticism on that.
> 
> i'm not entirely happy about the -dev package. but it's the closest i
> could get so far. might require fine tuning, but depends.

I'm a bit concerned about the current structure of the -dev packages, so
far I see it's not worth to split out all theses development packages.
gnucap is small and not widely used, I think it's nit really worth to
have two dev packages.
libgnucap-dev has no header files for example. How could I include
prototype definitions if I want to build a binary which will be linked
against libgnucap0?

Maybe you can drop libgnucap-dev and keep only gnucap-dev? But I really
don't understand the gnucap package that much to give right now a good
advice here. Unfortunately I haven't enough time to dig into this for now.

>> But could you please have a look at the existing bug reports for gnucap
>> and add valid Closes tags to the changelog so the report are closed with
>> the version number of the upload once the package will hit the archive?
>> I guess quite all or most of the reports can be closed by a next upload.
> 
> there are 4. 3 are closed. in the other, #802307, somebody misread the
> manual. (how) can I close it?

#802307 can be closed directly in my eyes, no feedback from the reporter
within 2 years ...

> There's also
>   * Fix FTCBFS: Add gnucap:native to Build-Depends. (Closes: #-1)
> 
> is that correct for "nobody cared about writing a bug report"?

You need to fix the bugnumber in debian/changelog here.
s/-1/878364

In the changelog file you have also some typos for the closing of bug
reports, the trigger is 'Closes:' not 'Close'.

> $ git diff
> diff --git a/debian/changelog b/debian/changelog
> index bd283d4..375e088 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,10 +1,10 @@
>  gnucap (1:0.36~20171003-1) unstable; urgency=medium
>  
> -  * libgnucap0 + libgnucap-dev (Close #224467)
> +  * libgnucap0 + libgnucap-dev (Closes: #224467)
>    * gnucap-default-plugins0 package
>      + binary plugins
>      + soname dependent pkglibdir
> -  * gnucap-dev package (Close #693267)
> +  * gnucap-dev package (Closes: #693267)
>    * d/*.1 for all three executables
>    * get-orig-source, snapshotting upstream git
>    * set sysconfdir to /etc
> @@ -12,7 +12,7 @@ gnucap (1:0.36~20171003-1) unstable; urgency=medium
>    * move package to salsa (from alioth/pkg-electronics)
>    * debian/control: Bump Standards-Version to 4.1.3
>    * bump compat to 11
> -  * remove Wesley from Uploaders (Close #759987)
> +  * remove Wesley from Uploaders (Closes: #759987)
>    * lintian override http in watch file

And it's always a good tone to thank the people for their work on the
package if they gonna removed from the uploaders list. :)

What about #831480? Could be added to the changelog as well if Hamish
Moffatt is removed from the uploaders.
So you would have covered all existing reports finally.


-- 
Regards
Carsten Schoenert