[Pkg-electronics-devel] RFS: systemc/2.3.2-2 [UPDATE]

[Carsten Schoenert]

Hello Ahmed,

Am 11.11.18 um 05:18 schrieb أحمد المحمودي:
> Please note that the debian/2.3.2-2 tag is invalid, as I was not able to 
> remove it.

of, course you are not able to do this. ;)
Once a commit or tag is on Salsa it's there for all the life time (and
that for a good reason) and shouldn't be modified afterwards.
So you should be really sure that you have finished your work on a
Debian release if you push your changes to Salsa.
I typically wait for the acknowledge of DAK until I push the tagging if
a upload was happen.

So now the package needs a Debian version -3 as the -2 is already used.

> On Sun, Nov 11, 2018 at 04:53:53AM +0100, أحمد المحمودي wrote:
>> Please sponsor the upload of the updated package systemc
>>
>> Last changelog entry is:
>> systemc (2.3.2-2) unstable; urgency=medium
>>
>>   * Updated standards version to 4.2.0

The current version is 4.2.1, you should always update to the most
recent version and say something about the changes or the need to not
change anything in your packaging.
If the usage of the most recent Standard-Versions isn't possible you
should explain this and/or discuss this with other maintainers as this
means your package might not fit the DFSG or the Debain packaging QS
standards.

>>   * Remove symbols file, as it is a real pain to maintain (Closes: #913270)

I'm not sure why you wont add the rather smallish changes to the symbol
file? It's one of the downsides of C++ that mostly every new g++ binary
version is also introducing symbol changes to the compiled source files.
So far I remember the systemc upload to NEW was created with g++-7 and
now we have g++-8 which will also be the default GCC C++ compiler for
Buster. And once buster is released no binary changes to the GCC will be
allowed. So it make sense to have a symbol file if it was already
existing, at least to me.

The nice thing on dh_shlibdeps is a diff output with the changes you
need to apply. Looking at the bug report the changes are really small.
If you are unsure I suggest you post your concerns and intended changes
to the package(s) here on the list.

>>   * Limit build archs as per supported by upstream (Closes: #913269)
>>
>> The package is lintian clean.
>>
>> The package is on: git at salsa.debian.org/electronics-team/systemc.git

nitpick: The URL is wrong :-)
It's git at salsa.debian.org:electronics-team/systemc.git

>> Please consider granting me DM upload access for systemc

Let's wait a bit with this, get more familiar with the packaging
workflow and also the knowledge related to the Debian things I suggest.

Until then I'm happy to upload new package versions to the archive for you.

-- 
Regards
Carsten Schoenert

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-electronics-devel/attachments/20181111/23aa087b/attachment.sig>