[Pkg-electronics-devel] Update to package gerbv

[Carsten Schoenert]

Hello Gudjon,

Am 09.01.19 um 23:18 schrieb Gudjon I. Gudjonsson:
> Hi Carsten
> 
> Sorry, a bit silly but I didn't find your changes until I had redone most of them
> myself :(

huh? The URL to the cloned and modified repo from my first email is
still valid. You would just have to do a fetch and if needed a cherry
picking if not just simple pushing my changes to Salsa. Or just ask back
if you unsure.

So I got a feeling that about 3h on my side which I've spend were a bit
useless time invest for this package for me. :(

> Anyway, the package is updated and most of the lintian warnings are fixed.

Your modification to 0003-No-translation-available.patch is useless and
not really needed.

The maintainer contact still points to a non existing address.

The package is now also still at debhelper 10, there is no need to stay
on this old debhelper version.

The uploaders field is also still holding Ramakrishnan Muthukrishnan and
is not fixing #859286 by removing the Uploader in question.

The current last commit is including a lot of various changes that do
not directly depend. This makes it really hard to see what was changed
and why.
It also has removed files that are present in the orig tarball. Was this
intended?

> I did use your hardening code.

Hmm, I can't see it and Lintian is also mentioning the not used hardening.

> Don't know if it is polite to add thanks in the changelog.
For sure it is, that's on of the less files the typical Debian user will
ever see and I my eyes the only place to spreed kudos and thanks
messages prominently.

(And now again I've spend about .5h to do a review on your changes ...
wouldn't it have been better to do some more exchange of communications
if things are unclear?)

-- 
Regards
Carsten Schoenert