[Pkg-electronics-devel] Bug#980589: libsigrok: FTBFS: tests/strutil.c:157:2: error: too few arguments to function ‘_ck_assert_failed’

[Lucas Nussbaum]

Source: libsigrok
Version: 0.5.2-2
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20210120 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H   -Iinclude -I./include -I./src -I. -Ibindings/cxx/include -I./bindings/cxx/include -Ibindings/cxx -DFIRMWARE_DIR='"/usr/share/sigrok-firmware"' -Wdate-time -D_FORTIFY_SOURCE=2 -std=c99 -fvisibility=hidden -Wall -Wextra -Wmissing-prototypes -pthread -I/usr/include/libftdi1 -I/usr/include/hidapi -I/usr/include/libusb-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o tests/driver_all.o tests/driver_all.c
> In file included from tests/strutil.c:21:
> tests/strutil.c: In function ‘test_sr_vsnprintf_ascii’:
> tests/strutil.c:63:4: warning: too many arguments for format [-Wformat-extra-args]
>    63 |    "Invalid result for '%s': len = %i.", expected, len);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c:65:4: warning: too many arguments for format [-Wformat-extra-args]
>    65 |    "Invalid result for '%s': %s.", expected, s);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c: In function ‘test_sr_vsprintf_ascii’:
> tests/strutil.c:87:4: warning: too many arguments for format [-Wformat-extra-args]
>    87 |    "Invalid result for '%s': len = %i.", expected, len);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c:89:4: warning: too many arguments for format [-Wformat-extra-args]
>    89 |    "Invalid result for '%s': %s.", expected, s);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c: In function ‘test_samplerate’:
> tests/strutil.c:100:7: warning: too many arguments for format [-Wformat-extra-args]
>   100 |       "Invalid result for '%s': %s.", expected, s);
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c: In function ‘test_period’:
> tests/strutil.c:111:7: warning: too many arguments for format [-Wformat-extra-args]
>   111 |       "Invalid result for '%s': %s.", expected, s);
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c: In function ‘test_rational’:
> tests/strutil.c:121:28: warning: too many arguments for format [-Wformat-extra-args]
>   121 |  fail_unless(ret == SR_OK, "Unexpected rc for '%s': %d, errno %d.",
>       |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c:124:7: warning: too many arguments for format [-Wformat-extra-args]
>   124 |       "Invalid result for '%s': %ld/%ld'.",
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c: In function ‘test_rational_fail’:
> tests/strutil.c:134:28: warning: too many arguments for format [-Wformat-extra-args]
>   134 |  fail_unless(ret != SR_OK, "Unexpected success for '%s'.", input);
>       |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c: In function ‘test_voltage’:
> tests/strutil.c:144:7: warning: too many arguments for format [-Wformat-extra-args]
>   144 |       "Invalid result for '%s': %s.", expected, s);
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tests/strutil.c: In function ‘test_locale_fn’:
> tests/strutil.c:157:2: error: too few arguments to function ‘_ck_assert_failed’
>   157 |  ck_assert_msg(saved_locale != NULL);
>       |  ^~~~~~~~~~~~~
> /usr/include/check.h:505:27: note: declared here
>   505 | CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
>       |                           ^~~~~~~~~~~~~~~~~
> gcc -DHAVE_CONFIG_H   -Iinclude -I./include -I./src -I. -Ibindings/cxx/include -I./bindings/cxx/include -Ibindings/cxx -DFIRMWARE_DIR='"/usr/share/sigrok-firmware"' -Wdate-time -D_FORTIFY_SOURCE=2 -std=c99 -fvisibility=hidden -Wall -Wextra -Wmissing-prototypes -pthread -I/usr/include/libftdi1 -I/usr/include/hidapi -I/usr/include/libusb-1.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o tests/device.o tests/device.c
> make[2]: *** [Makefile:3653: tests/strutil.o] Error 1

The full build log is available from:
   http://qa-logs.debian.net/2021/01/20/libsigrok_0.5.2-2_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with me
so that we can identify if something relevant changed in the meantime.

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.