[Pkg-electronics-devel] Bug#1030913: verilator: FTBFS on hppa - #error "Missing VL_CPU_RELAX() definition."

[John David Anglin]

Source: verilator
Version: 5.006-2
Severity: normal
Tags: ftbfs patch

Dear Maintainer,

Build fails with following error:

g++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -Wformat -Werror=format-security -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -Wformat -Werror=format-security  -Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2  -Og -ggdb -gz -DVL_DEBUG -D_GLIBCXX_DEBUG -MMD -I. -I.. -I.. -I../../include -I../../include -MP  -faligned-new -Wno-unused-parameter -Wno-shadow -DDEFENV_SYSTEMC=\"\" -DDEFENV_SYSTEMC_ARCH=\"\" -DDEFENV_SYSTEMC_INCLUDE=\"\" -DDEFENV_SYSTEMC_LIBDIR=\"\" -DDEFENV_VERILATOR_ROOT=\"/usr/share/verilator\" -c ../VlcMain.cpp -o VlcMain.o
In file included from ../config_build.h:91,
                 from ../VlcMain.cpp:18:
../../include/verilatedos.h:537:3: error: #error "Missing VL_CPU_RELAX() definition."
  537 | # error "Missing VL_CPU_RELAX() definition."
      |   ^~~~~

Full log is here:
https://buildd.debian.org/status/fetch.php?pkg=verilator&arch=hppa&ver=5.006-2&stamp=1675879005&raw=0

Attached patch fixes build on hppa:
https://buildd.debian.org/status/fetch.php?pkg=verilator&arch=hppa&ver=5.006-2&stamp=1675904676&raw=0

Regards,
Dave Anglin

-- System Information:
Debian Release: bookworm/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable')
Architecture: hppa (parisc64)

Kernel: Linux 6.1.10+ (SMP w/4 CPU threads)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
Index: verilator-5.006/include/verilatedos.h
===================================================================
--- verilator-5.006.orig/include/verilatedos.h
+++ verilator-5.006/include/verilatedos.h
@@ -519,6 +519,8 @@ using ssize_t = uint32_t;  ///< signed s
 # define VL_CPU_RELAX() asm volatile("nop" ::: "memory");
 #elif defined(__aarch64__) || defined(__arm__)
 # define VL_CPU_RELAX() asm volatile("yield" ::: "memory")
+#elif defined(__hppa__)  // HPPA does not currently have yield/pause
+# define VL_CPU_RELAX() asm volatile("nop" ::: "memory")
 #elif defined(__loongarch__)  // LoongArch does not currently have yield/pause
 # define VL_CPU_RELAX() asm volatile("nop" ::: "memory")
 #elif defined(__mips64el__) || defined(__mips__) || defined(__mips64__) || defined(__mips64)