[Pkg-electronics-devel] savvycan_220-1_amd64.changes REJECTED

[Christopher Obbard]

Hi Mechtilde,

On Sun, 22 Mar 2026 at 08:08, Mechtilde Stehmann <mechtilde at debian.org> wrote:
>
> Hello Christopher,
>
> Am 22.03.26 um 06:57 schrieb Christopher Obbard:
> > Hi Mechtilde,
> >
> > Thanks for the review!
> > I've uploaded a new version which should address the concerns raised.
>
> Now all licenses are listed. Thanks.

Thanks for the fast review. I see you accepted the package, just
wondering what the remaining parts are from my side?


> > Let me know if I messed anything up.
>
> Now you have
>
> Files: qcustomplot.cpp qcustomplot.h
> Copyright:
>   2011-2022 Emanuel Eichhammer
> License: GPL-3+
>
> in d/copyright.
>
> As described in 5.c of the GPL v3
> https://www.gnu.org/licenses/gpl-3.0.html.en
> it isn't allowed to license under a different license.

Hmm, qcustomplot.cpp states this, which made me think it was under GPL-3+:
    **  This program is free software: you can redistribute it and/or modify  **
    **  it under the terms of the GNU General Public License as published by  **
    **  the Free Software Foundation, either version 3 of the License, or     **
    **  (at your option) any later version.                                   **


That also matches my comment in d/copyright:

    This package includes GPL-3+ licensed components (qcustomplot),
    therefore the resulting binary is distributed under GPL-3+.

Please let me know if I need to change this in a future upload.


> I found in the READMe.md:
> ***
> Now this code does not depend on anything other than what is in the
> source tree or available from the Qt installer.
> Uses QCustomPlot available at:
> http://www.qcustomplot.com/
> However, this source code is integrated into the source for SavvyCAN and
> one isn't required to download it separately.
> ***
>
> So it seems to be possible to exclude these files from the package and
> package it separately as a dependency.

I could remove these files from the upstream tarball (creating a -dfsg
tarball), package qcustomplot separately and build against that.
I didn't check if savvycan made any changes to qcustomplot or if it is
compatible with upstream qcustomplot yet.
It doesn't change the final licence of this package though.


Thanks!

Chris