<br>On Sat, Jun 12, 2010 at 11:13 PM, أحمد المحمودي <span dir="ltr"><<a href="mailto:aelmahmoudy@sabily.org">aelmahmoudy@sabily.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hello,<br>
<div class="im"><br>
On Sat, Jun 12, 2010 at 10:03:29PM +0530, Bhavani Shankar R wrote:<br>
> I am Bhavani Shankar a 23 year old electrical engineer by profession born<br>
> brought up and settled in Bangalore India and since my area of interest is<br>
> electrical and electronics I would like to join the team to work on<br>
> electronics packages and in this regard I am trying to port emu8051 which is<br>
> a simple 8051 microcontroller emulator from ubuntu and I ve posted a RFS on<br>
> <a href="http://mentors.debian.net" target="_blank">mentors.debian.net</a> which is quoted for your kind perusal here:<br>
</div>---end quoted text---<br>
<br>
Nice having you here ! I am not a DD, but here are my comments:<br>
<br>
* debian/docs: There's no need to install the 'INSTALL' nor README files<br>
Note that lintian gives this warning:<br>
W: emu8051: package-contains-upstream-install-documentation usr/share/doc/emu8051/INSTALL.gz<br>
<br></blockquote><div> I ll correct it and upload thanks<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
* debian/copyright: Why are you licensing the packaging work under<br>
public domain ? It is better to have the packaging work under the<br>
same license of the upstream project, in order to avoid legal issues<br>
when you decide to introduce a patch for example to upstream code.<br>
<br></blockquote><div> I ll put it under GPL-2 thanks again!<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
* debian/control: I'm not sure about your use of<br>
XSBC-Original-Maintainer, I've seen your reason in the changelog, I<br>
hope someone on the list would comment. Note, that it causes this<br>
lintian warning:<br>
W: emu8051 source: unknown-field-in-dsc original-maintainer<br>
<br></blockquote><div><br> I ve put a user defined field to reflect the ubuntu packager <br> Refer:<br> <a href="http://www.debian.org/doc/debian-policy/ch-controlfields.html#s5.7">http://www.debian.org/doc/debian-policy/ch-controlfields.html#s5.7</a><br>
<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
* I would recommend adding a .desktop file for the emulator, and send<br>
it to upstream.<br>
* I'd recommend using 3.0 (quilt) source format, you won't need to do<br>
any change in your package except to modify source/format file<br>
<font color="#888888"><br></font></blockquote><div> Thanks for your review ll add a desktop file and send it upstream <br><font color="#888888"><br><br></font></div></div>Regards<br><br clear="all"><br>-- <br>Bhavani Shankar.R<br>
<a href="https://launchpad.net/~bhavi">https://launchpad.net/~bhavi</a>, a proud ubuntu community member.<br>What matters in life is application of mind!,<br>It makes great sense to have some common sense..!<br><br>