[Pkg-emacsen-addons] Bug#829200: Bug#829200: dh-elpa: Could dh-elpa be told to use debian version as elpa version

Rémi Vanicat vanicat at debian.org
Mon Jul 18 08:19:52 UTC 2016


Sean Whitton <spwhitton at spwhitton.name> writes:

> Hello,

Hello,

>
> On Sun, Jul 17, 2016 at 11:21:51PM +0200, Rémi Vanicat wrote:
>> There is no good reason, I used DEB_VERSION_UPSTREAM because it was what
>> someone told me on irc.
>
> Okay.  I think this should be DEB_UPSTREAM_VERSION -- please consider
> updating your branch.
>
> Otherwise, I think the approach you've taken in this patch is fine (I
> assume you've tested it).  I'll wait for my co-maintainer David to take
> a look before merging to master.

after checking, there is in fact a bug in my code: the
DEB_VERSION_UPSTREAM is define in /usr/share/dpkg/pkg-info.mk that was
included from the debian/rules I used as test, but is not in a common
build system. likewise if DEB_UPSTREAM_VERSION is define in cdbs, it
won't be define in a standard build environment. I won't have the time
to do fix this soon, do not hesitate to correct my patch.

Thanks.
-- 
Rémi Vanicat



More information about the Pkg-emacsen-addons mailing list