[Pkg-emacsen-addons] Bug#850036: elpa-sml-mode: Removal script fail if XEmacs or Emacs 21/22/24 is installed.

[Oleksandr Gavenko]

Package: elpa-sml-mode
Version: 6.7-1
Severity: normal

  $ cat /usr/lib/emacsen-common/packages/remove/elpa-sml-mode
  ...
FLAVOR=$1
case $FLAVOR in
...
    emacs23)
        echo remove/${ELPA_DIR}: Skipping obsolete emacs ${FLAVOUR}
        exit 0
        ;;
    xemacs*)
        echo remove/${ELPA_DIR}: Skipping unsupported emacs ${FLAVOUR}
        ;;
...


There is no

        exit 0

command in "case" for xemacs, there are no emacs21|emacs22 in "case" condition
and script fail on line:

  find ${elc_dir} -type l -delete

because of previous::

  set -e

I suggest such modifications:

    emacs21|emacs22|emacs23)
        echo remove/${ELPA_DIR}: Skipping obsolete emacs ${FLAVOUR}
        exit 0
        ;;
    xemacs*)
      echo 
        echo remove/${ELPA_DIR}: Skipping unsupported emacs ${FLAVOUR}
        exit 0
        ;;

and:

if ! test -d ${elc_dir}; then
  echo dh-elpa: skipping pruning flavor specific files for ${FLAVOR}
  exit 0
fi
echo dh-elpa: purging flavor specific files for ${FLAVOR}


-- System Information:
Debian Release: stretch/sid
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.5.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages elpa-sml-mode depends on:
ii  emacsen-common  2.0.8

elpa-sml-mode recommends no packages.

elpa-sml-mode suggests no packages.

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/lib/emacsen-common/packages/install/elpa-sml-mode (from elpa-sml-mode package)
debsums: changed file /usr/lib/emacsen-common/packages/remove/elpa-sml-mode (from elpa-sml-mode package)

-- 
http://defun.work/