[Pkg-emacsen-addons] Bug#861868: installation script /usr/lib/emacsen-common/packages/install/ilisp not idempotent

[Adam Di Carlo]

Package: ilisp
Version: 5.12.0+cvs.2004.12.26-23
Severity: normal
Tags: patch

The installation script at
/usr/lib/emacsen-common/packages/install/ilisp contains 'ln -s'
(lacking the -f option) which means it fails to be idempotent.

To demonstrate, suppose the package failed to install (see #850072 for
instance).  In this case, successively running 'dpkg --configure
ilisp' to try to get things to work will start failing on the 'ln -s'.

Here is a patch, very simple stuff:

--- /usr/lib/emacsen-common/packages/install/ilisp.orig	2017-05-04 22:26:39.707085697 -0400
+++ /usr/lib/emacsen-common/packages/install/ilisp	2017-05-04 22:26:29.851048093 -0400
@@ -39,9 +39,9 @@
 cd ${ELDIR}
 ELFILES=*.el
 cd ${ELCDIR}
-ln -s ${ELRELDIR}/*.el ./
+ln -sf ${ELRELDIR}/*.el ./
 cd extra
-ln -s ../${ELRELDIR}/extra/*.el ./
+ln -sf ../${ELRELDIR}/extra/*.el ./
 cd ..
 
 LOG=$(tempfile);


-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (1001, 'testing'), (300, 'unstable-debug'), (300, 'unstable')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages ilisp depends on:
ii  common-lisp-controller  7.10
ii  debconf [debconf-2.0]   1.5.60
ii  emacsen-common          2.0.8

Versions of packages ilisp recommends:
ii  ilisp-doc  5.12.0+cvs.2004.12.26-23

Versions of packages ilisp suggests:
ii  cltl       1.0.26
ii  emacs25    25.1+1-4
ii  hyperspec  1.30+nmu2

-- debconf information excluded

-- debsums errors found:
debsums: changed file /usr/lib/emacsen-common/packages/install/ilisp (from ilisp package)
debsums: changed file /usr/share/emacs/site-lisp/ilisp/ilisp-mak.el (from ilisp package)