[Pkg-emacsen-addons] Bug#886253: Comments on patches committed for this bug
Sean Whitton
spwhitton at spwhitton.name
Tue Jan 16 10:05:18 UTC 2018
Hello,
A few comments. Thanks for working on this.
- I find your NEWS.Debian entry imperspicuous. In particular, "This
means that the previous automatic handling of non-elpa-*
byte-compilation (package install time) dependencies is removed." --
to what automatic handling do you refer? I know, but a reader might
not, since it's not exactly a headline dh_elpa feature..
I suggest rewriting to say something like "the load path for
bytecompilation now excludes all lisp outside of that bundled with
Emacs itself and any installed dh_elpa packages."
- Similarly, in the changelog, I would describe the change in terms of
the more limited load path, which is /implemented/ by means of
--quick (and change to EMACSLOADPATH? See below).
- You seem to have removed /usr/share/emacs/site-lisp from the load path
in addition to passing --quick; is this an additional removal or part
of fixing this bug (which I thought was more about excluding the local
admin's lisp)? Commit message doesn't say, so should probably be in
changelog.
- Manpage entry duplicates 'compilation'.
--
Sean Whitton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-emacsen-addons/attachments/20180116/6b9a7cd2/attachment.sig>
More information about the Pkg-emacsen-addons
mailing list