[Pkg-emacsen-addons] Bug#944249: gnuplot-mode does not work with emacs26

[Agustin Martin]

On Sun, Nov 17, 2019 at 10:52:47PM -0800, Dima Kogan wrote:
> Thanks for the patches, Agustin. I just tried it out. Works for the most
> part. One thing that doesn't work for me is (gnuplot-mode) being
> executed when opening a .gp file. You added this to the package, and the
> dh-elpa machinery is creating the appropriate file:
> 
>   /etc/emacs/site-start.d/50elpa-gnuplot-mode.el
> 
> I don't think this is being evaluated, however. Is it working for you?

Hello, thanks for looking at this.

It is working for me. I reviewed again my ~/.emacs file and did not see
anything active that may mess up with this.

> Do you know at which point in the emacs startup sequence this is
> sourced? 

In my box, Emacs messages buffer shows

...
Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)...done
Loading /etc/emacs/site-start.d/50elpa-gnuplot-mode.el (source)...done
Loading /etc/emacs/site-start.d/50flim.el (source)...done
...

> Is it always supposed to be sourced? What about 'emacs -q'? Or
> 'emacs -Q'?

That snippet will not always be sourced,

It will not be sourced with "emacs -Q" or "emacs --no-site-file"

It will be sourced with "emacs --q", but I get an error here

...
Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)...done
Loading /etc/emacs/site-start.d/50elpa-gnuplot-mode.el (source)...done
Loading /etc/emacs/site-start.d/50flim.el (source)...done
...
File mode specification error: (void-function gnuplot-mode)
...

Another thing. It is probably too late for this, but I tried gnuplot-mode
for XEmacs (unsupported by elpa). Just needed to add a couple of lines with
a compatibility function

  (eval-and-compile ;; Protect against declare-function undefined in XEmacs
    (unless (fboundp 'declare-function) (defmacro declare-function (&rest r))))

and load .el files manually to have it working. No apparent problems in my
quick test (plotting sin(x)). I wonder if gnuplot-mode should have
preserved XEmacs compatibility and thus not migrate to elpa. Anyhow, seems
that nobody complained and even I had to install XEmacs just for this check,
so this seems no longer an issue.

Regards,

-- 
Agustin