[Pkg-erlang-devel] Bug#636510: erlang: FTBFS on hurd-i386

[Pino Toscano]

Alle mercoledì 3 agosto 2011, Sergei Golovan ha scritto:
> > - some PATH_MAX usages, replaced with MAXPATHLEN (which is defined
> > in erlang itself, and already used almost everywhere)
> 
> And this part would require special reviewing after every new
> upstream release (who knows where PATH_MAX will be used in new
> places). So, I think that it'd be better to define PATH_MAX for Hurd
> instead of replacing its instances by MAXPATHLEN.

Actually, it seems that MAXPATHLEN is what you describe; see in 
erts/emulator/sys/unix/erl_unix_sys.h:

/*
 * Make sure that MAXPATHLEN is defined.
 */
[...]
#ifndef MAXPATHLEN
#   ifdef PATH_MAX
#       define MAXPATHLEN PATH_MAX
#   else
#       define MAXPATHLEN 2048
#   endif
#endif

There's also a bit of duplication of this code defining MAXPATHLEN (and 
all of them in different ways, even), see:
- lib/runtime_tools/c_src/trace_file_drv.c
- lib/erl_interface/src/prog/erl_start.c
- lib/erl_interface/src/misc/ei_internal.h

I guess there's the need for some uniformity...

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-erlang-devel/attachments/20110803/1c1b3109/attachment.pgp>