[Pkg-erlang-devel] Bug#840431: Bug#840431: Bug#840431: rebar: Regression - causes FTBFS in erlang-p1-sqlite3 when built non-interactively

[Nobuhiro Iwamatsu]

Hi, Sergei, Philipp.

Thanks for your patch!

2016-10-12 3:06 GMT+09:00 Sergei Golovan <sgolovan at nes.ru>:
> tags 840431 + patch
> thanks
>
> Hi, Philipp,
>
> On Tue, Oct 11, 2016 at 5:45 PM, Philipp Huebner <debalance at debian.org> wrote:
>> Package: rebar
>> Version: 2.6.4-1
>> Severity: important
>>
>> rebar 2.6.4-1 causes erlang-p1-sqlite3 to FTBFS during a non-interactive
>> build (e.g. with git-buildpackage + pbuilder), see #839351.
>
> Looks like rebar fails to build erlang-p1-sqlite3 because of the tilde
> ~ in its version (or more specifically, in the build directory path).
> I've tried in pbuilder and get the directory name
> /build/erlang-p1-sqlite3-1.1.5~dfsg0. Note the ~d. The issue is that
> rebar takes some string with incorporated dirname as a format
> specifier, so ~d means "decimal number", but there's no any number.
>

I see.

> I'm attaching a small patch (untested) which makes the potentially
> dangerous string an argument of io:format, and not a format string.
>
> The bug is indeed introduced in rebar 2.6.4.
>

Thanks!, I will upload package with your patch.

> Cheers!
> --
> Sergei Golovan

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6