Bug#297670: marked as done (dpatch: doesn't abort package building when patch fails)
Debian Bug Tracking System
owner@bugs.debian.org
Wed, 25 May 2005 16:33:05 -0700
Your message dated Thu, 26 May 2005 01:27:32 +0200
with message-id <20050525232732.GA26471@lefler.int.l21.ma.zugschlus.de>
and subject line Closing bugs aftger 4.50-6 has been approved for sarge
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 2 Mar 2005 07:23:51 +0000
>From mh+debian-bugs@zugschlus.de Tue Mar 01 23:23:51 2005
Return-path: <mh+debian-bugs@zugschlus.de>
Received: from 5301d.unt0.torres.l21.ma.zugschlus.de (torres.int.l21.ma.zugschlus.de) [217.151.83.1] (Debian-exim)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1D6OD1-0000PY-00; Tue, 01 Mar 2005 23:23:51 -0800
Received: from scyw00225.int.l21.ma.zugschlus.de ([192.168.130.43]:35074 helo=scyw00225)
by torres.int.l21.ma.zugschlus.de with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32)
(Exim 4.50)
id 1D6OCy-0003qm-Gl
for submit@bugs.debian.org; Wed, 02 Mar 2005 08:23:48 +0100
Received: from mh by scyw00225 with local (Exim 4.50)
id 1D6OEY-0001zW-Nj
for submit@bugs.debian.org; Wed, 02 Mar 2005 08:25:26 +0100
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Marc Haber <mh+debian-bugs@zugschlus.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: dpatch: doesn't abort package building when patch fails
X-Mailer: reportbug 3.8
Date: Wed, 02 Mar 2005 08:25:26 +0100
Message-Id: <E1D6OEY-0001zW-Nj@scyw00225>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: dpatch
Version: 2.0.11
Severity: normal
Hi,
dpatch doesn't seem to abort the package build proces when one of the
patches fail. It silently continues, leading to grave bugs in packages
like 297607.
I would expect dpatch to abort my package build process in this case.
At the least, I would expect dpatch to issue a prominent warning about
the failed patch. Instead, it drops it into debian/patched:
patching file src/daemon.c
Hunk #1 succeeded at 45 with fuzz 1 (offset 3 lines).
Hunk #2 FAILED at 672.
1 out of 2 hunks FAILED -- saving rejects to file src/daemon.c.rej
Please consider changing dpatch's behavior here.
Greetings
Marc
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.10-scyw00225
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
-- no debconf information
---------------------------------------
Received: (at 297670-done) by bugs.debian.org; 25 May 2005 23:27:36 +0000
>From mh+debian-packages@zugschlus.de Wed May 25 16:27:35 2005
Return-path: <mh+debian-packages@zugschlus.de>
Received: from 5301d.unt0.torres.l21.ma.zugschlus.de (torres.int.l21.ma.zugschlus.de) [217.151.83.1] (Debian-exim)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Db5Hj-00074Q-00; Wed, 25 May 2005 16:27:35 -0700
Received: from lefler.int.l21.ma.zugschlus.de ([192.168.130.38])
by torres.int.l21.ma.zugschlus.de with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32)
(Exim 4.50)
id 1Db5Hh-0005T0-R4; Thu, 26 May 2005 01:27:33 +0200
Received: from mh by lefler.int.l21.ma.zugschlus.de with local (Exim 4.50)
id 1Db5Hg-0006xJ-TP; Thu, 26 May 2005 01:27:32 +0200
Date: Thu, 26 May 2005 01:27:32 +0200
From: Marc Haber <mh+debian-packages@zugschlus.de>
To: 307961-done@bugs.debian.org, 297670-done@bugs.debian.org,
299051-done@bugs.debian.org, 302060-done@bugs.debian.org,
303351-done@bugs.debian.org, 304033-done@bugs.debian.org,
299732-done@bugs.debian.org, 296492-done@bugs.debian.org,
299733-done@bugs.debian.org, 300967-done@bugs.debian.org
Cc: Marc Haber <mh+debian-packages@zugschlus.de>
Subject: Closing bugs aftger 4.50-6 has been approved for sarge
Message-ID: <20050525232732.GA26471@lefler.int.l21.ma.zugschlus.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
Delivered-To: 297670-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 2
These bugs are now fixed in sarge as well.
Greetings
Marc
--
-----------------------------------------------------------------------------
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature | How to make an American Quilt | Fax: *49 621 72739835