Bug#378581: bad parsing of CHECK_RCPT_DOMAIN_DNSBLS

[Robert Millan]

Package: exim4-config
Version: 4.62-2
Severity: normal
Tags: patch

Parsing of CHECK_RCPT_DOMAIN_DNSBLS in acl/30_exim4-config_check_rcpt assumes
this macro contains only one host:

  dnslists = CHECK_RCPT_DOMAIN_DNSBLS/$sender_address_domain

which would expand to:

  dnslists = rhsbl.foo.org/$sender_address_domain

But if you define CHECK_RCPT_DOMAIN_DNSBLS to contain multiple black lists, this
fails:

  dnslists = rhsbl.foo.org : rhsbl.bar.org/$sender_address_domain

My proposed solution is to remove the suffix and add an explanatory comment:

diff -ur exim4-4.62.old/debian/debconf/conf.d/acl/30_exim4-config_check_rcpt exim4-4.62/debian/debconf/conf.d/acl/30_exim4-config_check_rcpt
--- exim4-4.62.old/debian/debconf/conf.d/acl/30_exim4-config_check_rcpt 2006-07-14 21:19:12.000000000 +0200
+++ exim4-4.62/debian/debconf/conf.d/acl/30_exim4-config_check_rcpt     2006-07-17 18:07:34.000000000 +0200
@@ -221,6 +221,11 @@
   # Check against DNSBLs which list sender domains, with an option to locally
   # whitelist certain domains that might be blacklisted. If you want one
   # blacklist per domain, you need to replicate the stanza for each DNSBL.
+  #
+  # Note: If you define CHECK_RCPT_DOMAIN_DNSBLS, you must append
+  # "/$sender_address_domain" after each domain.  For example:
+  # CHECK_RCPT_DOMAIN_DNSBLS = rhsbl.foo.org/$sender_address_domain \
+  #                            : rhsbl.bar.org/$sender_address_domain
   .ifdef CHECK_RCPT_DOMAIN_DNSBLS
   warn
     message = X-Warning: $sender_address_domain is listed at $dnslist_domain ($dnslist_value: $dnslist_text)
@@ -228,7 +233,7 @@
     !senders = ${if exists{CONFDIR/local_domain_dnsbl_whitelist}\
                     {CONFDIR/local_domain_dnsbl_whitelist}\
                     {}}
-    dnslists = CHECK_RCPT_DOMAIN_DNSBLS/$sender_address_domain
+    dnslists = CHECK_RCPT_DOMAIN_DNSBLS
   .endif

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-1-amd64-k8
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)

Versions of packages exim4-config depends on:
ii  adduser                       3.87       Add and remove users and groups
ii  debconf [debconf-2.0]         1.5.2      Debian configuration management sy

exim4-config recommends no packages.

-- debconf information excluded