Bug#244724: exim4: passwd.client is better to use wildlsearch and documentation updates

[Marc Haber]

On Sat, Nov 04, 2006 at 08:02:05PM +0900, Osamu Aoki wrote:
> On Sat, Nov 04, 2006 at 10:11:46AM +0100, Marc Haber wrote:
> > On Fri, Nov 03, 2006 at 11:19:55PM +0900, Osamu Aoki wrote:
> > > My ISP put back AUTH for SMTP so I hit this bug again :-)
> > > 
> > > It took me a while to realize the confofuration needs to use canonical
> > > name or just *.  I think Debian provided configuration is better to use
> > > wildsearch than plain lsearch to enable wildcard in the hostname field 
> > > here.
> > 
> > That's a rather neat idea and I'm going to implement this soon. I am
> > wondering, however, that we shuold probably use nwildlsearch instead
> > of the wildlsearch* you have been suggesting. We do not need string
> > expansion there, and wildlsearch* strikes me as redundant. Can you
> > please verify?
> 
> OK.  If this mail goes out, then nwildlsearch is working :-)

Looks good ;)

> > I do not understand this part of the patch. Server authentication does
> > not use passwd.client, and your change is going to introduce wildcards
> > for _user names_, which does not sound desireable. Any chance that
> > this part of the patch is result of a search-and-replace call?
> > 
> > Without better arguments, I'm not going to take this part of the patch.
> 
> This was accidental.

Ok, I suspected this.

> > The other instances of lsearch* have been replaced by nwildlsearch in
> > svn, and pending successful testing, I'm going to upload soon.
> > 
> ...
> > These are very good patches, modulo some Japanisms in the English
> > wording, which I have replaced by appropriate Germanisms ;)
> 
> Also, you may want to update comments passwd.client comments

passwd.client in svn is now:
# password file used when the local exim is authenticating to a remote
# host as a client.
#
# see exim4_passwd_client(5) for more documentation
#
# Example:
### target.mail.server.example:login:password

I do not see any need to adapt this.

>  and reference to passwd.client in 30_exim~xamples too.

I have moved the passwd.client discussion from
conf.d/auth/30_exim4-config_examples to the man page, and added a man
page reference to conf.d/auth/30_exim4-config_examples.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835