Bug#393843: update-exim4.conf fails if user already included "<;"

[Marc Haber]

tags #393843 patch pending
thanks

On Wed, Oct 18, 2006 at 10:01:29AM +0200, Marc Haber wrote:
> On Tue, Oct 17, 2006 at 06:15:18PM -0700, Vineet Kumar wrote:
> > Just glancing at the script (I haven't read it all or claim to
> > understand it all) it looks like it just uses grep to prepend the "<;"
> > if the string contains any ";" -- that's a bug.  If the user-specified
> > value begins with "<", the script shouldn't prepend its own "<;".
> 
> Your diagnosis seems to be correct. I'm going to fix this, but not
> before the version currently in sid has migrated to etch.

The following patch seems to fix this. Can you please verify?

Index: debian/debconf/update-exim4.conf
===================================================================
--- debian/debconf/update-exim4.conf    (revision 1722)
+++ debian/debconf/update-exim4.conf    (working copy)
@@ -309,8 +309,10 @@
 for field in $UPEX4C_semicolon; do
   if eval echo \$$field | grep -q ";"; then
     eval temp=\$$field
-    temp="<; $temp"
-    eval "$field='$temp'"
+    if ! echo $temp | grep -q "^<"; then
+      temp="<; $temp"
+      eval "$field='$temp'"
+    fi
   fi
 done


Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835