Bug#477258: Fails to start because of incorrect command-line arguments

[Matt Kraai]

Package: exim4-base
Version: 4.69-2+b1

When I run "/etc/init.d/exim4 start", it display the following message
and does not start exim:

 Starting MTA:exim: incompatible command-line options or arguments

If I set EX4DEBUG, I see that the failing command is

 /sbin/start-stop-daemon --start --nicelevel 0 --quiet --exec /usr/sbin/exim4 --oknodo --pidfile /var/run/exim4/exim.pid -- -bd -q30m '' '' ''

The last three arguments look suspicious and if I remove them, the
command runs successfully.

These arguments are empty strings because COMMONOPTIONS,
QUEUERUNNEROPTIONS, and SMTPLISTENEROPTIONS are set to the empty
string in /etc/default/exim4 and /etc/init.d/exim4 quotes their
expansions.

The attached patch does not quote their expansions, which fixes the
problem.

-- 
Matt
-------------- next part --------------
diff -ru exim4-4.69~/debian/exim4-base.exim4.init exim4-4.69/debian/exim4-base.exim4.init
--- exim4-4.69~/debian/exim4-base.exim4.init	2008-04-21 15:39:06.000000000 -0700
+++ exim4-4.69/debian/exim4-base.exim4.init	2008-04-21 15:40:07.000000000 -0700
@@ -93,27 +93,27 @@
     combined)
       start_daemon -p "$PIDFILE" \
         "$DAEMON" -bd "-q${QFLAGS}${QUEUEINTERVAL}" \
-        "${COMMONOPTIONS}" "${QUEUERUNNEROPTIONS}" "${SMTPLISTENEROPTIONS}"
+        ${COMMONOPTIONS} ${QUEUERUNNEROPTIONS} ${SMTPLISTENEROPTIONS}
       log_progress_msg "exim4"
       ;;
     separate)
       start_daemon -p "$PIDFILE" \
-        "$DAEMON" -bd "${SMTPLISTENEROPTIONS}" "${COMMONOPTIONS}"
+        "$DAEMON" -bd ${SMTPLISTENEROPTIONS} ${COMMONOPTIONS}
       log_progress_msg "exim4_listener"
       start_daemon -p "$QRPIDFILE" \
         "$DAEMON" -oP "$QRPIDFILE" \
-        "-q${QFLAGS}${QUEUEINTERVAL}" "${QUEUERUNNEROPTIONS}" "${COMMONOPTIONS}"
+        "-q${QFLAGS}${QUEUEINTERVAL}" ${QUEUERUNNEROPTIONS} ${COMMONOPTIONS}
       log_progress_msg "exim4_queuerunner"
       ;;
     queueonly)
       start_daemon -p "$QRPIDFILE" \
         "$DAEMON" -oP "$QRPIDFILE" \
-        "-q${QFLAGS}${QUEUEINTERVAL}" "${QUEUERUNNEROPTIONS}" "${COMMONOPTIONS}"
+        "-q${QFLAGS}${QUEUEINTERVAL}" ${QUEUERUNNEROPTIONS} ${COMMONOPTIONS}
       log_progress_msg "exim4_queuerunner"
       ;;
     no|ppp)
       start_daemon -p "$PIDFILE" \
-        "$DAEMON" -bd "${SMTPLISTENEROPTIONS}"
+        "$DAEMON" -bd ${SMTPLISTENEROPTIONS}
       log_progress_msg "exim4_listener"
       ;;
     nodaemon)