Bug#477578: exim4-base: incorrect logic in init script

[Andreas Metzler]

tags 477578 pending
thanks
On 2008-04-24 Tim Cross <tcross at une.edu.au> wrote:
> Package: exim4-base
> Version: 4.69-2+b1
> Severity: normal

> I think the logic in the /etc/init.d/exim4 script is incorrect. In the
> script, there is the following ....

> if ! [ -x "/lib/lsb/init-functions" ]; then
>   . /lib/lsb/init-functions
> else
>   echo "E: /lib/lsb/init-functions not found, lsb-base (>= 3.0-6) needed"
>   exit 1
> fi

> /lib/lsb/init-functions is not executed, does not have the execute
> permission set and is only 'sourced'. This means the -x test will
> fail. However, this error is masked by the negation of the
> test.
[...]
> As the file is being sourced rather than executed, it would probably
> be better to replace this with 

> if [ -r "/lib/lsb/init-functions" ]; then
>   . /lib/lsb/init-functions
[...]

Thanks for bugreport and analysis. Fix is commited to svn.
cu andreas