Bug#476249: exim4-config: minimaldns does not work if no FQDN is configured in /etc/hosts

[gregor herrmann]

On Sun, 20 Apr 2008 20:28:14 +0200, Marc Haber wrote:

> > update-exim4.conf should print a warning if minimaldns is requested
> > but hostname --fqdn does not print an FQDN.
> Committed to svn, thanks.

I just updated to 4.69-3 and got the "hostname --fqdn did not return
a fully qualified name, ..." warning. As far as I understood the bug
report the idea is to test for the existence of a dot in the output
of `hostname --fqdn' and warn otherwise.

# hostname --fqdn                         
nerys.comodo.priv.at

Looking through the code of /usr/sbin/update-exim4.conf I was
thinking if you maybe forgot a "not"; currently there is (lines 360
ff)

  if echo $guessed_name | grep -q '\.'; then
    errormessage "hostname --fqdn did not return a fully qualified name, dc_minimaldns wi
  fi

Is it possible that the logic should me more like "if grep doesn't
find a dot then errormessage", i.e.

  if ! echo $guessed_name ...

or

  if echo $guessed_name | grep -q -v '\.' ...


Thanks for your work on exim!

Cheers,
gregor
 
-- 
 .''`.   http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
 : :' :  debian gnu/linux user, admin & developer - http://www.debian.org/
 `. `'   member of https://www.vibe.at/ | how to reply: http://got.to/quote/
   `-    NP: Paul Simon: I Know What I Know
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-exim4-maintainers/attachments/20080426/da1c810a/attachment.pgp