Bug#1074942: exim4: ftbfs with GCC-14

[Matthias Klose]

Package: src:exim4
Version: 4.97-8
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/exim4_4.97-8_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
 4233 | if (cmdline_syslog_name)
      |    ^
exim.c:4271:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
 4271 | if (log_oneline)
      |    ^
exim.c:4363:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
 4363 | if (  removed_privilege
      |    ^
exim.c:4508:21: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 4508 |      || count_queue && queue_list_requires_admin
      |         ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
exim.c:4509:20: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 4509 |      || list_queue && queue_list_requires_admin
      |         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
exim.c:4510:18: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 4510 |      || qrunners && prod_requires_admin
      |         ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
exim.c:4511:25: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 4511 |      || queue_name_dest && prod_requires_admin
      |         ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
exim.c:4512:18: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 4512 |      || debugset && !f.running_in_test_harness
      |         ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
exim.c:4669:6: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
 4669 |   if (rv == -1)
      |      ^
exim.c:4790:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
 4790 | if (rcpt_verify_quota)
      |    ^
exim.c:5196:23: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 5196 | if (  !sender_address && !smtp_input
      |       ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
exim.c:5218:19: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 5218 | if (  !smtp_input && !sender_address
      |       ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
exim.c:5381:12: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
 5381 |     while (s = get_stdinput(fn_readline, fn_addhist))
      |            ^
exim.c:5675:6: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
 5675 |   if (expand_string_message)
      |      ^
exim.c:5839:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
 5839 |         if (recipients_max > 0 && ++rcount > recipients_max &&
      |            ^
exim.c:5860:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
 5860 |         if (recipient)
      |            ^
exim.c:5873:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
 5873 |         if (!recipient)
      |            ^
In file included from local_scan.h:33,
                 from exim.h:534:
mytypes.h:104:28: warning: ignoring return value of 'chdir' declared with attribute 'warn_unused_result' [-Wunused-result]
  104 | #define Uchdir(s)          chdir(CCS(s))
      |                            ^~~~~~~~~~~~~
exim.c:4453:10: note: in expansion of macro 'Uchdir'
 4453 |   (void) Uchdir(spool_directory);
      |          ^~~~~~
exim.c: In function 'usr1_handler':
exim.c:342:7: warning: ignoring return value of 'write' declared with attribute 'warn_unused_result' [-Wunused-result]
  342 | (void)write(fd, process_info, process_info_len);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:847: exim.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/b-exim4-daemon-light/build-Linux-x86_64'
make[2]: *** [Makefile:37: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/b-exim4-daemon-light'
make[1]: *** [debian/rules:121: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:324: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2