[pymvpa] Use of import *
debian at onerussian.com
Thu Jun 5 13:57:20 UTC 2008
but that is only in the tests... and I explicitly specified __all__ for
tests_warehouse so we don't suck in anything irrelevant with that import
On Thu, 05 Jun 2008, Per B. Sederberg wrote:
> Absolutely!!! 'import *' is a very very bad thing that has bitten me
> more times than I care to admit. Let's take them out!
> On Thu, Jun 5, 2008 at 3:34 AM, Michael Hanke <michael.hanke at gmail.com> wrote:
> > Hi folks,
> > recently there have been a number of commits introducing 'import *'
> > statements and in addition removal of import statements, because the
> > respective modules were imported in other modules which in turn were
> > import with '*'. Now pylint is screaming desperately -- and after having
> > thought about it, I think it is right.
> > The previous way of explicitely importing every single piece with absolute
> > references gave each module a nice list of internal and external
> > dependencies. If we (re)move/named something we immediately noticed
> > what would break, by simple importing the module. All those 'import *'
> > kill this advantage. Now 'import *' would almost always succeed and we
> > rely on actually running *all* code to see what break. A proper unit
> > test battery somewhat deals with it, but IMHO we should not remove that
> > additional source of trust.
> > If you agree with my judgement, I would add a devguide snippet about it.
> > BTW: I'm not talking about mvpa.suite which is for interactive PyMVPA
> > and fine as it is.
> > Did I miss something?
> > Michael
> > --
> > GPG key: 1024D/3144BE0F Michael Hanke
> > http://apsy.gse.uni-magdeburg.de/hanke
> > ICQ: 48230050
> > _______________________________________________
> > Pkg-ExpPsy-PyMVPA mailing list
> > Pkg-ExpPsy-PyMVPA at lists.alioth.debian.org
> > http://lists.alioth.debian.org/mailman/listinfo/pkg-exppsy-pymvpa
> Pkg-ExpPsy-PyMVPA mailing list
> Pkg-ExpPsy-PyMVPA at lists.alioth.debian.org
Research Assistant, Psychology Department, Rutgers-Newark
Student Ph.D. @ CS Dept. NJIT
Office: (973) 353-5440x263 | FWD: 82823 | Fax: (973) 353-1171
101 Warren Str, Smith Hall, Rm 4-105, Newark NJ 07102
More information about the Pkg-ExpPsy-PyMVPA