[Pkg-fglrx-devel] Bug#554401: Bug#554401: Bug#554401: fglrx doesn't build with linux 2.6.32-rcX

[Michael Gilbert]

On Wed, 04 Nov 2009 17:57:38 +0100, Patrick Matthäi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Stefan Bühler schrieb:
> > Package: fglrx-driver
> > Version: 1:9-10-1
> > 
> > Hi,
> > 
> > fglrx doesn't build with linux 2.6.32-rcX.
> > 
> > #include <linux/signal.h>
> > 
> > in common/lib/modules/fglrx/build_mod/kcl_io.c fixes this - this shouldn't 
> > hurt any older version.
> > 
> > I also recommend fixing some warnings, see attached patch.
> 
> Hi,
> 
> thanks for your patch, I comitted the signal one, for safety reasons I
> didn't commit the warning fixes.

i looked at the patch for the warnings, and the fixes look safe to me.
the first casts the output of virt_to_phys to the type expected by
DMA_PROC_PRINT.  the second moves the initialization of bus_addr into
the scope of only the #IFDEF for which it is used.

however, we usually don't patch upstream code just to fix warnings, so
if you are interested in getting this fixed, a bug should be submitted
to amd.

thanks for your patch!

mike