[Pkg-fglrx-devel] Bug#636450: closed by Michael Gilbert <michael.s.gilbert at gmail.com> (Bug#636450: fixed in fglrx-driver 1:11-7-3)

[Andreas Beckmann]

reopen 636450
found 636450 1:11-7-3
thanks

Reopening because the unwanted move/duplication of files was not addressed.

New patch series:

20-rename-before-install-and-drop-duplicate-files.diff
  * that is the important patch to restore the files to the location
    they had in 11-6-3 and remove the duplicates
  * renaming needs to be done early
  * fixup (chmod etc.) needs to be done early (dh_install)
  * doing the previous two steps at dh_builddeb is too late: all the
    other debhelper scripts have been run on the "wrong" filenames
  * therefore rename (actually hardlink) the files in
    override_dh_auto_configure and cleanup in override_dh_auto_clean
  * now no debian/*.install* needs to know about "wrong" filenames
  * now debian/rules does not need to know what gets installed in which
    package and location
  * do it for i386 and amd64 ignoring the architecture we are building
    for also simplifies things
  * greatly simplifies later tasks: package splitting, multiarch
  * a different solution for fglrx-libglx.so that avoids renaming is to
    modify glx-alternative-fglrx. if you would prefer this, I can make
    the neccessary changes there

21-remove-redundant-package-name-from-lintian-overrides.diff
  * the package name in debian/*.lintian-overrides is redundant
    information - so remove this to simplify package splitting and
    renaming

22-wildcard-lintian-overrides.diff
  * I'd suggest to just use wildcards for the most common overrides:
    spelling-error-in-binary and source-contains-prebuilt-binary
    instead of listing every occurrence

23-use-DEB_HOST_ARCH-and-prepare-multiarch-support.diff
  * DEB_BUILD_ARCH is the wrong decision point, it's not neccessarily
    the target architecture, use DEB_HOST_ARCH instead
  * also this variable needs to be initialized
  * while we are at it, get DEB_HOST_MULTIARCH, too and add a
    substitution variable _LIBDIR_ which will get a value of
    usr/lib (without MULTIARCH) or usr/lib/$(DEB_HOST_MULTIARCH)

I have the above patches in a state where I can quickly commit them to
the SVN, if you agree.

Some general style suggestion: in Makefiles for $(shell ...) and
$(wildcard ...) evaluations I usually prefer single expansion
(var := $(shell ...)) if possible. otherwise each evaluation of the
variable runs the command again and again

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20-rename-before-install-and-drop-duplicate-files.diff
Type: application/pgp-keys
Size: 4998 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fglrx-devel/attachments/20110805/cb5d3b3a/attachment-0004.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 21-remove-redundant-package-name-from-lintian-overrides.diff
Type: application/pgp-keys
Size: 20459 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fglrx-devel/attachments/20110805/cb5d3b3a/attachment-0005.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 22-wildcard-lintian-overrides.diff
Type: application/pgp-keys
Size: 3155 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fglrx-devel/attachments/20110805/cb5d3b3a/attachment-0006.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 23-use-DEB_HOST_ARCH-and-prepare-multiarch-support.diff
Type: application/pgp-keys
Size: 2123 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fglrx-devel/attachments/20110805/cb5d3b3a/attachment-0007.key>