[Pkg-fglrx-devel] xvba-va-driver_0.8.0 patch

[Norbert Bérci]

Dear fglrx devel team,

Please find attached a patch to the xvba-va-driver_0.8.0-4 package (source: 
xvba-va-video).

The patch fixes a bug which caused the driver to trigger the following assert:
xvba_image.c:453: commit_hw_image: Assertion `hw_image_hooks_glx.create' failed.

This bug can be triggered by (for example) MPlayer (mplayer-vaapi, available 
from the git://gitorious.org/vaapi/mplayer.git mplayer-vaapi repository) if the 
OSD is switched on.

The solution is obvious: the declaration of hw_image_hooks_glx in 
src/xvba_image.c line 473 created a new uninitialised(!) variable instead of 
using the one defined in src/xvba_video_glx.c line 432, so a simple "extern" 
solved the issue.

I hereby declare that the attached patch to be under the GNU GPLv2 or above, or 
any other licence you (the Fglrx packaging team) consider appropriate.

Please reply to me directly if you have any questions, I am not subscribed to 
devel lists.

Kind regards,

-- 
Norbert Bérci

-------------- next part --------------
diff -ur xvba-video-0.8.0/src/xvba_image.c xvba-video-0.8.0-patched/src/xvba_image.c
--- xvba-video-0.8.0/src/xvba_image.c	2011-06-14 13:07:13.000000000 +0200
+++ xvba-video-0.8.0-patched/src/xvba_image.c	2012-07-22 14:55:14.186667413 +0200
@@ -423,7 +423,7 @@
 }
 
 #if USE_GLX
-const HWImageHooks hw_image_hooks_glx attribute_hidden;
+extern const HWImageHooks hw_image_hooks_glx attribute_hidden;
 #endif
 
 // Commit image to the HW