[Pkg-fglrx-devel] Bug#682419: xvba-va-driver: assert triggered when using the GLX backend

[Norbert Berci]

Package: xvba-va-driver
Version: 0.8.0-4
Severity: important
Tags: upstream patch

Dear Maintainer,

The patch fixes a bug which caused the driver to trigger the following assert:
xvba_image.c:453: commit_hw_image: Assertion `hw_image_hooks_glx.create' failed.

This bug can be triggered by (for example) MPlayer (mplayer-vaapi, available from the
git://gitorious.org/vaapi/mplayer.git mplayer-vaapi
repository) if the OSD is switched on. Without OSD the driver works without
problems, since there is no need to overlay text.

The solution is obvious: the declaration of hw_image_hooks_glx
in src/xvba_image.c line 473 created a new uninitialised(!) variable instead
of using the one defined in src/xvba_video_glx.c line 432, so a simple
"extern" solved the issue.

I hereby declare that the attached patch to be under the GNU GPLv2 or above, or any other
licence the Fglrx packaging team consider appropriate.

Regards,
Norbert Bérci

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=hu_HU.UTF-8, LC_CTYPE=hu_HU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xvba-va-driver depends on:
ii  libc6                     2.13-33
ii  libgl1-mesa-glx [libgl1]  8.0.3-1
ii  libx11-6                  2:1.5.0-1
ii  libxext6                  2:1.3.1-2
ii  libxvbaw1                 1:12-3-1~bpo60+1

xvba-va-driver recommends no packages.

xvba-va-driver suggests no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xvba-video-0.8.0-glx-fix.patch
Type: text/x-diff
Size: 437 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fglrx-devel/attachments/20120722/df52b007/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xvba-video-0.8.0-glx-fix.patch
Type: text/x-diff
Size: 437 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fglrx-devel/attachments/20120722/df52b007/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xvba-video-0.8.0-glx-fix.patch
Type: text/x-diff
Size: 437 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-fglrx-devel/attachments/20120722/df52b007/attachment-0002.patch>