[Pkg-fglrx-devel] xvba-va-driver_0.8.0 patch

[Norbert Bérci]

On 12.07.22. 16:36, Patrick Matthäi wrote:
> Am 22.07.2012 16:15, schrieb Norbert Bérci:
>> Dear fglrx devel team,
>>
>> Please find attached a patch to the xvba-va-driver_0.8.0-4 package
>> (source: xvba-va-video).
>>
>> The patch fixes a bug which caused the driver to trigger the following
>> assert:
>> xvba_image.c:453: commit_hw_image: Assertion `hw_image_hooks_glx.create'
>> failed.
>>
>> This bug can be triggered by (for example) MPlayer (mplayer-vaapi,
>> available from the git://gitorious.org/vaapi/mplayer.git mplayer-vaapi
>> repository) if the OSD is switched on.
>>
>> The solution is obvious: the declaration of hw_image_hooks_glx in
>> src/xvba_image.c line 473 created a new uninitialised(!) variable
>> instead of using the one defined in src/xvba_video_glx.c line 432, so a
>> simple "extern" solved the issue.
>>
>> I hereby declare that the attached patch to be under the GNU GPLv2 or
>> above, or any other licence you (the Fglrx packaging team) consider
>> appropriate.
>>
>> Please reply to me directly if you have any questions, I am not
>> subscribed to devel lists.
> Thanks for it.
>
> Could you open up a bugreport for it?
>
> Is this patch/bug already known by upstream?
>

I have opened a bug report, #682419.

The bug/patch is not known upstream: according to 
http://code.splitted-desktop.com/git/?p=xvba-video.git;a=log the last commit was 
on Tue, 14 Jun 2011 11:21:10 +0000, which contains the bug.

By the way, upstream location http://www.splitted-desktop.com/~gbeauchesne/ 
seems to be down, upstream maintainer left AMD, now at Intel (at least according 
to http://www.phoronix.com/scan.php?page=news_item&px=MTEyNDk in paragraph 4).

--
Norbert Bérci