[Pkg-fglrx-devel] Bug#697395: lintian: False positive: preinst-uses-dpkg-maintscript-helper-without-predepends

[Niels Thykier]

On 2013-01-04 21:15, Patrick Matthäi wrote:
> Am 04.01.2013 21:02, schrieb Patrick Matthäi:
>> Package: lintian
>> Version: 2.5.10.3
>> Severity: normal
>>
>> Hello,
>>
>> I have found an false positive about preinst-uses-dpkg-maintscript-helper-without-predepends.
>> For example fglrx-driver:
>>
>> lintian complains about:
>>   preinst-uses-dpkg-maintscript-helper-without-predepends
>>
>> withing every package. The extended description says:
>>
>> 	N:    The package contains a preinst maintainer script that uses
>> 	N:    dpkg-maintscript-helper but does not declare a versoned pre-dependency
>> 	N:    on dpkg (>= 1.15.7.2~) that provides that script.
>>
>> So adding a Pre-Depends on dpkg (>= 1.15.7.2~) is enough and will work to prevent this
>> message, but fglrx-driver also switched to xz compression!
>> lintian suggests:
>>
>> 	N:    The deb uses xz compression for the data member, which requires a
>> 	N:    Pre-Depends on dpkg (>= 1.15.6~). This is trivially satisfied in Debian,
>> 	N:    but it can complicate upgrades from Ubuntu Lucid where dpkg 1.15.6 is
>> 	N:    not currently available.
>>
>> So the correct way (to prevent faults abouts preinst-uses-dpkg-maintscript-helper-without-predepends
>> and data.tar.xz-member-without-dpkg-pre-depends) would be to add a Pre-Depends on dpkg (>= 1.15.6~).
>> Done, but lintian still complains about the preinst-uses-dpkg-maintscript-helper-without-predepends
>> one.
>>
>> You can reproduce it with svn://svn.debian.org/svn/pkg-fglrx/fglrx-driver/branches/experimental
>> revision 1146 for example.
> 
> 
> Ohh dear, please don't laugh, I think I am confused..
> This issue appears in exactly the another way and now I also comitted shit..
> 
> fglrx-driver Pre-Depends:..
> 	dpkg 1.15.6~ because of the xz compression
> 	dpkg 1.15.7.2~ because of the maintscript helper
> 
> So on a Pre-Depends on 1.15.7.2~ is the correct one and
> data.tar.xz-member-without-dpkg-pre-depends is faulty.
> 

Hi,

I suspect I have gotten a bit confused as well now as to what the
problem is exactly.

If the package uses a data.tar.xz member it needs "dpkg (>= 1.15.6~)".
If the package uses dpkg-maintscript-helper, it would need a Pre-Depends
on "dpkg (>= 1.15.7.2~)".
  If it has both, then it needs "dpkg (>= 1.15.7.2~)", which is the
"stronger" requirement of the two.

If we can agree on paragraph above, then I am not sure I see where
Lintian made a false-positive?

~Niels