[Pkg-fglrx-devel] Bug#768397: fglrx-modules-dkms 1:14.9+ga14.201-2 don't build against kernel 3.17.0

[nbi at wideopenwest.com]

On Thu, 06 Nov 2014 20:29:23 -0600 nbi at wideopenwest.com wrote:
 > Package: fglrx-modules-dkms
 > Version: 1:14.9+ga14.201-2
 >
 > Package: linux-source-3.17
 > Version: 3.17-1~exp1
 >
 > Modules fail to build via dkms:
 >
 > dkms build fglrx/14.9+ga14.201 -k 3.17.0 -a x86_64
 >
 > Kernel preparation unnecessary for this kernel. Skipping...
 >
 > Building module:
 > cleaning build area....
 > make KERNELRELEASE=3.17.0 -C /lib/modules/3.17.0/build
 > M=/var/lib/dkms/fglrx/14.9+ga14.201/build.....(bad exit status: 2)
 > Error! Bad return status for module build on kernel: 3.17.0 (x86_64)
 > Consult /var/lib/dkms/fglrx/14.9+ga14.201/build/make.log for more
 > information.
 >
 > DKMS make.log for fglrx-14.9+ga14.201 for kernel 3.17.0 (x86_64)
 > Thu Nov 6 20:07:22 CST 2014
 > make: Entering directory '/usr/src/linux-source-3.17'
 > LD /var/lib/dkms/fglrx/14.9+ga14.201/build/built-in.o
 > CC [M] /var/lib/dkms/fglrx/14.9+ga14.201/build/firegl_public.o
 > /var/lib/dkms/fglrx/14.9+ga14.201/build/firegl_public.c:6387:12:
 > warning: ‘KCL_fpu_save_init’ defined but not used [-Wunused-function]
 > static int KCL_fpu_save_init(struct task_struct *tsk)
 > ^
 > CC [M] /var/lib/dkms/fglrx/14.9+ga14.201/build/kcl_acpi.o
 > /var/lib/dkms/fglrx/14.9+ga14.201/build/kcl_acpi.c: In function
 > ‘KCL_ACPI_Slot_No_Hotplug’:
 > /var/lib/dkms/fglrx/14.9+ga14.201/build/kcl_acpi.c:845:21: error:
 > ‘struct acpi_device_flags’ has no member named ‘no_hotplug’
 > tdev->flags.no_hotplug = true;
 > ^
 > scripts/Makefile.build:257: recipe for target
 > '/var/lib/dkms/fglrx/14.9+ga14.201/build/kcl_acpi.o' failed
 > make[1]: *** [/var/lib/dkms/fglrx/14.9+ga14.201/build/kcl_acpi.o] Error 1
 > Makefile:1390: recipe for target
 > '_module_/var/lib/dkms/fglrx/14.9+ga14.201/build' failed
 > make: *** [_module_/var/lib/dkms/fglrx/14.9+ga14.201/build] Error 2
 > make: Leaving directory '/usr/src/linux-source-3.17'
 >
 >

Since there will never be "hotplugging" of any kind I commented out the 
offending code at kcl_acpi.c:845 and it rebuilt and installed without 
incident. This was an easy fix, but should still be addressed so that 
non-developers don't trip on it.
Thanks.