[Pkg-fonts-devel] Bug#772687: Bug#772687: Bug#772687: Bug#772687: Bug#772687: Bug#772687: fonts-droid: fallback font is installed too early to fontconfig

[Jonas Smedegaard]

Quoting Vasudev Kamath (2014-12-29 07:13:34)
> Norbert Preining <preining at logic.at> writes:
> 
> > On Sun, 28 Dec 2014, Vasudev Kamath wrote:
> >> I've prepared the package and updated maintscript file to handle now
> >> obsolete 65-droid-sans-fallback.conf file removal.
> >
> > Hmm, something is funny here ... building the package I see:
> >
> > for f in DroidSansFallback.ttf DroidSansFallbackLegacy.ttf ; \
> > do \
> >       cd debian/fonts-droid/usr/share ; \
> >       mv fonts/truetype/droid/$f \
> >               fonts-droid/truetype/$f || true ; \
> > done
> > /bin/sh: 3: cd: can't cd to debian/fonts-droid/usr/share
> >
> > but stil the fonts end up in /usr/share/fonts-droid/truetype/ ...
> > One of you will know why ...
> 
> It looks like Christian introduced these changes to close the
> bug#762296, I think the error message comes second time when the cd is
> executed in for loop. It still works because with first cd we are
> already inside the directory where fonts are present.
> 
> The fix is move the cd outside the for loop. I'm not sure if we have to
> include this now or wait for after Jessie.

Another fix would be to use non-relative path in the cd call.

But (judging only from above comments) there might be another issue with 
that loop not handling errors correctly.  Perhaps as simple as a "set 
-e" (although I seem to recall that maintainer scripts shouldn't blindly 
do that).


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-fonts-devel/attachments/20141229/1dedd46d/attachment-0001.sig>