[Pkg-fonts-devel] Bug#907487: Broken patch debian/patches/unset_OS2_UseTypoMetrics.patch

[Jan-Marek Glogowski]

Package: fonts-liberation
Version: 1:1.07.4-7

Dear maintainers,

actually I was bitten by the bug fixed in 1:1.07.4-6 on Ubuntu 18.04
(https://bugs.launchpad.net/ubuntu/bionic/+source/libreoffice/+bug/1769654) and then I had a look at
the proposed fix / diff and saw in the unpatched debian package:

@@ -17,7 +17,7 @@ XUID: [1021 131 222397055 13598569]
 FSType: 0
 OS2Version: 3
 OS2_WeightWidthSlopeOnly: 0
-OS2_UseTypoMetrics: 1
+OS2_UseTypoMetrics 0
 CreationTime: 1095817380
 ModificationTime: 1399616628
 PfmFamily: 17

which looked broken. I guess it just works, because the default of OS2_UseTypoMetrics is 0, but I
didn't check that.

I checked Debian - same patch.

Then I had a look at the SRPM packages for the bug fix in Fedora, which isn't fixed by a patch at
all, but by:

# Fedora fix for https://bugzilla.redhat.com/show_bug.cgi?id=1526510
sed -i 's/OS2_UseTypoMetrics: 1/OS2_UseTypoMetrics: 0/g' src/*.sfd

The I had a look at the Fontforge code and found:
https://github.com/fontforge/fontforge/blob/master/fontforge/sfd.c#L7946

So I guess the binary result is the same, but just in case the generating font programs become more
strict, please fix the patch.

Thanks

Jan-Marek