Bug#1113776: Downstream Debian/Ubuntu patch breaks flatpak app listing in malcontent

[Philip Withnall]

Package: malcontent
Version: 0.13.0-2

The downstream patch `all_apps.patch` carried in (at least) malcontent
0.13.0-2 contains a bug which causes all flatpak apps to be omitted
from the ‘restrict applications’ list in the UI, making malcontent
ineffective for systems using flatpak.

The patch is viewable online here:
https://sources.debian.org/patches/malcontent/0.13.0-2/all_apps.patch/

The bug was discovered/diagnosed in the upstream issue here:
https://gitlab.freedesktop.org/pwithnall/malcontent/-/issues/99

The patch pulls the `executable` variable in `reload_apps()` out to a
higher scope, but omits to set a value for it in the
`g_desktop_app_info_has_key (G_DESKTOP_APP_INFO (app), "X-Flatpak")`
case. It then filters out all apps with `executable` unset, which ends
up being all flatpak apps.

---

Given that the patch says it’s for `Bug:
https://gitlab.freedesktop.org/pwithnall/malcontent/-/issues/58`, it’s
disappointing that the patch wasn’t submitted upstream even though I
said I was open to such contributions
(https://gitlab.freedesktop.org/pwithnall/malcontent/-/issues/58#note_2035099).

Review upstream would have quickly caught this issue.

It’s even more unfortunate that the patch then happened to break
support for all flatpaks, when it was adding support for snaps.