Bug#914613: xdg-screensaver: Does nothing for many DEs (lxde, dde, enlightenment etc.)

[Teemu Ikonen]

Package: xdg-utils
Version: 1.1.3-1
Severity: normal
Tags: upstream patch

xdg-screensaver detects the running desktop environment and then runs
DE-specific commands to reset or turn on / off the screensaver.  If the
DE is not detected, it uses 'xset s' to control the X server screen
saver extension.

The problem is that xdg-screensaver can recognize more DEs than it has
the code to handle. The generic X server screensaver code is not called
at all when using, for example LXDE. The attached 'sh -x xdg-screensaver
reset' output shows what happens when 'xdg-screensaver reset' is run in
LXDE (nothing useful).

The attached patch makes the 'xset s' codepath the default. It is now
run if the DE is detected, but there is no specialized code to handle
its screensaver.


-- Package-specific info:
Desktop environment: XDG_CURRENT_DESKTOP=LXDE

-- System Information:
Debian Release: 9.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 4.9.0-8-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

xdg-utils depends on no packages.

Versions of packages xdg-utils recommends:
ii  libfile-mimeinfo-perl  0.27-1
ii  libnet-dbus-perl       1.1.0-4+b1
ii  libx11-protocol-perl   0.56-7
ii  x11-utils              7.7+3+b1
ii  x11-xserver-utils      7.7+7+b1

xdg-utils suggests no packages.

-- no debconf information
-------------- next part --------------
+ check_common_commands reset
+ [ 1 -gt 0 ]
+ parm=reset
+ shift
+ [ 0 -gt 0 ]
+ [ -z  ]
+ unset XDG_UTILS_DEBUG_LEVEL
+ [ 0 -lt 1 ]
+ xdg_redirect_output= > /dev/null 2> /dev/null
+ mv -T ... ...
+ grep \.\.\.
+ DEBUG 1 mv -T available
+ [ -z  ]
+ return 0
+ MV=mv -T
+ echo :0.0
+ sed s/:/-/g
+ screensaver_file=/tmp/xdg-screensaver-tpikonen--0.0
+ which lockfile
+ lockfile_command=/usr/bin/lockfile
+ which xprop
+ XPROP=/usr/bin/xprop
+ [ xreset != x ]
+ action=
+ window_id=
+ action=reset
+ detectDE
+ unset GREP_OPTIONS
+ [ -n LXDE ]
+ DE=lxde
+ [ xlxde = x ]
+ [ xlxde = x ]
+ [ xlxde = x ]
+ [ xlxde = xgnome ]
+ [ -f /run/user/1000/flatpak-info ]
+ xscreensaver-command -version
+ grep XScreenSaver
+ dbus-send --print-reply --dest=org.freedesktop.DBus /org/freedesktop/DBus org.freedesktop.DBus.GetNameOwner string:org.gnome.ScreenSaver
+ dbus-send --print-reply --dest=org.freedesktop.DBus /org/freedesktop/DBus org.freedesktop.DBus.GetNameOwner string:org.mate.ScreenSaver
+ xautolock -enable
+ [ reset = resume ]
+ perform_action reset
+ result=1
+ [ reset = resume ]
+ [ reset = reset ]
+ grep DPMS is Enabled
+ xset -q
+ [ -n :0.0 -a reset = suspend ]
+ [ reset = suspend ]
+ [ 1 -eq 0 ]
+ exit_failure_operation_failed
+ [ 0 -gt 0 ]
+ exit 4
-------------- next part --------------
--- xdg-screensaver.orig	2018-05-20 01:18:48.000000000 +0300
+++ xdg-screensaver	2018-11-25 18:30:09.197525065 +0200
@@ -623,7 +623,7 @@
       [ -n "$DISPLAY" ] && screensaver_xserver "$1"
       ;;
 
-    ''|generic)
+    *|generic)
       [ -n "$DISPLAY" ] && screensaver_xserver "$1"
       ;;
   esac