Bug#1018103: ERROR: Unknown command 'lock'

[Antoine Beaupre]

Package: xdg-utils
Version: 1.1.3-4.1
Severity: minor
File: /usr/bin/xdg-screensaver

The xdg-screensaver usage goes like this:

anarcat at curie:~$ xdg-screensaver --help
xdg-screensaver - command line tool for controlling the screensaver

Synopsis

xdg-screensaver suspend WindowID

xdg-screensaver resume WindowID

xdg-screensaver { activate | lock | reset | status }

xdg-screensaver { --help | --manual | --version }

Use 'man xdg-screensaver' or 'xdg-screensaver --manual' for additional info.

Yet the lock command does *not* actually work in bullseye:

anarcat at curie:~$ xdg-screensaver lock
ERROR: Unknown command 'lock'
anarcat at curie:~[4]$

I suspect this is because I fall out of the normal "desktop" scenario:
i use i3 as wm and xss-lock as a screensaver.

looking at the source, it looks like screensaver_xserver() is lacking
a lock() clause. it would suffice to merge it with the activate) case
to fix this bug, I believe. Something like this:

>From 6f2840821c376aa77904e9ee50e6d152186e4a4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Antoine=20Beaupr=C3=A9?= <anarcat at debian.org>
Date: Thu, 25 Aug 2022 13:35:05 -0400
Subject: [PATCH] add lock support to generic desktop environments

---
 scripts/xdg-screensaver.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/xdg-screensaver.in b/scripts/xdg-screensaver.in
index 06d6667..b412a00 100644
--- a/scripts/xdg-screensaver.in
+++ b/scripts/xdg-screensaver.in
@@ -402,7 +402,7 @@ screensaver_xserver()
         result=$?
         ;;
 
-        activate)
+        activate|lock)
         xset s activate > /dev/null
         result=$?
         ;;
-- 
2.30.2

Cheers

-- Package-specific info:
Desktop environment: XDG_CURRENT_DESKTOP=

-- System Information:
Debian Release: 11.4
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'stable-debug'), (500, 'stable'), (1, 'unstable'), (1, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-16-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

xdg-utils depends on no packages.

Versions of packages xdg-utils recommends:
ii  libfile-mimeinfo-perl  0.30-1
ii  libnet-dbus-perl       1.2.0-1+b1
ii  libx11-protocol-perl   0.56-7.1
ii  x11-utils              7.7+5
ii  x11-xserver-utils      7.7+8

xdg-utils suggests no packages.

-- no debconf information