[Pkg-freeipa-devel] Bug#836084: certmonger: please use dbus-run-session to run tests

[Simon McVittie]

Source: certmonger
Version: 0.78.6-3
Severity: normal
Tags: upstream
User: dbus at packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-launch for tests, explicitly invoking
dbus-launch.

It should be possible to replace the use of dbus-launch as follows:

* build-depend on dbus (>= 1.8) instead of dbus-x11
* in tests/Makefile.am, check for dbus-run-session instead of dbus-launch
* in tests/Makefile.am, instead of $(srcdir)/run-tests.sh run
  dbus-run-session -- $(srcdir)/run-tests.sh
* in tests/run-tests.sh, do not unset DBUS_SESSION_BUS_ADDRESS
* in tests/run-tests.sh, do not eval `dbus-launch --sh-syntax`
* in tests/run-tests.sh, do not kill $DBUS_SESSION_BUS_PID

These changes should go upstream. dbus-run-session has been available
since dbus 1.8, which was first released as stable in early 2014 and
is currently the oldest branch that has any sort of upstream security
support.

Thanks,
    S