[Pkg-freeipa-devel] [Git][freeipa-team/389-ds-base][master-next] 45 commits: Ticket 49734 - Fix various issues with Disk Monitoring

Timo Aaltonen gitlab at salsa.debian.org
Tue Jul 31 21:51:42 BST 2018

Timo Aaltonen pushed to branch master-next at FreeIPA packaging / 389-ds-base

1c5831c0 by Mark Reynolds at 2018-06-21T12:49:12Z
Ticket 49734 - Fix various issues with Disk Monitoring

Bug Description:  The first issue what the internal represenation of
                  the default error code changed since the feature was
                  added.  This caused the disk monitoring thread to loop
                  and never actually attempt to stop the server.  The
                  other issue is that with nunc-stans g_set_shutdown()
                  is no longer stops the server.

Fix Description:  Change the defaulterror logging level to be more robust
                  and accept all the default level values.  Also, we needed
                  to free the rotated logs when we delete them.  Finally
                  add raise() to g_set_downdow(), and make sure set_shutdown()
                  does not overwrite the slapd_shutdown value.


Reviewed by: tbordaz & spichugi(Thanks!)

- - - - -
d2c26d89 by Mark Reynolds at 2018-06-21T16:38:32Z
Ticket 49751 - passwordMustChange attribute is not honored by a RO consumer if using "Chain on Update"

Bug Description:  For a chained bind request we do not check password
                  policy, in particular if the password must be reset.

Fix Description:  For a chained bind request check if the password must
                  be reset.  This is the only password policy setting that
                  must be applied on the connection itself.  All other
                  password policy is still enforced correctly.


Reviewed by: spichugi, tbordaz, and lkrispen(Thanks!!!)

- - - - -
87876bca by Samuel Rakitničan at 2018-06-23T07:17:28Z
Update Source0 URL in rpm/389-ds-base.spec.in
- - - - -
749b9f33 by Mark Reynolds at 2018-06-25T21:39:54Z
Ticket 49471 - Rename dscreate options

Description:  Changed the names of the two positional arguemnts from
              "fromfile" --> "install", and "example" --> "create-template"

              Added option for specifying template file instead
              of dumping the template to STDOUT

              Finally added autocomplete arg parsing to the cli tools,
              and used a unique file name in UI when creating template.


Reviewed by: ?

- - - - -
fa41aee9 by Marc Muehlfeld at 2018-06-26T14:24:10Z
Ticket 49793 - Updated descriptions in dscreate example INF file

Description: This patch changes the format of the "dscreate example"
             output to:

                 parameter_name (type) [REQUIRED|optional]
                 Description: ...
                 Default value: ...

             Additionally, the patch updates the parameter descriptions
             to be more descriptive.


Reviewed by: mreynolds

Signed-off-by: Mark Reynolds <mreynolds at redhat.com>

- - - - -
a2cbef23 by Viktor Ashirov at 2018-06-26T21:35:23Z
Issue 49588 - Add py3 support for tickets

Another round of py3 fixes for tests in tickets/.


Reviewed by: mreynolds (Thanks!)

- - - - -
08b2d884 by Viktor Ashirov at 2018-06-27T18:55:57Z
Issue 49717 - Add conftest.py for tests

Bug Description:
>From the test's output it's not possible to tell what version of
389-ds-base was used during the test, what are the versions of
libraries that we depend on, etc.

Fix Description:
We can use conftest.py to print this useful information. This also will
be reflected in an html report, if py.test is used with --html option.


Reviewed by: spichugi, amsharma, mreynolds (Thanks!)

- - - - -
126e700f by Timo Aaltonen at 2018-06-29T13:30:57Z
Issue 49816

Fix linking order of libldaputil/libslapd


- - - - -
eafaf473 by Mark Reynolds at 2018-06-29T16:53:30Z
Ticket 49783 - UI - add server configuration backend

Description: This patch pulls in all the cn=config values and poplues the UI.
             it also allows you to save values to the server.

             Also cockpit can only pull in strerr messages when things fail,
             so I had to undue a recent change to redirect stderr to stdout.


Reviewed by: spichugi & vashirov(Thanks!!)

- - - - -
0d9886e7 by Mark Reynolds at 2018-06-29T16:55:47Z
Ticket 49811 - Update man pages

Bug Description:  A recent man page scan revealed several errors and warnings.

Fix Description:  Added missing man pages, fixed syntax issues, and added
                  new man pages for config files.

                  Also added dynamic man page creation for the lib389 CLI tools
                  using python-argparse-manpages


Reviewed by: spichugi & vashirov(Thanks!!)

- - - - -
177f5c45 by Simon Pichugin at 2018-06-29T19:01:43Z
Issue 49761 - Fix more CI test issues

Description: Mark conflict resolution test cases as 'xfail' (ds49591).
Fix SASL test. Fix Python 3 bytes issues in ds-replcheck tool.
Roll back a part of the PBKDF2_SHA256 schema fix because upgrade fails
without this part of the code.


Reviewed by: vashirov, mreynolds (Thanks!)

- - - - -
d881a4cb by Mark Reynolds at 2018-06-30T14:28:04Z
Ticket 49791 - Update docker file for new dscreate options

Description:  Update docker file to use new option names in dscreate


Review by mreynolds (one line commit rile)

- - - - -
b903b039 by Viktor Ashirov at 2018-07-02T13:42:34Z
Issue 49820 - lib389 requires wrong python ldap library

Bug Description:
python3-ldap [1] is not the same as python-ldap [2].

[1] https://pypi.org/project/python3-ldap/
[2] https://pypi.org/project/python-ldap/

Fix Description:
Update setup.py and requirements.txt.


Reviewed by: mreynolds (Thanks!)

- - - - -
c0a80d28 by Akshay Adhikari at 2018-07-02T14:21:38Z
Issue 49588 - Add py3 support for tickets : part-3

Description: Added py3 support by explicitly changing strings to bytes.


Reviewed by: vashirov (Thanks!)

- - - - -
f80928f4 by Mark Reynolds at 2018-07-02T18:51:45Z
Ticket 49795 - UI - add "action" backend funtionality

Description:  Added the backend functionality for all the items in the "Action"
              dropdown list on the banner.

              Added ability to use the instance name in dsconf, previously
              only ldap URLs worked.

              Added more helper functions:

                popup_confirm() - this now accepts html tags so nicer output
                get_ldapurl_from_serverid(server_id) - take an instance name
                  and generate a LDAP URL from its dse.ldif

              And of course did some code cleanup.


Reviewed by: ?

- - - - -
4404d03d by Mark Reynolds at 2018-07-02T18:54:35Z
Ticket 49811 - lib389 setup.py should install autogenerated man pages

Description:  Create and install the lib389 cli man pages in its
              setup.py file.  Previously running "make" in a dev
              environment was failing because "make' was not installing
              lib389 (and its man pages) which was breaking the build.


Reviewed by: ?

- - - - -
ea7e9897 by Mark Reynolds at 2018-07-03T13:15:23Z
Ticket 49808 - Add option to add backend to dscreate

Description:  Added new directives to the inf file to create multiple
              backends.  Also update the UI for the new options.

              Also, changed some all the inf options to be optional
              except for the rootdn password.

              Did some other minor code cleanup


Reviewed by: vashirov, spichugi, and firstyear (Thanks!!!)

- - - - -
90332887 by Mark Reynolds at 2018-07-05T13:36:51Z
Ticket 49813 - dscreate - add interactive installer

Description:  Added interactive installer to dscreate.  Also
              added signal handlers so that control-c does not
              cause a python stack dump in the cli tools.

              Also quieted the output for dscreate, and made
              it slightly more friendly.


Reviewed by: spichugi(Thanks!)

- - - - -
185963ef by Mark Reynolds at 2018-07-06T16:48:58Z
Ticket 49832 - remove tcmalloc references

Description:  We now bundle jemalloc, so stop building the server
              with tcmalloc.


Reviewed by: mreynolds(one line commit rule)

- - - - -
8fa838a4 by Mark Reynolds at 2018-07-09T15:47:29Z
Ticket 49830 - Import fails if backend name is "default"

Bug Description:  The server was previously reserving the backend
                  name "default".  If you tried to import on a
                  backend with this name the import would skip all
                  child entries

Fix Description:  Change the default backend name to something
                  obscure, instead of "default".

                  Also improved lib389's dbgen to generate the
                  correct "dc" attribute value in the root node.


Reviewed by: spichugi(Thanks!)

- - - - -
5537467e by Ludwig Krispenz at 2018-07-10T13:04:20Z
Ticket 49780 - acl_copyEval_context double free

Bug: There is a connection an operation extension to keep evaluation
     results cached across multiple operations.
     In the geteffective for each evaluation a sepatate temporary connection
     extension is created and freed. If there are several concurrent operations
     in one connection the operation extension destructor can try to access
     an already freed connection extension.

Fix: Do not free the connectcion extension during the life time of a
     connection. If a temporary extension should be used, lock the connection extension,
     copy the content  to a saved structure and copy the temporary data to the
     connection extension. When done with the temporary extension reverse this.
     To make this work the locks need to be directly created, the use of the limited
     preallocated array of locks could lead to a situation where both the main and
     the temporary extension would get the sam elock assigned.

Reviewed by: Thierry and Mark, Thanks

- - - - -
4206d278 by Thierry Bordaz at 2018-07-10T13:30:48Z
Ticket 48818 - For a replica bindDNGroup, should be fetched the first time it is used not when the replica is started

Bug Description:
	The fetching of the bindDNGroup is working as designed but this ticket is to make it more flexible

	At startup, if the group does not contain the replica_mgr.
	No replication session will succeed until bindDnGroupCheckInterval delay.
	updatedn_group_last_check is the timestamp of the last fetch. At startup
	updatedn_group_last_check is set to the current time. So the next fetch will happen not before

	If the groupDn is changed after startup, no incoming replication can happen for the first
	bindDnGroupCheckInterval seconds

Fix Description:
	The fix consist to unset updatedn_group_last_check so that the group will be fetch when the first
	incoming replication session will happen.


Reviewed by: Mark Reynolds, Simon Spichugi (thanks !!!)

Platforms tested: F27

Flag Day: no

Doc impact: no

- - - - -
df95edbe by Stanislav Laznicka at 2018-07-10T14:40:34Z
Issue 49835 - lib389: fix logging

The python standard logging module allows to postpone the string
interpolation in logs till the time the interpolation is actually
needed (note that you may be running in a certain logging level
that won't need to display/write all strings). This behavior is
there to comply with the logging requirement so that logs don't
affect the performance if no logging happens.

The above behavior only works when strings are passed as arguments
to the logging methods. If the interpolation is invoked at place
either by using the `%` notation or by using the `str.format()`
method, python logging can't perform its performance heuristics
since the strings get interpolated before they are handed to the
logging methods.

This commit fixes the improper behavior observed in the lib389
library, plus adds some fixes to improper invokes of the logging
methods - multiple arguments if formatting string does not contain
formatting variables -  which would cause internal logging errors
that don't cause the scripts failures, which is why they probably
weren't reported yet.


Reviewed by: mreynolds, spichugi

Signed-off-by: Simon Pichugin <simon.pichugin at gmail.com>

- - - - -
2fa04088 by Simon Pichugin at 2018-07-10T15:18:00Z
Issue 49640 - Cleanup plugin bootstrap logging

Bug Description: We add PBKDF2_SHA256 password storage schema two times. During:
1. the dse.ldif parsing;
2. the bootstrap plugin operation.
It causes the error to appear during the startup.

Fix Description: Make plugin_setup() function report the error to TRACE log level
if the plugin already exists. We will report the error in ERR log level during
the config bootstrap anyway (code path for the 1st option from bug description).
For 2nd option, report the error to TRACE if it is 'already exist' issue
and to ERR if it is any other case.

Make the plugin_setup returns more consistent.


Reviewed by: mreynolds, mhonek (Thanks!)

- - - - -
60cb5204 by Mark Reynolds at 2018-07-12T14:25:41Z
Ticket 49840 - ds-replcheck command returns traceback errors against ldif files having garbage content when run in offline mode

Description:  Added a basic check to see if the LDIF files are actually
              LDIF files.  Also added checks that the database RUV are
              present as well.


Reviewed by: spichugi(Thanks!)

- - - - -
6d4caac0 by Mark Reynolds at 2018-07-13T12:27:43Z
Ticket 49546 - Fix issues with MIB file

Description:  Change dsMaxThreadsHit to dsMaxThreadsHits, and set the
              proper object type for dsIntIndex


Reviewed by: spichugi & firstyear(Thanks!!)

- - - - -
fbe62eb7 by Amita Sharma at 2018-07-16T13:46:40Z
Test that memberof does not fail if group is moved into scope

Description: Added a test test_memberof_group() to test bug1551071,
it tests that memberof does not fail if group is moved into scope


Reviewed by: Simon

- - - - -
7892486b by Stanislav Laznicka at 2018-07-16T18:57:50Z
Issue 49844 - lib389: don't set up logging at module scope

Bug description: lib389 was calling `logging.basicConfig()`
at several places at module scope level. This was causing
imports from these modules to add an unwanted handler
to the root logger of the python's standard logging module.

Fix description: Set up logging only in the scripts that are
using lib389.
ALso, remove unused imports in __init__.py


Reviewed by: spichugi, mreynolds (Thanks!)

Signed-off-by: Simon Pichugin <spichugi at redhat.com>

- - - - -
e81fa859 by Thierry Bordaz at 2018-07-17T09:34:26Z
Ticket 49789 - By default, do not manage unhashed password

Bug Description:
    By default, unhashed#user#password is recorded into changelog database.
    It is a specific use when some plugin need to know the clear text password on update.
    This should be disabled ('off') by default

Fix Description:
    Switch the default value from 'on' to 'off'


Reviewed by: Viktor Ashirov, Simon Pichugi, Mark Reynolds

Platforms tested: F27

Flag Day: no

Doc impact: no

- - - - -
4f5f6bb5 by Mark Reynolds at 2018-07-17T14:23:31Z
Ticket 49813 - Revised interactive installer

              Removed some advanced settings from the install questions.
              Moved the signal handlers to non-verbose runs.
              Fixed some mixed case issues.
              Added option for sample entries.
              Added "interactive" argument, and restored "fromfile"
              from "install".


Reviewed by: mmuehlfeldrh & spichugi(Thanks!!)

- - - - -
9110d2b4 by Mark Reynolds at 2018-07-17T15:48:05Z
Ticket 48377 - Move jemalloc license to /usr/share/licences

Description:  Move jemalloc license (COPYING.jemalloc) to /usr/share/licences

              also added nss version dependancy that was missing


Reviewed by: mreynolds(one line commit rule)

- - - - -
3fc43bdc by Mark Reynolds at 2018-07-17T17:34:03Z
Bump version to

- - - - -
a9fa2104 by Mark Reynolds at 2018-07-18T13:31:42Z
Ticket 49857 - RPM scriptlet for 389-ds-base-legacy-tools throws an error

Bug Description:  If no instances are present when the legacy tool
                  subpackage is installed the RPM scriplet throws an

                       line 29: [: -eq: unary operator expected

Fix Description:  The error occurs because a variable that counts the
                  existing instances is not initialized.


Reviewed by: mreynolds (one line commit rule)

- - - - -
172c60a2 by Mark Reynolds at 2018-07-18T16:01:53Z
Ticket 49789 - backout original fix as it caused a regression in FreeIPA

Description:  This change broke FreeIPA, so for now we need to back it out


- - - - -
ba5900ee by Mark Reynolds at 2018-07-18T17:32:47Z
Ticket 49806 - Add SASL functionality to CLI/UI

Description:  Add SASL functionality to dsconf and UI

              Improved installer to load the template-sasl ldif

              Also cleaned up some of the "clear form" functions
              to be more efficient using jquery.


Reviewed by: spichugi(Thanks!)

- - - - -
dd183895 by Mark Reynolds at 2018-07-19T17:02:16Z
Ticket 49854 - ns-slapd should create run_dir and lock_dir directories at startup

Description:  dscreate was not creating its config file in /etc/tmpfiles.d/ like
              setup-ds.pl used to do.  The absence of this config file prevented
              the server from being started after a reboot.


Reviewed by: vashirov(Thanks!)

- - - - -
345221c0 by Mark Reynolds at 2018-07-19T18:38:15Z
Bump version to

- - - - -
b7fe3ea9 by Timo Aaltonen at 2018-07-31T17:23:02Z
Merge tag '389-ds-base-' into master-next

- - - - -
f2254733 by Timo Aaltonen at 2018-07-31T17:45:12Z
update changelog

- - - - -
ee619c25 by Timo Aaltonen at 2018-07-31T17:46:13Z
Revert "control: Drop 389-ds metapackage, the other 389-ds-* packages are EOL'd upsream and will be removed soon."

This reverts commit bffa315b777248c5ec6f627478ebfbb372458eb0.

- - - - -
c1c67ef6 by Timo Aaltonen at 2018-07-31T18:52:20Z
control: Modify 389-ds to depend on cockpit-389-ds and drop the old GUI packages which are deprecated upstream.

- - - - -
a9b1666d by Timo Aaltonen at 2018-07-31T19:30:52Z
drop fix-linking.diff, upstream

- - - - -
8f634923 by Timo Aaltonen at 2018-07-31T20:16:50Z
dont-build-new-manpages.diff: Debian doesn't have argparse-manpage, so in order to not FTBFS don't build new manpages.

- - - - -
028dadcd by Timo Aaltonen at 2018-07-31T20:35:17Z
base.install: Add man5/*.

- - - - -
222d75b7 by Timo Aaltonen at 2018-07-31T20:46:28Z
releasing package 389-ds-base version

- - - - -

30 changed files:

- Makefile.am
- configure.ac
- debian/389-ds-base.install
- debian/changelog
- debian/control
- + debian/patches/dont-build-new-manpages.diff
- − debian/patches/fix-linking.diff
- debian/patches/series
- + dirsrvtests/conftest.py
- dirsrvtests/tests/suites/import/regression_test.py
- dirsrvtests/tests/suites/memberof_plugin/regression_test.py
- dirsrvtests/tests/suites/password/regression_test.py
- dirsrvtests/tests/suites/replication/conflict_resolve_test.py
- dirsrvtests/tests/suites/replication/regression_test.py
- dirsrvtests/tests/suites/sasl/regression_test.py
- dirsrvtests/tests/tickets/ticket47560_test.py
- dirsrvtests/tests/tickets/ticket47573_test.py
- dirsrvtests/tests/tickets/ticket47640_test.py
- dirsrvtests/tests/tickets/ticket47653MMR_test.py
- dirsrvtests/tests/tickets/ticket47676_test.py
- dirsrvtests/tests/tickets/ticket47714_test.py
- dirsrvtests/tests/tickets/ticket47721_test.py
- dirsrvtests/tests/tickets/ticket47781_test.py
- dirsrvtests/tests/tickets/ticket47787_test.py
- dirsrvtests/tests/tickets/ticket47808_test.py
- dirsrvtests/tests/tickets/ticket47819_test.py
- dirsrvtests/tests/tickets/ticket47823_test.py
- dirsrvtests/tests/tickets/ticket47828_test.py
- dirsrvtests/tests/tickets/ticket47829_test.py

The diff was not included because it is too large.

View it on GitLab: https://salsa.debian.org/freeipa-team/389-ds-base/compare/092b62a4a681e6f24e4af55998e853e609798daf...222d75b7ec163f9dd633ea03df84004b0b0ad665

View it on GitLab: https://salsa.debian.org/freeipa-team/389-ds-base/compare/092b62a4a681e6f24e4af55998e853e609798daf...222d75b7ec163f9dd633ea03df84004b0b0ad665
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-freeipa-devel/attachments/20180731/5ae4ebc7/attachment-0001.html>

More information about the Pkg-freeipa-devel mailing list