[Pkg-freeipa-devel] [Git][freeipa-team/389-ds-base][upstream] 36 commits: Ticket 50898 - ldclt core dumped when run with -e genldif option

Timo Aaltonen gitlab at salsa.debian.org
Tue Mar 17 22:40:35 GMT 2020

Timo Aaltonen pushed to branch upstream at FreeIPA packaging / 389-ds-base

2f8fbe26 by Thierry Bordaz at 2020-02-14T15:44:38+01:00
Ticket 50898 - ldclt core dumped when run with -e genldif option

Bug Description:
	ldctl can generate ldif file. If the template file or option
	-e <objectclass> (person/InetOrgPerson/emailPerson) is missing,
	then the attribute value is not set.
	When dereferencing attribute.mod_values it crashes

Fix Description:
	Test that attribute.mod_values is set. If it is not (tha
	means the objectclass value was not provided) and return an error


Reviewed by: ?

Platforms tested: F29

Flag Day: no

Doc impact: no

- - - - -
1671dc03 by William Brown at 2020-02-19T09:06:04+10:00
Ticket 50900 - Fix cargo offline build

Bug Description: The cargo offline build was broken due to a missing
+ on the CPP flags to nsslapd, and because of a "space" between a
variable and the value in configure.ac.

Fix Description: Add the plus, remove the space.


Author: William Brown <william at blackhats.net.au>

Review by: mhonek (Thanks!)

- - - - -
0e6a04af by William Brown at 2020-02-19T09:08:05+10:00
Ticket 50618 - support cgroupv2

Bug Description: fedora 31 changes to cgroup v2 and I expect suse
to do the same soon. We should support this natively as part of
the memory limit detection.

Fix Description: Add support for cgroup v2


Author: William Brown <william at blackhats.net.au>

Review by: tbordaz (Thanks!)

- - - - -
d98699a0 by William Brown at 2020-02-19T09:14:11+10:00
Ticket 50786 - connection table freelist

Bug Description: The connection table previously to find an available
slot would iterate over the table attempting to find a free connection.
Under high congestion this yields poor performance as we may need to walk
O(n) slots to find the "one free", and the algorithm allowed the table to
be walked twice, making it potentially a O(2n) worst case. To make this
worse, the walking attempted to "trylock" - better than before (which
really locked!), but the trylock still issues atomics that are costly.

Fix Description: Implement a freelist - at start up all connections are
free, and as they are allocated they are removed from the list. As they
are disconnected they are re-added. This makes the lookup of a connection
O(1), removes spurious atomic and locking behaviour, and helps to minimise
time under the conntable lock. In some test cases this is shown to
improve server throughput by at minimum 6%


Author: William Brown <william at blackhats.net.au>

Review by: tbordaz, lkrispen

- - - - -
8b82fbd7 by Anuj Borah at 2020-02-19T14:03:57+05:30
Issue:50860 - Port Password Policy test cases from TET to python3 series of bugs

Bug Description: Port Password Policy test cases from TET to python3 series of bugs

Relates: https://pagure.io/389-ds-base/issue/50690

Author: aborah

Reviewed by: Viktor Ashirov

- - - - -
b7255ce8 by Anuj Borah at 2020-02-19T14:18:35+05:30
Issue:50860 - Port Password Policy test cases from TET to python3 bug624080

Bug Description: Port Password Policy test cases from TET to python3 bug624080

Relates: https://pagure.io/389-ds-base/issue/50690

Author: aborah

Reviewed by: Viktor Ashirov

- - - - -
031c0b9d by Matus Honek at 2020-02-19T13:47:27+01:00
Issue 49845 - Remove pkgconfig check for libasan

Bug Description:
A recent commit introduced a pkgconfig check for libasan. However, ASAN
buildtime whereabouts are provided within compiler itself, hence there is no
external libasan.pc file, only dynamic linking to libasan is necessary.

Fix Description:
Remove the superfluous check from configure.ac.

Relates https://pagure.io/389-ds-base/issue/49845

Author: Matus Honek <mhonek at redhat.com>

Review by: ???

- - - - -
3963b020 by Anuj Borah at 2020-02-24T15:42:00+05:30
Issue: 50686 - Port fractional replication test cases from TET to python3 final

Bug Description: Port fractional replication test cases from TET to python3 final

Fixes: https://pagure.io/389-ds-base/issue/50686

Author: aborah

Reviewed by: Viktor Ashirov

- - - - -
ea4fa549 by Mark Reynolds at 2020-02-25T14:05:03-05:00
Issue 50909 - nsDS5ReplicaId cant be set to the old value it had before

Bug Description:  We were not handling the process of changing the replica
                  type and id correctly.  For one, we were not correctly
                  handling a change to a hub/consumer, but it just happened
                  to work by accident in most cases.  In other caes you
                  could not change the rid more than once.

Fix Description:  Changed the value checking to allow ID changes to 65535
                  which allowed the type/id pointers to be set correctly.
                  Then the checking of the type & ID change combination had
                  to be revised.

                  Also, removed the option to get just set the RID or type
                  from dsconf.  Only replication promotion/demotion should
                  be touching these values.

relates: https://pagure.io/389-ds-base/issue/50909

Reviewed by: firstyear & tbordaz(Thanks!!)

- - - - -
60ae321e by Thierry Bordaz at 2020-02-26T10:58:19+01:00
Ticket 50889 - Extract pem files into a private namespace

Bug Description:
	since 1.3.5, certificates and keys are, by default, extracted under
	nsslapd-certdir directory. They are exracted in pem files.

	Some pem files (i.e. Serv-Cert-Key.pem) contain sensitive.
	The ticket is to extract them into a private namespace specific
	to the DS process.

Fix Description:
	If the process is started with systemd, it uses the PrivateTmp=on
	directive to create a private namespace.
	Then if such private namespace exists DS extracts the certificates/keys
	under it. Else it extracts the PEM files under usual nsslapd-certdir directory


Reviewed by: William Brown

Platforms tested: F30

Doc impact: yes

- - - - -
c8096427 by Thierry Bordaz at 2020-02-27T14:34:21+01:00
Ticket 50914 - No error returned when adding an entry matching filters for a non existing automember group

Bug Description:
	automember plugin adds matching members to a target group. If the target group
	does not exist a message is logged but with SLAPI_LOG_PLUGIN level.

Fix Description:
	Such situation (target group missing/deleted) is rare. It worths logging
	the message, that automember did not add a member, at SLAPI_LOG_INFO


Reviewed by: Mark Reynolds

Platforms tested: F30

Flag Day: no

Doc impact: no

- - - - -
7923698d by Mark Reynolds at 2020-02-27T09:16:26-05:00
Issue 50912 - RFE - add password policy attribute pwdReset

Description:  Implement the Password Policy attribute "pwdReset"
              as described at:


relates: https://pagure.io/389-ds-base/issue/50912

Reviewed by: firstyear & tbordaz(Thanks!)

- - - - -
75a51aa3 by Mark Reynolds at 2020-02-27T15:01:40-05:00
Issue 50872 - dsconf can't create GSSAPI replication agreements

Description:  An error in python syntax broke the check for bind
              method vs credentials.

              Bug was found and fixed by:  quentinmit (Thanks!)

relates: https://pagure.io/389-ds-base/issue/50872

Reviewed by:  mreynolds

- - - - -
5fb04713 by Mark Reynolds at 2020-02-28T08:06:17-05:00
Issue 50919 - Backend delete fails using dsconf

Description:  Fix typo in parser argument name

relates: https://pagure.io/389-ds-base/issue/50919

Reviewed by: mreynolds(one line commit rule)

- - - - -
d9e02aa6 by Simon Pichugin at 2020-02-29T03:57:45+01:00
Issue 50923 - Add test - dsctl fails to remove instances with dashes in the name

Description: Add a test which checks that an instance with a multiple dashes in
the name can be removed with 'dsctl --remove-all' command


Reviewed by: mreynolds (Thanks!)

- - - - -
245d8949 by Simon Pichugin at 2020-03-01T16:30:25+01:00
Issue 50920 - cl-dump exit code is 0 even if command fails with invalid arguments

Description of problem:
When running the cl-dump.pl script with invalid arguments, the exit code is always 0,
even if an error message is reported.

Fix Description:
Pass the return code to the end of the #main.
Change CI test accordingly.


Reviewed by: vashirov, mreynolds (Thanks!)

- - - - -
c013a028 by Simon Pichugin at 2020-03-02T19:34:21+01:00
Issue 50904 - Connect All React Components And Refactor the Main Navigation Tab Code

Description: Port the rest of ds.js and index.html code to React.
It includes instance navigation, creation, removal, and other dsctl tasks..
Fix https://pagure.io/389-ds-base/issue/49902


Reviewed by: mreynolds (Thanks!)

- - - - -
ae29367e by Simon Pichugin at 2020-03-04T14:41:58+01:00
Issue 50923 - Fix a test regression

Description: Fix a fixture naming issue.


Reviewed by: spichugi (one line commit rule)

- - - - -
6fd09c43 by Matus Honek at 2020-03-04T17:48:40+00:00
Issue 50758 - Only Recommend bash-completion, not Require

Bug Description:
bash-completion package is only useful for interactive use. E.g. in case of a
container deployment this is unnecessary.

Fix Description:
Change Requires to Recommends, which allows the dnf/yum ran with
install_weak_deps=False to not install this package; however, this option is by
default True, therefore a regular installation will install the package.

Relates https://pagure.io/389-ds-base/issue/50758

Author: Matus Honek <mhonek at redhat.com>

Review by: ???

- - - - -
742922be by Mark Reynolds at 2020-03-04T17:54:23+00:00
Issue 50928 - Unable to create a suffix with countryName

Bug Description:  It is not possible to create a suffix using 'c' as
                  the RDN attribute.

Fix Description:  Support 'c' when creating an instance or backend.

                  Also fixed a few python warnings.

reletes: https://pagure.io/389-ds-base/issue/50928

Reviewed by: ?

- - - - -
b43ec69c by Mark Reynolds at 2020-03-05T09:56:46-05:00
Issue 50926 - Remove dual spinner and other UI fixes

Description:  Removed unnecessary spinner when loading the backup table.
              Removed duplicate ID's from html
              Revised Create Instance modal to be easier to read
              Fixed typo in posix winsync fixup task help description
              Removed unused CSS styles
              Fixed plugin modal alignment issues
              Fixed typo in Enable Replication modal

relates: https://pagure.io/389-ds-base/issue/50926

Reviewed by: spichugi(Thanks!)

- - - - -
07a1080c by Mark Reynolds at 2020-03-05T10:03:17-05:00
Issue 50884 -  Health check tool DSEldif check fails

Bug Description:  dsconf healthcheck was failing depending how the
                  server id entered.  Using "slapd-INSTANCE" vs
                  "INSTANCE" produced different results.

Fix Description:  Normalize the instance name by always stripping
                  off "slapd-".  Also fixes similar issue when ~/.dsrc
                  is used.

                  Fixed the RI plugin lint report's inconsistent IDs

                  Fixed issue how flipend was being called for read-nsstate.

relates:  https://pagure.io/389-ds-base/issue/50884

Reviewed by: spichugi & firstyear (Thanks!)

Improve instance name handling robustness

- - - - -
a4340aaa by Thierry Bordaz at 2020-03-05T19:17:32+01:00
Ticket 50889 - fix compiler issues

- - - - -
3abe9228 by William Brown at 2020-03-06T12:24:27+10:00
Ticket 50618 - clean compiler warning and log level

Bug Description: Mark spotted a compiler error that I missed
while working on the cgroupv2 support

Fix Description: Fix the size of the constant to be a size_t
to fix a format warning, and change the loglevel of some messages
to be debug only.


Author: William Brown <william at blackhats.net.au>

Review by: mreynolds

- - - - -
bf8b4af6 by Sylvie Gouverneyre at 2020-03-09T14:32:49+00:00
Issue 49761 - Fix CI test suite issues

Bug Description:
tickets/ticket48229 test had failures in CI nightly runs

Fix Description:
tickets/ticket48226_test.py file moved and renamed to tests/suite/memory_leaks/MMR_double_free_test.py
Use of Valgrind removed, as support for Valgrind is broken in lib389 - Test run only with ASAN build
Replaced depracated _s functions by use of DSLdapObject

Relates https://pagure.io/389-ds-base/issue/49761

Author: sgouvern

Reviewed by: vashirov, spichugi

- - - - -
a66fe152 by Simon Pichugin at 2020-03-09T22:44:53+01:00
Issue 50499 - Fix npm audit issues

Updated npm packages and their dependencies:
* patternfly-react ^2.39.15

Relates: https://pagure.io/389-ds-base/issue/50499

- - - - -
439cd381 by William Brown at 2020-03-10T23:11:17+00:00
Ticket 50935 - systemd override in lib389 for dscontainer

Bug Description: A change to how with_systemd works has caused dscontainer
to no longer be able to setup instances, as with_systemd always evals to
true from defaults.inf as the marker file isn't written yet - post setup
this works.

Fix Description: To resolve this, a systemd override is required, that
allows the setup to ignore the systemd status as the external tools
"know better" than defaults inf up to that point. Post install, this
works as the marker would be inplace.


Author: William Brown <william at blackhats.net.au>

Review by: ???

- - - - -
ad8b9266 by William Brown at 2020-03-10T23:20:56+00:00
Ticket 50945 - givenname alias of gn from openldap

Bug Description: openldap supplies a different givenname
definition in schema.

Fix Description: Add gn as an alias to givenname


Author: William Brown <william at blackhats.net.au>

Review by: ???

- - - - -
df52b510 by Anuj Borah at 2020-03-12T18:34:40+05:30
Issue: 50860 - Port Password Policy test cases from TET to python3 pwp.sh

Bug Description: Port Password Policy test cases from TET to python3 pwp.sh

Relates: https://pagure.io/389-ds-base/issue/50690

Author: aborah

Reviewed by: Viktor Ashirov

- - - - -
a5e0fef7 by Mark Reynolds at 2020-03-12T10:08:32-04:00
Issue 50937 - Update CLI for new backend split configuration

Description:  In preparation for the move to LMDB the global database
              configuration has been split into two (or more) entries
              under cn=config.  This patch changes how the gets/sets
              work to make both of these entries appear as one
              configuration unit.  This is done by dynamically setting
              the backend configuration entry dn with what is set in

relates: https://pagure.io/389-ds-base/issue/50937

Reviewed by: spichugi, tbordaz, and firstyear(Thanks!!!)

Make changes via Simon's suggestions

Add firstyear's assert

- - - - -
c23b785b by Ludwig Krispenz at 2020-03-12T16:58:18+01:00
Ticket: 50755 - setting nsslapd-db-home-directory is overriding db_directory

    Bug: If nsslapd-db-home-directory is set  for new instances the database is
            placed below this directory, not only the db environment.

    Fix: Use the db dir when looking up the instance dir.
	 Make sure the log dir is below db dir and not home dir.
	 Make sure dse.ldif is written if upgrade to split config
		is done in a non-normal mode, eg import
	 Make sure the db directory is set to the list of parent
		directories for instances
	 If dblayer is closed only temporarily do not free directory settings
	 Adjust log level of some error messages

    Reviewed by: Mark, thanks

- - - - -
e74fae45 by William Brown at 2020-03-13T03:04:57+00:00
Ticket 50947 - change 00core.ldif objectClasses for openldap migration

Bug Description: Some values from rfc2256 are still present in openldap
despite being deprecated. We need to support these incase someone
has them, and to prevent the openldap_2_389 tool from attempting this

Fix Description: Add the missing rfc2256 attributes and values.


Author: William Brown <william at blackhats.net.au>

Review by: ???

- - - - -
3deb6ad7 by Mark Reynolds at 2020-03-13T19:36:17-04:00
Issue 50954 - Port buildnum.pl to python

Description:  Replace buildnum.pl with a python version so we can
              continue to remove perl dependencies.

relates: https://pagure.io/389-ds-base/issue/50954

Reviewed by: firstyear(Thanks!)

- - - - -
d0c37639 by Mark Reynolds at 2020-03-16T09:47:36-04:00
Issue 50955 - Fix memory leaks in chaining plugin

Bug Description:  There are many leaks caused by reinitializing a
                  chaining backend, and there are other leaks caused
                  with initialization allocations are not freed in
                  the plugin's close() function.

Fix Description:  Make sure we free pointers before blindly overwriting
                  them, and make sure we call chaining instance free
                  function for all chaining backends when stopping
                  the plugin.

relates: https://pagure.io/389-ds-base/issue/50955

Reviewed by: firstyear(Thanks!)

- - - - -
dae7cc93 by Mark Reynolds at 2020-03-16T10:37:33-04:00
Issue 50954 - Port buildnum.pl to python(part 2)

Description:  If the env var SOURCE_DATE_EPOCH is set we need
              convert it to an Integer when passing it to gmtime().

relates: https://pagure.io/389-ds-base/issue/50954

Reviewed by: mreynolds(one line commit rule)

- - - - -
3422d657 by Mark Reynolds at 2020-03-16T10:39:50-04:00
Bump version to

- - - - -

30 changed files:

- Makefile.am
- − buildnum.pl
- + buildnum.py
- configure.ac
- dirsrvtests/tests/suites/automember_plugin/automember_test.py
- dirsrvtests/tests/suites/basic/basic_test.py
- dirsrvtests/tests/suites/fractional/fractional_test.py
- + dirsrvtests/tests/suites/memory_leaks/MMR_double_free_test.py
- dirsrvtests/tests/suites/password/pwdPolicy_attribute_test.py
- dirsrvtests/tests/suites/password/pwdPolicy_warning_test.py
- + dirsrvtests/tests/suites/password/pwp_test.py
- + dirsrvtests/tests/suites/password/series_of_bugs_test.py
- dirsrvtests/tests/suites/replication/changelog_test.py
- dirsrvtests/tests/suites/replication/replica_config_test.py
- − dirsrvtests/tests/tickets/ticket48226_test.py
- ldap/admin/src/scripts/cl-dump.pl
- ldap/admin/src/scripts/dscreate.map.in
- ldap/schema/00core.ldif
- ldap/schema/02common.ldif
- ldap/servers/plugins/automember/automember.c
- ldap/servers/plugins/chainingdb/cb_close.c
- ldap/servers/plugins/chainingdb/cb_instance.c
- ldap/servers/plugins/replication/repl5_replica_config.c
- ldap/servers/slapd/back-ldbm/db-bdb/bdb_config.c
- ldap/servers/slapd/back-ldbm/db-bdb/bdb_layer.c
- ldap/servers/slapd/back-ldbm/db-bdb/bdb_layer.h
- ldap/servers/slapd/back-ldbm/dblayer.c
- ldap/servers/slapd/back-ldbm/ldbm_config.c
- ldap/servers/slapd/back-ldbm/misc.c

The diff was not included because it is too large.

View it on GitLab: https://salsa.debian.org/freeipa-team/389-ds-base/-/compare/776c6edf5dbaabccd6d2e12a4ebd6b39598dc142...3422d6574166e9e63d5ee0c21e61128bcb7113da

View it on GitLab: https://salsa.debian.org/freeipa-team/389-ds-base/-/compare/776c6edf5dbaabccd6d2e12a4ebd6b39598dc142...3422d6574166e9e63d5ee0c21e61128bcb7113da
You're receiving this email because of your account on salsa.debian.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-freeipa-devel/attachments/20200317/b201667b/attachment-0001.html>

More information about the Pkg-freeipa-devel mailing list