[Pkg-freeipa-devel] [Git][freeipa-team/freeipa-healthcheck][upstream] 32 commits: tests: Generate a proper `not-valid-after` field

Timo Aaltonen gitlab at salsa.debian.org
Thu Jan 28 11:31:17 GMT 2021



Timo Aaltonen pushed to branch upstream at FreeIPA packaging / freeipa-healthcheck


Commits:
90f0b7c1 by Stanislav Levin at 2020-11-06T16:20:10-05:00
tests: Generate a proper `not-valid-after` field

Some tests assume that the mocked certificate will be valid in N
days from now(). There was a hardcoded `not-valid-after` value
which pointed to 20201205214850Z. So, from Nov 06 2020 the assertion
20201205214850Z - now() < cert_expiration_days(30days) fails.

Fixes: https://github.com/freeipa/freeipa-healthcheck/issues/159
Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
d2f89f0e by Stanislav Levin at 2020-11-09T11:24:42-05:00
Pylint sources in CI

Fixes: https://github.com/freeipa/freeipa-healthcheck/issues/162
Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
6fe8efb4 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W1201(logging-not-lazy) and W1202(logging-format-interpolation)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
2d0a765d by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix R1725 (super-with-arguments)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
30b05495 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W0107(unnecessary-pass)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
af9a72a8 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W0201(attribute-defined-outside-init)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
af94da91 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W0235(useless-super-delegation)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
43ee548f by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W1619(old-division)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
7faa27b3 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix C0112(empty-docstring)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
78c285b5 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix R1710(inconsistent-return-statements)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
2f0be1c1 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W0611(unused-import)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
fcc1d7f8 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W0612(unused-variable)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
c7ca6bf9 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix R1721(unnecessary-comprehension)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
f986a8b6 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix R1724(no-else-continue)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
3d4d2e0f by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Ignore C0415(import-outside-toplevel)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
df3188e7 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W0222(signature-differs)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
d1ec3691 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W0221(arguments-differ)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
dcad3d85 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix E1111(assignment-from-no-return)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
6e0d5dc1 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix C0200(consider-using-enumerate)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
e700c6c0 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W0129(assert-on-string-literal)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
ebda4557 by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix W0104(pointless-statement)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
a5d5246b by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Fix R1705(no-else-return)

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
9d21775e by Stanislav Levin at 2020-11-09T11:24:42-05:00
pylint: Handle dnspython-2.0

Signed-off-by: Stanislav Levin <slev at altlinux.org>

- - - - -
75691d2a by Rob Crittenden at 2020-11-17T18:50:02-05:00
Use trust-find and trustdomain-find to identify all AD trusts

Not all AD domains are visible to trust-find. For each trust
iterate over trustdomain-find <domain> to find the complete
list of domains.

Signed-off-by: Rob Crittenden <rcritten at redhat.com>

- - - - -
5efeafa1 by Rob Crittenden at 2020-12-04T09:20:41-05:00
result names are not translated when reading input from json file

The strings were being retained so when processing the results to
determine the return code it was always a 1 because none of
the values were being translated. It was always comparing
the string like 'SUCCESS' to constants.SUCCESS which is 0.

https://bugzilla.redhat.com/show_bug.cgi?id=1866558

- - - - -
cdfe3b15 by Rob Crittenden at 2021-01-07T08:52:06-05:00
Use github actions for CI

Run the flake8 and pep8 tests in python 3.8 and 3.9

Run the pylint and pytests on Fedora 32 and 33

https://github.com/freeipa/freeipa-healthcheck/issues/168

Signed-off-by: Rob Crittenden <rcritten at redhat.com>

- - - - -
a7478528 by Rob Crittenden at 2021-01-07T08:52:06-05:00
Stop running CI in Travis

It looks like it is on its way out as a free-to-open-source
project.

https://github.com/freeipa/freeipa-healthcheck/issues/168

Signed-off-by: Rob Crittenden <rcritten at redhat.com>

- - - - -
64c71b50 by Rob Crittenden at 2021-01-12T22:41:17+01:00
Update DNS test to accomodate python-dns-2.1.0

This release included a lot of additional validation of
internal data types. Most of this data is faked in the
test and was not compatible with the additional data
verification.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1915256

Signed-off-by: Rob Crittenden <rcritten at redhat.com>

- - - - -
0905ecfc by Rob Crittenden at 2021-01-12T17:39:48-05:00
Remove deprecated options from setup.py

Remove ‘pytest-runner’ from your ‘setup_requires’, preferably
removing the setup_requires option.

Remove ‘pytest’ and any other testing requirements from
‘tests_require’, preferably removing the setup_requires option.

We already use tox for basic environment setup.

https://github.com/freeipa/freeipa-healthcheck/issues/161

Signed-off-by: Rob Crittenden <rcritten at redhat.com>

- - - - -
12b46ab2 by Rob Crittenden at 2021-01-12T17:39:48-05:00
Replace deprecated pep8 with pycodestyle

Leave pep8 as the env name for consistency.

Signed-off-by: Rob Crittenden <rcritten at redhat.com>

- - - - -
930ec5ff by Rob Crittenden at 2021-01-13T09:11:24+01:00
Allow a set of users/groups when specifying file owner/group

If there is a single owner or group then the old message will
be returned in order to retain backwards compatibility. Otherwise
a comma-seprated list of names for owner/group will be reported
on failure.

This was first seen as necessary on Fedora 33 where /etc/resolv.conf
could be owned by systemd-resolve or root due to the introduction
of a new resolver type.

https://github.com/freeipa/freeipa-healthcheck/issues/165
Signed-off-by: Rob Crittenden <rcritten at redhat.com>

- - - - -
43e9d7fc by Rob Crittenden at 2021-01-13T13:56:57-05:00
Become 0.8

- - - - -


30 changed files:

- + .github/workflows/pipelines.yml
- − .travis.yml
- + pylint_plugins.py
- + pylintrc
- setup.py
- src/ipaclustercheck/core/main.py
- src/ipaclustercheck/core/output.py
- src/ipaclustercheck/ipa/plugin.py
- src/ipaclustercheck/ipa/ruv.py
- src/ipahealthcheck/core/config.py
- src/ipahealthcheck/core/constants.py
- src/ipahealthcheck/core/core.py
- src/ipahealthcheck/core/files.py
- src/ipahealthcheck/core/main.py
- src/ipahealthcheck/core/output.py
- src/ipahealthcheck/core/plugin.py
- src/ipahealthcheck/core/service.py
- src/ipahealthcheck/dogtag/plugin.py
- src/ipahealthcheck/ds/plugin.py
- src/ipahealthcheck/ds/ruv.py
- src/ipahealthcheck/ipa/certs.py
- src/ipahealthcheck/ipa/files.py
- src/ipahealthcheck/ipa/idns.py
- src/ipahealthcheck/ipa/plugin.py
- src/ipahealthcheck/ipa/trust.py
- src/ipahealthcheck/meta/services.py
- src/ipahealthcheck/system/filesystemspace.py
- src/ipahealthcheck/system/plugin.py
- tests/base.py
- tests/mock_certmonger.py


The diff was not included because it is too large.


View it on GitLab: https://salsa.debian.org/freeipa-team/freeipa-healthcheck/-/compare/f97efcd1cf6c37fa50fd5f92a94d403cf29388eb...43e9d7fce407dbcd40ea78d4a77cd24c313837fb

-- 
View it on GitLab: https://salsa.debian.org/freeipa-team/freeipa-healthcheck/-/compare/f97efcd1cf6c37fa50fd5f92a94d403cf29388eb...43e9d7fce407dbcd40ea78d4a77cd24c313837fb
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-freeipa-devel/attachments/20210128/91432c9f/attachment-0001.html>


More information about the Pkg-freeipa-devel mailing list