[Pkg-freeipa-devel] Bug#1003750: certmonger: FTBFS with OpenSSL 3.0

[Steve Langasek]

Package: certmonger
Version: 0.79.14+git20211010-2
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu jammy ubuntu-patch

Hi Timo,

In Ubuntu, the certmonger package is failing to build from source due to
missing linkage against -lssl.  This is probably related to the fact that
Ubuntu has migrated to OpenSSL 3, though I don't understand exactly why
these particular failures are happening only with OpenSSL 3.

The attached patch fixes the build failures in Ubuntu and will probably be
needed in Debian in the near future.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru certmonger-0.79.14+git20211010/debian/patches/missing-library-linkage.patch certmonger-0.79.14+git20211010/debian/patches/missing-library-linkage.patch
--- certmonger-0.79.14+git20211010/debian/patches/missing-library-linkage.patch	1969-12-31 16:00:00.000000000 -0800
+++ certmonger-0.79.14+git20211010/debian/patches/missing-library-linkage.patch	2022-01-14 15:42:06.000000000 -0800
@@ -0,0 +1,54 @@
+Description: Add missing linkage to -lssl
+ These commands use libssl but fail to link to it.
+Author: Steve Langasek <steve.langasek at ubuntu.com>
+Last-Update: 2022-01-14
+Forwarded: no
+
+Index: certmonger-0.79.14+git20211010/src/Makefile.am
+===================================================================
+--- certmonger-0.79.14+git20211010.orig/src/Makefile.am
++++ certmonger-0.79.14+git20211010/src/Makefile.am
+@@ -182,11 +182,11 @@
+ certmonger_getcert_CFLAGS = $(getcert_CFLAGS)
+ certmonger_SOURCES = main.c env-system.c tm.c tm.h
+ certmonger_LDADD = libcm.a \
+-		   $(OPENSSL_LIBS) $(CERTMONGER_LIBS) $(KRB5_LIBS) $(IDN_LIBS) \
++		   $(OPENSSL_SSL_LIBS) $(CERTMONGER_LIBS) $(KRB5_LIBS) $(IDN_LIBS) \
+ 		   $(GMP_LIBS) $(UUID_LIBS) $(POPT_LIBS) $(LTLIBICONV) $(LDAP_LIBS)
+ certmonger_session_SOURCES = main.c env-session.c tm.c tm.h
+ certmonger_session_LDADD = libcm.a \
+-		   $(OPENSSL_LIBS) $(CERTMONGER_LIBS) $(KRB5_LIBS) $(IDN_LIBS) \
++		   $(OPENSSL_SSL_LIBS) $(CERTMONGER_LIBS) $(KRB5_LIBS) $(IDN_LIBS) \
+ 		   $(GMP_LIBS) $(UUID_LIBS) $(POPT_LIBS) $(LTLIBICONV) $(LDAP_LIBS)
+ noinst_PROGRAMS = tdbusm-check serial-check nl-check toklist
+ if WITH_XMLRPC
+@@ -264,14 +264,14 @@
+ 		pkcs7.c pkcs7.h store.h store-gen.c tm.c tm.h prefs.c prefs.h \
+ 		prefs-o.c prefs-o.h scep-o.c scep-o.h env.h env-system.c
+ scep_submit_LDADD = $(CURL_LIBS) $(XML_LIBS) $(NSS_LIBS) \
+-		      $(OPENSSL_LIBS) $(TALLOC_LIBS) \
++		      $(OPENSSL_SSL_LIBS) $(TALLOC_LIBS) \
+ 		      $(GMP_LIBS) $(UUID_LIBS) $(LTLIBICONV) $(POPT_LIBS)
+ local_submit_CFLAGS = $(AM_CFLAGS) $(NSS_CFLAGS)
+ local_submit_SOURCES = local.c env.h store.h store-gen.c submit-o.c submit-o.h \
+ 		       submit-u.c submit-u.h env-system.c env-shared.c log.c \
+ 		       log.h prefs.c prefs.h prefs-o.c prefs-o.h tm.c tm.h \
+ 		       util.c util.h util-o.c util-o.h pin.c pin.h
+-local_submit_LDADD = $(NSS_LIBS) $(OPENSSL_LIBS) $(TALLOC_LIBS) $(UUID_LIBS) \
++local_submit_LDADD = $(NSS_LIBS) $(OPENSSL_SSL_LIBS) $(TALLOC_LIBS) $(UUID_LIBS) \
+ 		     $(POPT_LIBS)
+ submit_d_CFLAGS = $(AM_CFLAGS) $(CURL_CFLAGS) $(XML_CFLAGS) -DCM_SUBMIT_D_MAIN
+ submit_d_SOURCES = submit-d.c submit-d.h submit-h.c submit-h.h \
+Index: certmonger-0.79.14+git20211010/tests/tools/Makefile.am
+===================================================================
+--- certmonger-0.79.14+git20211010.orig/tests/tools/Makefile.am
++++ certmonger-0.79.14+git20211010/tests/tools/Makefile.am
+@@ -2,7 +2,7 @@
+ 	    $(XMLRPC_CFLAGS) $(IDN_CFLAGS) $(UUID_CFLAGS) $(LDAP_CFLAGS) \
+ 	    $(POPT_CFLAGS) -I$(top_builddir)/src -I$(top_srcdir)/src
+ LDADD = libtools.a $(top_builddir)/src/libcm.a $(top_srcdir)/src/env-system.c \
+-	libtools.a $(OPENSSL_LIBS) $(CERTMONGER_LIBS) $(KRB5_LIBS) $(IDN_LIBS) \
++	libtools.a $(OPENSSL_SSL_LIBS) $(CERTMONGER_LIBS) $(KRB5_LIBS) $(IDN_LIBS) \
+ 	$(GMP_LIBS) $(UUID_LIBS) $(RESOLV_LIBS) $(POPT_LIBS) $(LTLIBICONV) \
+ 	$(LDAP_LIBS)
+ 
diff -Nru certmonger-0.79.14+git20211010/debian/patches/series certmonger-0.79.14+git20211010/debian/patches/series
--- certmonger-0.79.14+git20211010/debian/patches/series	2021-10-10 09:31:12.000000000 -0700
+++ certmonger-0.79.14+git20211010/debian/patches/series	2022-01-14 15:39:00.000000000 -0800
@@ -1,3 +1,4 @@
 fix-keythi-h-path.diff
 fix-service-environment.diff
 use-dbus-run-session.diff
+missing-library-linkage.patch