[Pkg-freeipa-devel] [Git][freeipa-team/slapi-nis][master] 21 commits: Return early if ret allocation has failed
Timo Aaltonen (@tjaalton)
gitlab at salsa.debian.org
Mon Nov 21 09:40:25 GMT 2022
Timo Aaltonen pushed to branch master at FreeIPA packaging / slapi-nis
Commits:
2ef907e9 by Alexander Bokovoy at 2021-05-24T09:11:07+03:00
Return early if ret allocation has failed
Fixes reports from a GCC analyzer
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
0f700cf7 by Alexander Bokovoy at 2021-06-16T11:08:21+03:00
back-sch-nss: only loop if asked to try again
slapi-nis uses sss-idmap library to discover user group membership. Its
sss_nss_getgrouplist_timeout() function can return timeout errors as
well which might cause a busy looping. sss_nss_getgrouplist_timeout()
will return ERANGE which is translated by slapi-nis to NSS_STATUS_TRYAGAIN.
Fixes: rhbz#1967179
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
faa4dafc by Alexander Bokovoy at 2021-06-16T11:11:05+03:00
back-sch-nss: use tabs instead of spaces
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
d18b1d10 by Alexander Bokovoy at 2021-07-01T12:13:12+03:00
back-sch: reuse backend_should_descend
When backend_search_find_set_dn_cb() is called, use the same logic as in
other callbacks -- identify whether we should descend into the group by
using backend_should_descend().
The issue was introduced in 2015 with ID Views support but was masked
until 61ea8f6a104da25329e301a8f56944f860de8177 as we always felt through
to the full scan of the groups anyway. with the latter change the
fell-through part was removed.
Resolves: rhbz#1958909
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
Signed-off-by: Thierry Bordaz <tbordaz at redhat.com>
- - - - -
02a9cb46 by Viktor Ashirov at 2021-08-10T10:14:53+02:00
back-sch: fix memory leak in backend_search_cb()
Resolves: rhbz#1967906
Signed-off-by: Viktor Ashirov <vashirov at redhat.com>
- - - - -
610cf4ce by Alexander Bokovoy at 2022-02-01T08:28:18+02:00
Update OpenLDAP detection code to deal with libldap_r removal in 2.6
Resolves: rhbz#2032691
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
c0a34d90 by Alexander Bokovoy at 2022-02-01T09:43:57+02:00
azure tests: Gathering memory statistics may fail in container
Mask failures if containerized environment does not have cgroup memory
files' access.
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
f5923ba3 by Alexander Bokovoy at 2022-02-01T10:35:42+02:00
azure tests: more ingores for memory statistics failures in containers
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
d966e476 by Thierry Bordaz at 2022-07-13T11:53:27+02:00
Issue 45 - RFE - Allow to rebuild the compat tree
Description:
For different reasons, the compat tree maps might get corrupted and some entries would be missing.
This RFE provides a way to rebuild online the whole compat tree on demand via a DS task.
Fix:
It registers tasks callbacks under cn=chema compatibility
refresh task,cn=tasks,cn=config. The task meta data contains
the filter (SCH_CONTAINER_CONFIGURATION_FILTER) and the
plugin_state (not retrievable via pblock).
The rebuild task (backend_shr_refresh_thread) is shared
as it can be used by NIS or Schema Compat.
The rebuild task disable access to the maps, free and
reinit them. Then rebuild them using the already implemented
backend_shr_data_initialize_thread.
Review: Alexander Bokovoy (thanks !)
- - - - -
e61553b0 by Alexander Bokovoy at 2022-08-15T12:50:48+03:00
Fix compile issues with PR45
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
2b555e2c by Alexander Bokovoy at 2022-08-15T13:20:53+03:00
Remove typo
typo in '%else:' was introduced in 4110b730a0c26f8a66a1d826bc96c26ce48af5d3
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
8f756e72 by Alexander Bokovoy at 2022-08-19T17:31:34+03:00
schema-compat: fix ID view lookups
When ID view is detected, it needs to be preserved until the end of search
processing. We iterate over groups and need to know about ID views when
collecting the matched entries.
When ID view is detected, we restart map search from the top level
(cn=compat,$SUFFIX).
For the case of top level (cn=compat,$SUFFIX) match, a subtree which
activated ID view usage was not actually going into individual groups to
match overridden filter against the entries in those groups. This was
due to premature comparison with the group DN as
backend_should_descend() would have always matched it and caused to
short-circuit processing with empty entries.
Finally, since all memory allocations during the search must be present
until the search is processed, do not short-circuit 'return 0' from
within. Use a general cleanup code instead.
Resolves: rhbz#1984010
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
b199598c by Alexander Bokovoy at 2022-08-19T17:31:34+03:00
Fix debug message typo: dot after line return
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
d3d8f715 by Alexander Bokovoy at 2022-08-20T08:55:05+03:00
Fix base scope searches
Base scope searches were processed incorrectly after earlier changes to
use backend_should_descend().
Resolves: rhbz#2000060
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
99196df8 by Alexander Bokovoy at 2022-08-20T09:32:02+03:00
Rise max datagram record size to 8KB
By default, max datagram record size in NIS protocol is limited to
YPMAXRECORD which is 1024 bytes. However, in 2013 glibc allowed to
change this value up to 16MB in runtime and FreeBSD followed the trend
in 2019 (https://reviews.freebsd.org/D20900). These changes allow NIS
servers to send buffers of any sizes up to 16MB if clients allocate
their memory in heap.
There is still one place where YPMAXRECORD is used for a stack
allocation in glibc: xdr_ypall() function. Access to individual
keys/values can use up to 16MB of memory but through xdr_ypall() the
buffers to store individual record key/value pairs is limited to
YPMAXRECORD size on stack. It means if a server has sent a larger
key/value pair, a client stack could still be smashed.
For slapi-nis, there is no easy way of knowing in advance the size of
the record to be sent. Large groups can easily get beyond default 1024
bytes. There is a NIS plugin setting (nis-max-dgram-size) that can be
used to adjust configuration.
Let's use 8KB as a default for now. NIS support is going to be phased
out, Fedora and RHEL 9 already removed NIS client side code.
Resolves: rhbz#1784172
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
bc993434 by Alexander Bokovoy at 2022-08-20T09:35:07+03:00
Update COPYING to match 389-ds use of GPLv3+
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
2a8e108a by Alexander Bokovoy at 2022-08-20T09:40:40+03:00
Release 0.60.0
Signed-off-by: Alexander Bokovoy <abokovoy at redhat.com>
- - - - -
bf9b2f45 by Timo Aaltonen at 2022-11-21T11:16:40+02:00
Merge branch 'upstream'
- - - - -
57d69159 by Timo Aaltonen at 2022-11-21T11:17:00+02:00
version bump
- - - - -
c6fe1306 by Timo Aaltonen at 2022-11-21T11:38:19+02:00
source: Extend diff-ignore.
- - - - -
45c264bd by Timo Aaltonen at 2022-11-21T11:38:41+02:00
releasing package slapi-nis version 0.60.0-1
- - - - -
19 changed files:
- COPYING
- + LICENSE
- configure.ac
- debian/changelog
- debian/source/options
- slapi-nis.spec
- src/back-nis.c
- src/back-sch-idview.c
- src/back-sch-nss.c
- src/back-sch.c
- src/back-shr.c
- src/back-shr.h
- src/backend.h
- src/plug-nis.c
- src/plug-sch.c
- src/plugin.h
- tests/azure/scripts/azure-run-base-tests.sh
- tests/azure/scripts/azure-run-integration-tests.sh
- tests/azure/templates/test-jobs.yml
Changes:
=====================================
COPYING
=====================================
@@ -1,15 +1,12 @@
-This Program is free software; you can redistribute it and/or modify it under
-the terms of the GNU General Public License as published by the Free Software
-Foundation; version 2 of the License.
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
-This Program is distributed in the hope that it will be useful, but WITHOUT
-ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
-FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU General Public License for more details.
-You should have received a copy of the GNU General Public License along with
-this Program; if not, write to
-
- Free Software Foundation
- 51 Franklin Street, Fifth Floor
- Boston, MA 02110-1301
- USA
+You should have received a copy of the GNU General Public License
+along with this program. If not, see <http://www.gnu.org/licenses/>.
=====================================
LICENSE
=====================================
@@ -0,0 +1,674 @@
+ GNU GENERAL PUBLIC LICENSE
+ Version 3, 29 June 2007
+
+ Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+ Preamble
+
+ The GNU General Public License is a free, copyleft license for
+software and other kinds of works.
+
+ The licenses for most software and other practical works are designed
+to take away your freedom to share and change the works. By contrast,
+the GNU General Public License is intended to guarantee your freedom to
+share and change all versions of a program--to make sure it remains free
+software for all its users. We, the Free Software Foundation, use the
+GNU General Public License for most of our software; it applies also to
+any other work released this way by its authors. You can apply it to
+your programs, too.
+
+ When we speak of free software, we are referring to freedom, not
+price. Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+them if you wish), that you receive source code or can get it if you
+want it, that you can change the software or use pieces of it in new
+free programs, and that you know you can do these things.
+
+ To protect your rights, we need to prevent others from denying you
+these rights or asking you to surrender the rights. Therefore, you have
+certain responsibilities if you distribute copies of the software, or if
+you modify it: responsibilities to respect the freedom of others.
+
+ For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must pass on to the recipients the same
+freedoms that you received. You must make sure that they, too, receive
+or can get the source code. And you must show them these terms so they
+know their rights.
+
+ Developers that use the GNU GPL protect your rights with two steps:
+(1) assert copyright on the software, and (2) offer you this License
+giving you legal permission to copy, distribute and/or modify it.
+
+ For the developers' and authors' protection, the GPL clearly explains
+that there is no warranty for this free software. For both users' and
+authors' sake, the GPL requires that modified versions be marked as
+changed, so that their problems will not be attributed erroneously to
+authors of previous versions.
+
+ Some devices are designed to deny users access to install or run
+modified versions of the software inside them, although the manufacturer
+can do so. This is fundamentally incompatible with the aim of
+protecting users' freedom to change the software. The systematic
+pattern of such abuse occurs in the area of products for individuals to
+use, which is precisely where it is most unacceptable. Therefore, we
+have designed this version of the GPL to prohibit the practice for those
+products. If such problems arise substantially in other domains, we
+stand ready to extend this provision to those domains in future versions
+of the GPL, as needed to protect the freedom of users.
+
+ Finally, every program is threatened constantly by software patents.
+States should not allow patents to restrict development and use of
+software on general-purpose computers, but in those that do, we wish to
+avoid the special danger that patents applied to a free program could
+make it effectively proprietary. To prevent this, the GPL assures that
+patents cannot be used to render the program non-free.
+
+ The precise terms and conditions for copying, distribution and
+modification follow.
+
+ TERMS AND CONDITIONS
+
+ 0. Definitions.
+
+ "This License" refers to version 3 of the GNU General Public License.
+
+ "Copyright" also means copyright-like laws that apply to other kinds of
+works, such as semiconductor masks.
+
+ "The Program" refers to any copyrightable work licensed under this
+License. Each licensee is addressed as "you". "Licensees" and
+"recipients" may be individuals or organizations.
+
+ To "modify" a work means to copy from or adapt all or part of the work
+in a fashion requiring copyright permission, other than the making of an
+exact copy. The resulting work is called a "modified version" of the
+earlier work or a work "based on" the earlier work.
+
+ A "covered work" means either the unmodified Program or a work based
+on the Program.
+
+ To "propagate" a work means to do anything with it that, without
+permission, would make you directly or secondarily liable for
+infringement under applicable copyright law, except executing it on a
+computer or modifying a private copy. Propagation includes copying,
+distribution (with or without modification), making available to the
+public, and in some countries other activities as well.
+
+ To "convey" a work means any kind of propagation that enables other
+parties to make or receive copies. Mere interaction with a user through
+a computer network, with no transfer of a copy, is not conveying.
+
+ An interactive user interface displays "Appropriate Legal Notices"
+to the extent that it includes a convenient and prominently visible
+feature that (1) displays an appropriate copyright notice, and (2)
+tells the user that there is no warranty for the work (except to the
+extent that warranties are provided), that licensees may convey the
+work under this License, and how to view a copy of this License. If
+the interface presents a list of user commands or options, such as a
+menu, a prominent item in the list meets this criterion.
+
+ 1. Source Code.
+
+ The "source code" for a work means the preferred form of the work
+for making modifications to it. "Object code" means any non-source
+form of a work.
+
+ A "Standard Interface" means an interface that either is an official
+standard defined by a recognized standards body, or, in the case of
+interfaces specified for a particular programming language, one that
+is widely used among developers working in that language.
+
+ The "System Libraries" of an executable work include anything, other
+than the work as a whole, that (a) is included in the normal form of
+packaging a Major Component, but which is not part of that Major
+Component, and (b) serves only to enable use of the work with that
+Major Component, or to implement a Standard Interface for which an
+implementation is available to the public in source code form. A
+"Major Component", in this context, means a major essential component
+(kernel, window system, and so on) of the specific operating system
+(if any) on which the executable work runs, or a compiler used to
+produce the work, or an object code interpreter used to run it.
+
+ The "Corresponding Source" for a work in object code form means all
+the source code needed to generate, install, and (for an executable
+work) run the object code and to modify the work, including scripts to
+control those activities. However, it does not include the work's
+System Libraries, or general-purpose tools or generally available free
+programs which are used unmodified in performing those activities but
+which are not part of the work. For example, Corresponding Source
+includes interface definition files associated with source files for
+the work, and the source code for shared libraries and dynamically
+linked subprograms that the work is specifically designed to require,
+such as by intimate data communication or control flow between those
+subprograms and other parts of the work.
+
+ The Corresponding Source need not include anything that users
+can regenerate automatically from other parts of the Corresponding
+Source.
+
+ The Corresponding Source for a work in source code form is that
+same work.
+
+ 2. Basic Permissions.
+
+ All rights granted under this License are granted for the term of
+copyright on the Program, and are irrevocable provided the stated
+conditions are met. This License explicitly affirms your unlimited
+permission to run the unmodified Program. The output from running a
+covered work is covered by this License only if the output, given its
+content, constitutes a covered work. This License acknowledges your
+rights of fair use or other equivalent, as provided by copyright law.
+
+ You may make, run and propagate covered works that you do not
+convey, without conditions so long as your license otherwise remains
+in force. You may convey covered works to others for the sole purpose
+of having them make modifications exclusively for you, or provide you
+with facilities for running those works, provided that you comply with
+the terms of this License in conveying all material for which you do
+not control copyright. Those thus making or running the covered works
+for you must do so exclusively on your behalf, under your direction
+and control, on terms that prohibit them from making any copies of
+your copyrighted material outside their relationship with you.
+
+ Conveying under any other circumstances is permitted solely under
+the conditions stated below. Sublicensing is not allowed; section 10
+makes it unnecessary.
+
+ 3. Protecting Users' Legal Rights From Anti-Circumvention Law.
+
+ No covered work shall be deemed part of an effective technological
+measure under any applicable law fulfilling obligations under article
+11 of the WIPO copyright treaty adopted on 20 December 1996, or
+similar laws prohibiting or restricting circumvention of such
+measures.
+
+ When you convey a covered work, you waive any legal power to forbid
+circumvention of technological measures to the extent such circumvention
+is effected by exercising rights under this License with respect to
+the covered work, and you disclaim any intention to limit operation or
+modification of the work as a means of enforcing, against the work's
+users, your or third parties' legal rights to forbid circumvention of
+technological measures.
+
+ 4. Conveying Verbatim Copies.
+
+ You may convey verbatim copies of the Program's source code as you
+receive it, in any medium, provided that you conspicuously and
+appropriately publish on each copy an appropriate copyright notice;
+keep intact all notices stating that this License and any
+non-permissive terms added in accord with section 7 apply to the code;
+keep intact all notices of the absence of any warranty; and give all
+recipients a copy of this License along with the Program.
+
+ You may charge any price or no price for each copy that you convey,
+and you may offer support or warranty protection for a fee.
+
+ 5. Conveying Modified Source Versions.
+
+ You may convey a work based on the Program, or the modifications to
+produce it from the Program, in the form of source code under the
+terms of section 4, provided that you also meet all of these conditions:
+
+ a) The work must carry prominent notices stating that you modified
+ it, and giving a relevant date.
+
+ b) The work must carry prominent notices stating that it is
+ released under this License and any conditions added under section
+ 7. This requirement modifies the requirement in section 4 to
+ "keep intact all notices".
+
+ c) You must license the entire work, as a whole, under this
+ License to anyone who comes into possession of a copy. This
+ License will therefore apply, along with any applicable section 7
+ additional terms, to the whole of the work, and all its parts,
+ regardless of how they are packaged. This License gives no
+ permission to license the work in any other way, but it does not
+ invalidate such permission if you have separately received it.
+
+ d) If the work has interactive user interfaces, each must display
+ Appropriate Legal Notices; however, if the Program has interactive
+ interfaces that do not display Appropriate Legal Notices, your
+ work need not make them do so.
+
+ A compilation of a covered work with other separate and independent
+works, which are not by their nature extensions of the covered work,
+and which are not combined with it such as to form a larger program,
+in or on a volume of a storage or distribution medium, is called an
+"aggregate" if the compilation and its resulting copyright are not
+used to limit the access or legal rights of the compilation's users
+beyond what the individual works permit. Inclusion of a covered work
+in an aggregate does not cause this License to apply to the other
+parts of the aggregate.
+
+ 6. Conveying Non-Source Forms.
+
+ You may convey a covered work in object code form under the terms
+of sections 4 and 5, provided that you also convey the
+machine-readable Corresponding Source under the terms of this License,
+in one of these ways:
+
+ a) Convey the object code in, or embodied in, a physical product
+ (including a physical distribution medium), accompanied by the
+ Corresponding Source fixed on a durable physical medium
+ customarily used for software interchange.
+
+ b) Convey the object code in, or embodied in, a physical product
+ (including a physical distribution medium), accompanied by a
+ written offer, valid for at least three years and valid for as
+ long as you offer spare parts or customer support for that product
+ model, to give anyone who possesses the object code either (1) a
+ copy of the Corresponding Source for all the software in the
+ product that is covered by this License, on a durable physical
+ medium customarily used for software interchange, for a price no
+ more than your reasonable cost of physically performing this
+ conveying of source, or (2) access to copy the
+ Corresponding Source from a network server at no charge.
+
+ c) Convey individual copies of the object code with a copy of the
+ written offer to provide the Corresponding Source. This
+ alternative is allowed only occasionally and noncommercially, and
+ only if you received the object code with such an offer, in accord
+ with subsection 6b.
+
+ d) Convey the object code by offering access from a designated
+ place (gratis or for a charge), and offer equivalent access to the
+ Corresponding Source in the same way through the same place at no
+ further charge. You need not require recipients to copy the
+ Corresponding Source along with the object code. If the place to
+ copy the object code is a network server, the Corresponding Source
+ may be on a different server (operated by you or a third party)
+ that supports equivalent copying facilities, provided you maintain
+ clear directions next to the object code saying where to find the
+ Corresponding Source. Regardless of what server hosts the
+ Corresponding Source, you remain obligated to ensure that it is
+ available for as long as needed to satisfy these requirements.
+
+ e) Convey the object code using peer-to-peer transmission, provided
+ you inform other peers where the object code and Corresponding
+ Source of the work are being offered to the general public at no
+ charge under subsection 6d.
+
+ A separable portion of the object code, whose source code is excluded
+from the Corresponding Source as a System Library, need not be
+included in conveying the object code work.
+
+ A "User Product" is either (1) a "consumer product", which means any
+tangible personal property which is normally used for personal, family,
+or household purposes, or (2) anything designed or sold for incorporation
+into a dwelling. In determining whether a product is a consumer product,
+doubtful cases shall be resolved in favor of coverage. For a particular
+product received by a particular user, "normally used" refers to a
+typical or common use of that class of product, regardless of the status
+of the particular user or of the way in which the particular user
+actually uses, or expects or is expected to use, the product. A product
+is a consumer product regardless of whether the product has substantial
+commercial, industrial or non-consumer uses, unless such uses represent
+the only significant mode of use of the product.
+
+ "Installation Information" for a User Product means any methods,
+procedures, authorization keys, or other information required to install
+and execute modified versions of a covered work in that User Product from
+a modified version of its Corresponding Source. The information must
+suffice to ensure that the continued functioning of the modified object
+code is in no case prevented or interfered with solely because
+modification has been made.
+
+ If you convey an object code work under this section in, or with, or
+specifically for use in, a User Product, and the conveying occurs as
+part of a transaction in which the right of possession and use of the
+User Product is transferred to the recipient in perpetuity or for a
+fixed term (regardless of how the transaction is characterized), the
+Corresponding Source conveyed under this section must be accompanied
+by the Installation Information. But this requirement does not apply
+if neither you nor any third party retains the ability to install
+modified object code on the User Product (for example, the work has
+been installed in ROM).
+
+ The requirement to provide Installation Information does not include a
+requirement to continue to provide support service, warranty, or updates
+for a work that has been modified or installed by the recipient, or for
+the User Product in which it has been modified or installed. Access to a
+network may be denied when the modification itself materially and
+adversely affects the operation of the network or violates the rules and
+protocols for communication across the network.
+
+ Corresponding Source conveyed, and Installation Information provided,
+in accord with this section must be in a format that is publicly
+documented (and with an implementation available to the public in
+source code form), and must require no special password or key for
+unpacking, reading or copying.
+
+ 7. Additional Terms.
+
+ "Additional permissions" are terms that supplement the terms of this
+License by making exceptions from one or more of its conditions.
+Additional permissions that are applicable to the entire Program shall
+be treated as though they were included in this License, to the extent
+that they are valid under applicable law. If additional permissions
+apply only to part of the Program, that part may be used separately
+under those permissions, but the entire Program remains governed by
+this License without regard to the additional permissions.
+
+ When you convey a copy of a covered work, you may at your option
+remove any additional permissions from that copy, or from any part of
+it. (Additional permissions may be written to require their own
+removal in certain cases when you modify the work.) You may place
+additional permissions on material, added by you to a covered work,
+for which you have or can give appropriate copyright permission.
+
+ Notwithstanding any other provision of this License, for material you
+add to a covered work, you may (if authorized by the copyright holders of
+that material) supplement the terms of this License with terms:
+
+ a) Disclaiming warranty or limiting liability differently from the
+ terms of sections 15 and 16 of this License; or
+
+ b) Requiring preservation of specified reasonable legal notices or
+ author attributions in that material or in the Appropriate Legal
+ Notices displayed by works containing it; or
+
+ c) Prohibiting misrepresentation of the origin of that material, or
+ requiring that modified versions of such material be marked in
+ reasonable ways as different from the original version; or
+
+ d) Limiting the use for publicity purposes of names of licensors or
+ authors of the material; or
+
+ e) Declining to grant rights under trademark law for use of some
+ trade names, trademarks, or service marks; or
+
+ f) Requiring indemnification of licensors and authors of that
+ material by anyone who conveys the material (or modified versions of
+ it) with contractual assumptions of liability to the recipient, for
+ any liability that these contractual assumptions directly impose on
+ those licensors and authors.
+
+ All other non-permissive additional terms are considered "further
+restrictions" within the meaning of section 10. If the Program as you
+received it, or any part of it, contains a notice stating that it is
+governed by this License along with a term that is a further
+restriction, you may remove that term. If a license document contains
+a further restriction but permits relicensing or conveying under this
+License, you may add to a covered work material governed by the terms
+of that license document, provided that the further restriction does
+not survive such relicensing or conveying.
+
+ If you add terms to a covered work in accord with this section, you
+must place, in the relevant source files, a statement of the
+additional terms that apply to those files, or a notice indicating
+where to find the applicable terms.
+
+ Additional terms, permissive or non-permissive, may be stated in the
+form of a separately written license, or stated as exceptions;
+the above requirements apply either way.
+
+ 8. Termination.
+
+ You may not propagate or modify a covered work except as expressly
+provided under this License. Any attempt otherwise to propagate or
+modify it is void, and will automatically terminate your rights under
+this License (including any patent licenses granted under the third
+paragraph of section 11).
+
+ However, if you cease all violation of this License, then your
+license from a particular copyright holder is reinstated (a)
+provisionally, unless and until the copyright holder explicitly and
+finally terminates your license, and (b) permanently, if the copyright
+holder fails to notify you of the violation by some reasonable means
+prior to 60 days after the cessation.
+
+ Moreover, your license from a particular copyright holder is
+reinstated permanently if the copyright holder notifies you of the
+violation by some reasonable means, this is the first time you have
+received notice of violation of this License (for any work) from that
+copyright holder, and you cure the violation prior to 30 days after
+your receipt of the notice.
+
+ Termination of your rights under this section does not terminate the
+licenses of parties who have received copies or rights from you under
+this License. If your rights have been terminated and not permanently
+reinstated, you do not qualify to receive new licenses for the same
+material under section 10.
+
+ 9. Acceptance Not Required for Having Copies.
+
+ You are not required to accept this License in order to receive or
+run a copy of the Program. Ancillary propagation of a covered work
+occurring solely as a consequence of using peer-to-peer transmission
+to receive a copy likewise does not require acceptance. However,
+nothing other than this License grants you permission to propagate or
+modify any covered work. These actions infringe copyright if you do
+not accept this License. Therefore, by modifying or propagating a
+covered work, you indicate your acceptance of this License to do so.
+
+ 10. Automatic Licensing of Downstream Recipients.
+
+ Each time you convey a covered work, the recipient automatically
+receives a license from the original licensors, to run, modify and
+propagate that work, subject to this License. You are not responsible
+for enforcing compliance by third parties with this License.
+
+ An "entity transaction" is a transaction transferring control of an
+organization, or substantially all assets of one, or subdividing an
+organization, or merging organizations. If propagation of a covered
+work results from an entity transaction, each party to that
+transaction who receives a copy of the work also receives whatever
+licenses to the work the party's predecessor in interest had or could
+give under the previous paragraph, plus a right to possession of the
+Corresponding Source of the work from the predecessor in interest, if
+the predecessor has it or can get it with reasonable efforts.
+
+ You may not impose any further restrictions on the exercise of the
+rights granted or affirmed under this License. For example, you may
+not impose a license fee, royalty, or other charge for exercise of
+rights granted under this License, and you may not initiate litigation
+(including a cross-claim or counterclaim in a lawsuit) alleging that
+any patent claim is infringed by making, using, selling, offering for
+sale, or importing the Program or any portion of it.
+
+ 11. Patents.
+
+ A "contributor" is a copyright holder who authorizes use under this
+License of the Program or a work on which the Program is based. The
+work thus licensed is called the contributor's "contributor version".
+
+ A contributor's "essential patent claims" are all patent claims
+owned or controlled by the contributor, whether already acquired or
+hereafter acquired, that would be infringed by some manner, permitted
+by this License, of making, using, or selling its contributor version,
+but do not include claims that would be infringed only as a
+consequence of further modification of the contributor version. For
+purposes of this definition, "control" includes the right to grant
+patent sublicenses in a manner consistent with the requirements of
+this License.
+
+ Each contributor grants you a non-exclusive, worldwide, royalty-free
+patent license under the contributor's essential patent claims, to
+make, use, sell, offer for sale, import and otherwise run, modify and
+propagate the contents of its contributor version.
+
+ In the following three paragraphs, a "patent license" is any express
+agreement or commitment, however denominated, not to enforce a patent
+(such as an express permission to practice a patent or covenant not to
+sue for patent infringement). To "grant" such a patent license to a
+party means to make such an agreement or commitment not to enforce a
+patent against the party.
+
+ If you convey a covered work, knowingly relying on a patent license,
+and the Corresponding Source of the work is not available for anyone
+to copy, free of charge and under the terms of this License, through a
+publicly available network server or other readily accessible means,
+then you must either (1) cause the Corresponding Source to be so
+available, or (2) arrange to deprive yourself of the benefit of the
+patent license for this particular work, or (3) arrange, in a manner
+consistent with the requirements of this License, to extend the patent
+license to downstream recipients. "Knowingly relying" means you have
+actual knowledge that, but for the patent license, your conveying the
+covered work in a country, or your recipient's use of the covered work
+in a country, would infringe one or more identifiable patents in that
+country that you have reason to believe are valid.
+
+ If, pursuant to or in connection with a single transaction or
+arrangement, you convey, or propagate by procuring conveyance of, a
+covered work, and grant a patent license to some of the parties
+receiving the covered work authorizing them to use, propagate, modify
+or convey a specific copy of the covered work, then the patent license
+you grant is automatically extended to all recipients of the covered
+work and works based on it.
+
+ A patent license is "discriminatory" if it does not include within
+the scope of its coverage, prohibits the exercise of, or is
+conditioned on the non-exercise of one or more of the rights that are
+specifically granted under this License. You may not convey a covered
+work if you are a party to an arrangement with a third party that is
+in the business of distributing software, under which you make payment
+to the third party based on the extent of your activity of conveying
+the work, and under which the third party grants, to any of the
+parties who would receive the covered work from you, a discriminatory
+patent license (a) in connection with copies of the covered work
+conveyed by you (or copies made from those copies), or (b) primarily
+for and in connection with specific products or compilations that
+contain the covered work, unless you entered into that arrangement,
+or that patent license was granted, prior to 28 March 2007.
+
+ Nothing in this License shall be construed as excluding or limiting
+any implied license or other defenses to infringement that may
+otherwise be available to you under applicable patent law.
+
+ 12. No Surrender of Others' Freedom.
+
+ If conditions are imposed on you (whether by court order, agreement or
+otherwise) that contradict the conditions of this License, they do not
+excuse you from the conditions of this License. If you cannot convey a
+covered work so as to satisfy simultaneously your obligations under this
+License and any other pertinent obligations, then as a consequence you may
+not convey it at all. For example, if you agree to terms that obligate you
+to collect a royalty for further conveying from those to whom you convey
+the Program, the only way you could satisfy both those terms and this
+License would be to refrain entirely from conveying the Program.
+
+ 13. Use with the GNU Affero General Public License.
+
+ Notwithstanding any other provision of this License, you have
+permission to link or combine any covered work with a work licensed
+under version 3 of the GNU Affero General Public License into a single
+combined work, and to convey the resulting work. The terms of this
+License will continue to apply to the part which is the covered work,
+but the special requirements of the GNU Affero General Public License,
+section 13, concerning interaction through a network will apply to the
+combination as such.
+
+ 14. Revised Versions of this License.
+
+ The Free Software Foundation may publish revised and/or new versions of
+the GNU General Public License from time to time. Such new versions will
+be similar in spirit to the present version, but may differ in detail to
+address new problems or concerns.
+
+ Each version is given a distinguishing version number. If the
+Program specifies that a certain numbered version of the GNU General
+Public License "or any later version" applies to it, you have the
+option of following the terms and conditions either of that numbered
+version or of any later version published by the Free Software
+Foundation. If the Program does not specify a version number of the
+GNU General Public License, you may choose any version ever published
+by the Free Software Foundation.
+
+ If the Program specifies that a proxy can decide which future
+versions of the GNU General Public License can be used, that proxy's
+public statement of acceptance of a version permanently authorizes you
+to choose that version for the Program.
+
+ Later license versions may give you additional or different
+permissions. However, no additional obligations are imposed on any
+author or copyright holder as a result of your choosing to follow a
+later version.
+
+ 15. Disclaimer of Warranty.
+
+ THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY
+APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT
+HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY
+OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO,
+THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM
+IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF
+ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
+
+ 16. Limitation of Liability.
+
+ IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS
+THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY
+GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE
+USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF
+DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD
+PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS),
+EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF
+SUCH DAMAGES.
+
+ 17. Interpretation of Sections 15 and 16.
+
+ If the disclaimer of warranty and limitation of liability provided
+above cannot be given local legal effect according to their terms,
+reviewing courts shall apply local law that most closely approximates
+an absolute waiver of all civil liability in connection with the
+Program, unless a warranty or assumption of liability accompanies a
+copy of the Program in return for a fee.
+
+ END OF TERMS AND CONDITIONS
+
+ How to Apply These Terms to Your New Programs
+
+ If you develop a new program, and you want it to be of the greatest
+possible use to the public, the best way to achieve this is to make it
+free software which everyone can redistribute and change under these terms.
+
+ To do so, attach the following notices to the program. It is safest
+to attach them to the start of each source file to most effectively
+state the exclusion of warranty; and each file should have at least
+the "copyright" line and a pointer to where the full notice is found.
+
+ <one line to give the program's name and a brief idea of what it does.>
+ Copyright (C) <year> <name of author>
+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+Also add information on how to contact you by electronic and paper mail.
+
+ If the program does terminal interaction, make it output a short
+notice like this when it starts in an interactive mode:
+
+ <program> Copyright (C) <year> <name of author>
+ This program comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
+ This is free software, and you are welcome to redistribute it
+ under certain conditions; type `show c' for details.
+
+The hypothetical commands `show w' and `show c' should show the appropriate
+parts of the General Public License. Of course, your program's commands
+might be different; for a GUI interface, you would use an "about box".
+
+ You should also get your employer (if you work as a programmer) or school,
+if any, to sign a "copyright disclaimer" for the program, if necessary.
+For more information on this, and how to apply and follow the GNU GPL, see
+<http://www.gnu.org/licenses/>.
+
+ The GNU General Public License does not permit incorporating your program
+into proprietary programs. If your program is a subroutine library, you
+may consider it more useful to permit linking proprietary applications with
+the library. If this is what you want to do, use the GNU Lesser General
+Public License instead of this License. But first, please read
+<http://www.gnu.org/philosophy/why-not-lgpl.html>.
=====================================
configure.ac
=====================================
@@ -1,4 +1,4 @@
-AC_INIT(slapi-nis,0.56.7)
+AC_INIT(slapi-nis,0.60.0)
AC_CONFIG_MACRO_DIR([m4])
AM_INIT_AUTOMAKE(foreign)
LT_INIT([disable-static])
@@ -71,8 +71,13 @@ dirsrv)
;;
openldap)
runtime_modules="nss nspr"
- LDAP_CFLAGS=
- LDAP_LIBS="-lldap_r -llber"
+ SAVE_LIBS="$LIBS"
+ LIBS=
+ AC_SEARCH_LIBS([ldap_search], [ldap_r ldap], [], [AC_MSG_ERROR([libldap or libldap_r not found])])
+ AC_SEARCH_LIBS([ber_peek_tag], [lber], [], [AC_MSG_ERROR([liblber not found])])
+ LDAP_LIBS="$LIBS"
+ LDAP_CFLAGS=""
+ LIBS="$SAVE_LIBS"
;;
*)
runtime_modules="nss nspr"
@@ -445,7 +450,7 @@ AC_ARG_WITH(groups,
groups=[cn=Groups])
AC_SUBST(groups)
-AC_DEFINE(DEFAULT_MAX_DGRAM_SIZE,YPMAXRECORD,[Define to the default maximum datagram reply size.])
+AC_DEFINE(DEFAULT_MAX_DGRAM_SIZE,(8 * 1024),[Define to the default maximum datagram reply size.])
AC_DEFINE(DEFAULT_MAX_VALUE_SIZE,(256 * 1024),[Define to the default maximum map entry key and value size.])
AC_DEFINE(DEFAULT_TARGET_REPLY_SIZE,(4 * 1024),[Define to the default target size for a connected reply fragment.])
AC_DEFINE_UNQUOTED(DEFAULT_IGNORE_SUBTREE,["cn=tasks,cn=config"],[Define to the default subtree to ignore if no value is explicitly configured for the map.])
=====================================
debian/changelog
=====================================
@@ -1,3 +1,10 @@
+slapi-nis (0.60.0-1) unstable; urgency=medium
+
+ * New upstream release.
+ * source: Extend diff-ignore.
+
+ -- Timo Aaltonen <tjaalton at debian.org> Mon, 21 Nov 2022 11:38:23 +0200
+
slapi-nis (0.56.7-1) unstable; urgency=medium
* New upstream release.
=====================================
debian/source/options
=====================================
@@ -1 +1 @@
-extend-diff-ignore = .copr|tests
+extend-diff-ignore = .copr|tests|LICENSE
=====================================
slapi-nis.spec
=====================================
@@ -10,7 +10,7 @@
%endif
Name: slapi-nis
-Version: 0.56.7
+Version: 0.60.0
Release: 1%{?dist}
Summary: NIS Server and Schema Compatibility plugins for Directory Server
License: GPLv2
@@ -31,7 +31,7 @@ BuildRequires: libsss_nss_idmap-devel > 1.16.0-5
BuildRequires: pam-devel
%if (0%{?fedora} > 14 && 0%{?fedora} < 28) || (0%{?rhel} > 6 && 0%{?rhel} < 8)
BuildRequires: libtirpc-devel
-%else:
+%else
BuildRequires: libnsl2-devel
%endif
%if 0%{?fedora} > 27
@@ -81,6 +81,13 @@ make check
%{_sbindir}/nisserver-plugin-defs
%changelog
+* Sat Aug 20 2022 Alexander Bokovoy <abokovoy at redhat.com> - 0.60.0-1
+- new upstream release
+- Change license from GPLv2 to GPLv3+ to follow 389-ds licensing
+- Fix ID views integration
+- Fix base scope lookups
+- Bump NIS max dgram size to 8KB by default instead of 1KB
+
* Tue May 18 2021 Alexander Bokovoy <abokovoy at redhat.com> - 0.56.7-1
- new upstream release
- CVE-2021-3480: invalid bind DN crash
=====================================
src/back-nis.c
=====================================
@@ -488,6 +488,9 @@ backend_map_config_filter(const char *format,
}
}
ret = malloc(l + 1);
+ if (ret == NULL) {
+ return NULL;
+ }
for (i = j = 0; format[i] != '\0'; i++) {
if (format[i] == '%') {
switch (format[i + 1]) {
@@ -1043,12 +1046,103 @@ backend_entry_is_delete_related(const char *group, const char *set, bool_t flag,
{
return FALSE;
}
+/* This task is called when the following entry is added
+ *
+ * dn: cn=rebuild 0,cn=NIS Server refresh task,cn=tasks,cn=config
+ * objectClass: top
+ * objectClass: extensibleObject
+ * cn: rebuild 0
+ */
+static int
+backend_nis_refresh_task(Slapi_PBlock *pb,
+ Slapi_Entry *e,
+ Slapi_Entry *eAfter __attribute__((unused)),
+ int *returncode,
+ char *returntext __attribute__((unused)),
+ void *arg)
+{
+ PRThread *thread = NULL;
+ int rv = SLAPI_DSE_CALLBACK_OK;
+ Slapi_Task *task = NULL;
+ task_data *mytaskdata = NULL;
+ char *bind_dn;
+ const char *filter;
+
+ *returncode = LDAP_SUCCESS;
+
+ /* get the requestor dn for our thread data*/
+ slapi_pblock_get(pb, SLAPI_REQUESTOR_DN, &bind_dn);
+ /* default filter for mapped entries */
+ if ((filter = slapi_fetch_attr(e, "filter", NIS_MAP_CONFIGURATION_FILTER)) == NULL) {
+ *returncode = LDAP_OBJECT_CLASS_VIOLATION;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+
+ /* allocate new task now */
+ task = slapi_plugin_new_task(slapi_entry_get_ndn(e), arg);
+ if (task == NULL) {
+ slapi_log_error(SLAPI_LOG_INFO, "nis-server", "backend_nis_refresh_task - Unable to allocate new task!\n");
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+
+ mytaskdata = (task_data *)slapi_ch_malloc(sizeof(task_data));
+ if (mytaskdata == NULL) {
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+ mytaskdata->state = nis_get_plugin_state();
+ mytaskdata->bind_dn = slapi_ch_strdup(bind_dn);
+ if (mytaskdata->bind_dn == NULL) {
+ slapi_log_error(SLAPI_LOG_INFO, "nis-server", "backend_nis_refresh_task - Unable initialize task data bind_dn!\n");
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+ mytaskdata->filter = slapi_ch_strdup(filter);
+ if (mytaskdata->filter == NULL) {
+ slapi_log_error(SLAPI_LOG_INFO, "nis-server", "backend_nis_refresh_task - Unable initialize task data filter!\n");
+ slapi_ch_free_string(&mytaskdata->bind_dn);
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+ mytaskdata->plugin_log_id = "nis-server";
+
+ /* set a destructor that will clean up schemadir for us when the task is complete */
+ slapi_task_set_destructor_fn(task, backend_shr_refresh_destructor);
+
+ /* Stash our task_data for use by the task thread */
+ slapi_task_set_data(task, mytaskdata);
+
+ /* start the schema reload task as a separate thread */
+ thread = PR_CreateThread(PR_USER_THREAD, backend_shr_refresh_thread,
+ (void *)task, PR_PRIORITY_NORMAL, PR_GLOBAL_THREAD,
+ PR_UNJOINABLE_THREAD, SLAPD_DEFAULT_THREAD_STACKSIZE);
+ if (thread == NULL) {
+ slapi_log_error(SLAPI_LOG_ERR, "nis-server",
+ "backend_nis_refresh_task - Unable to create schema compat refresh task thread!\n");
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ } else {
+ /* thread successful */
+ rv = SLAPI_DSE_CALLBACK_OK;
+ }
+
+out:
+
+ return rv;
+}
/* Scan for the list of configured domains and maps. */
void
backend_startup(Slapi_PBlock *pb, struct plugin_state *state)
{
- backend_shr_startup(state, pb, NIS_MAP_CONFIGURATION_FILTER);
+ backend_shr_startup(state, pb, NIS_MAP_CONFIGURATION_FILTER);
+ slapi_plugin_task_register_handler("NIS Server refresh task", backend_nis_refresh_task, pb);
}
void
=====================================
src/back-sch-idview.c
=====================================
@@ -77,7 +77,6 @@ idview_get_overrides(struct backend_search_cbdata *cbdata)
"(objectclass=ipaOverrideAnchor)", NULL, 0,
NULL, NULL, cbdata->state->plugin_identity, 0);
slapi_search_internal_pb(pb);
- slapi_ch_free_string(&dn);
slapi_pblock_get(pb, SLAPI_PLUGIN_INTOP_RESULT, &result);
if (result == 0) {
@@ -86,6 +85,7 @@ idview_get_overrides(struct backend_search_cbdata *cbdata)
slapi_pblock_set(pb, SLAPI_PLUGIN_INTOP_SEARCH_ENTRIES, NULL);
}
+ slapi_ch_free_string(&dn);
wrap_dec_call_level();
slapi_pblock_destroy(pb);
}
@@ -314,7 +314,7 @@ idview_replace_bval_by_override(const char *bval_usage, const char *attr_name,
attr_val = slapi_value_new_berval(bval);
slapi_log_error(SLAPI_LOG_PLUGIN, cbdata->state->plugin_desc->spd_id,
- "Searching for an override of the %s %s with %s=%*s from the overrides\n.",
+ "Searching for an override of the %s %s with %s=%*s from the overrides.\n",
bval_usage, attr_name, attr_name, (int) bval->bv_len, bval->bv_val);
/* If filter contains an attribute name which is overridden in the view and filter value
@@ -426,5 +426,4 @@ idview_replace_filter(struct backend_search_cbdata *cbdata)
if (config.name != NULL) {
slapi_ch_free_string(&config.name);
}
-
}
=====================================
src/back-sch-nss.c
=====================================
@@ -589,19 +589,22 @@ repeat:
return NULL;
}
- do {
+ for(rc = NSS_STATUS_TRYAGAIN; rc == NSS_STATUS_TRYAGAIN;) {
rc = backend_nss_getgrouplist(ctx, user_name, pwd.pw_gid,
grouplist, &ngroups,
&lerrno);
- if ((rc != NSS_STATUS_SUCCESS)) {
- tmp_list = realloc(grouplist, ngroups * sizeof(gid_t));
- if (tmp_list == NULL) {
+ if (rc == NSS_STATUS_TRYAGAIN) {
+ tmp_list = NULL;
+ if (lerrno == ERANGE) {
+ tmp_list = realloc(grouplist, ngroups * sizeof(gid_t));
+ }
+ if ((tmp_list == NULL) || (lerrno == ENOMEM)) {
free(grouplist);
return NULL;
}
grouplist = tmp_list;
}
- } while (rc != NSS_STATUS_SUCCESS);
+ }
entries = calloc(ngroups + 1, sizeof(entries[0]));
if (entries == NULL) {
@@ -787,8 +790,8 @@ backend_retrieve_from_nsswitch(struct backend_staged_search *staged,
if ((staged->type == SCH_NSSWITCH_GROUP) && (NULL != staged->name)) {
entries = backend_retrieve_group_entry_from_nsswitch(staged->name, staged->is_id,
- staged->container_sdn,
- cbdata, &staged->count);
+ staged->container_sdn,
+ cbdata, &staged->count);
if (entries != NULL) {
staged->entries = entries;
return TRUE;
@@ -798,8 +801,8 @@ backend_retrieve_from_nsswitch(struct backend_staged_search *staged,
if ((staged->type == SCH_NSSWITCH_USER) && (NULL != staged->name)) {
entries = backend_retrieve_user_entry_from_nsswitch(staged->name, staged->is_id,
- staged->container_sdn,
- cbdata, &staged->count);
+ staged->container_sdn,
+ cbdata, &staged->count);
if (entries != NULL) {
staged->entries = entries;
return TRUE;
=====================================
src/back-sch.c
=====================================
@@ -1060,13 +1060,7 @@ backend_get_set_config(Slapi_PBlock *parent_pb, struct plugin_state *state,
slapi_sdn_free(&groupdn);
}
-/* Given an entry, return the filter which will match a container entry beneath
- * the plugin's configuration entry. */
-const char *
-backend_entry_get_set_config_entry_filter(void)
-{
- return SCH_CONTAINER_CONFIGURATION_FILTER;
-}
+
/* Re-read plugin-wide settings that may have changed. Nothing to do. */
void
@@ -1350,8 +1344,7 @@ backend_search_find_set_dn_in_group_cb(const char *group, const char *set, bool_
cbdata->answer = TRUE;
}
- if (slapi_sdn_compare(set_data->container_sdn,
- cbdata->target_dn) == 0) {
+ if (slapi_sdn_issuffix(cbdata->target_dn, set_data->container_sdn) == 1) {
cbdata->answer = TRUE;
}
@@ -1369,15 +1362,20 @@ backend_search_find_set_dn_cb(const char *group, void *cb_data)
/* Check the group itself. */
group_dn = slapi_sdn_new_dn_byval(group);
- if (slapi_sdn_scope_test(group_dn, cbdata->target_dn,
- cbdata->scope) == 1) {
- cbdata->answer = TRUE;
- slapi_sdn_free(&group_dn);
- return TRUE;
+ if (backend_should_descend(group_dn,
+ cbdata->target_dn,
+ cbdata->scope)) {
+ map_data_foreach_map(cbdata->state, group,
+ backend_search_find_set_dn_in_group_cb, cb_data);
+ }
+
+ if (cbdata->answer != TRUE) {
+ if (slapi_sdn_compare(group_dn,
+ cbdata->target_dn) == 0) {
+ cbdata->answer = TRUE;
+ }
}
- map_data_foreach_map(cbdata->state, group,
- backend_search_find_set_dn_in_group_cb, cb_data);
slapi_sdn_free(&group_dn);
return TRUE;
}
@@ -1758,42 +1756,20 @@ backend_search_cb(Slapi_PBlock *pb)
/* We may have multiple disjoint trees in the sets, search if the target matches any of them
* as in general there don't have to be a single subtree (cn=compat,$SUFFIX) for all trees to easily
* detect the ID view use. Unless the ID view is within the set we control, don't consider the override */
+ target = slapi_ch_strdup(original_target);
+ idview_replace_target_dn(&target, &cbdata.idview);
+ if (cbdata.idview != NULL) {
+ slapi_sdn_free(&cbdata.target_dn);
+ /* Perform another check, now for rewritten DN */
+ cbdata.target_dn = slapi_sdn_new_dn_byval(target);
+ }
map_data_foreach_domain(cbdata.state, backend_search_find_set_dn_cb, &cbdata);
if (cbdata.answer == FALSE) {
- target = slapi_ch_strdup(original_target);
- idview_replace_target_dn(&target, &cbdata.idview);
- if (cbdata.idview != NULL) {
- slapi_sdn_free(&cbdata.target_dn);
- /* Perform another check, now for rewritten DN */
- cbdata.target_dn = slapi_sdn_new_dn_byval(target);
- map_data_foreach_domain(cbdata.state, backend_search_find_set_dn_cb, &cbdata);
-
- /* Rewritten DN might still be outside of our trees */
- if (cbdata.answer == TRUE) {
- slapi_log_error(SLAPI_LOG_PLUGIN, cbdata.state->plugin_desc->spd_id,
- "Use of ID view '%s' is detected, searching from \"%s\" "
- "for \"%s\" with scope %d%s. Filter may get overridden later.\n",
- cbdata.idview, target, cbdata.strfilter, cbdata.scope,
- backend_sch_scope_as_string(cbdata.scope));
- }
-
- slapi_sdn_free(&cbdata.target_dn);
- slapi_ch_free_string(&cbdata.idview);
-
- if (cbdata.answer == FALSE) {
- slapi_log_error(SLAPI_LOG_PLUGIN,
- cbdata.state->plugin_desc->spd_id,
- "The search base didn't match any of the containers, "
- "ignoring search\n");
- slapi_ch_free_string(&target);
- return 0;
- }
- }
- slapi_ch_free_string(&target);
- if (cbdata.answer == FALSE) {
- /* None of the configured trees in the sets matched the target at all, ignore search */
- return 0;
- }
+ slapi_log_error(SLAPI_LOG_PLUGIN,
+ cbdata.state->plugin_desc->spd_id,
+ "The search base %s didn't match any of the containers, "
+ "ignoring search\n", target);
+ goto cleanup;
}
cbdata.answer = FALSE;
#endif
@@ -1943,10 +1919,9 @@ backend_search_cb(Slapi_PBlock *pb)
cbdata.closest_match, cbdata.text,
cbdata.n_entries, NULL);
}
+cleanup:
slapi_sdn_free(&cbdata.target_dn);
- if (cbdata.idview != NULL) {
- slapi_ch_free_string(&target);
- }
+ slapi_ch_free_string(&target);
slapi_ch_free_string(&cbdata.idview);
#ifdef USE_IPA_IDVIEWS
idview_free_overrides(&cbdata);
@@ -2916,12 +2891,117 @@ backend_check_empty(struct plugin_state *state,
set, strlen(set) ? ", " : "", group);
}
}
+/* Given an entry, return the filter which will match a container entry beneath
+ * the plugin's configuration entry. */
+const char *
+backend_entry_get_set_config_entry_filter(void)
+{
+ return SCH_CONTAINER_CONFIGURATION_FILTER;
+}
+/* This task is called when the following entry is added
+ *
+ * dn: cn=rebuild 0,cn=Schema compatibility refresh task,cn=tasks,cn=config
+ * objectClass: top
+ * objectClass: extensibleObject
+ * cn: rebuild 0
+ */
+static int
+backend_sch_refresh_task(Slapi_PBlock *pb,
+ Slapi_Entry *e,
+ Slapi_Entry *eAfter __attribute__((unused)),
+ int *returncode,
+ char *returntext __attribute__((unused)),
+ void *arg)
+{
+ PRThread *thread = NULL;
+ int rv = SLAPI_DSE_CALLBACK_OK;
+ Slapi_Task *task = NULL;
+ task_data *mytaskdata = NULL;
+ char *bind_dn;
+ const char *filter;
+ const char *f;
+
+ *returncode = LDAP_SUCCESS;
+
+ /* get the requestor dn for our thread data*/
+ slapi_pblock_get(pb, SLAPI_REQUESTOR_DN, &bind_dn);
+
+ /* default filter for mapped entries */
+ if ((f = backend_entry_get_set_config_entry_filter()) == NULL) {
+ slapi_log_error(SLAPI_LOG_ERR, "schema-compat-plugin", "backend_sch_refresh_task - Unable retrieve the container filter!\n");
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+ if ((filter = slapi_fetch_attr(e, "filter", (char *) f)) == NULL) {
+ *returncode = LDAP_OBJECT_CLASS_VIOLATION;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+
+ /* allocate new task now */
+ task = slapi_plugin_new_task(slapi_entry_get_ndn(e), arg);
+ if (task == NULL) {
+ slapi_log_error(SLAPI_LOG_ERR, "schema-compat-plugin", "backend_sch_refresh_task - Unable to allocate new task!\n");
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+
+ mytaskdata = (task_data *)slapi_ch_malloc(sizeof(task_data));
+ if (mytaskdata == NULL) {
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+ mytaskdata->state = schema_compat_get_plugin_state();
+ mytaskdata->bind_dn = slapi_ch_strdup(bind_dn);
+ if (mytaskdata->bind_dn == NULL) {
+ slapi_log_error(SLAPI_LOG_INFO, "schema-compat-plugin", "backend_sch_refresh_task - Unable initialize task data bind_dn!\n");
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+ mytaskdata->filter = slapi_ch_strdup(filter);
+ if (mytaskdata->filter == NULL) {
+ slapi_log_error(SLAPI_LOG_INFO, "schema-compat-plugin", "backend_sch_refresh_task - Unable initialize task data filter!\n");
+ slapi_ch_free_string(&mytaskdata->bind_dn);
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ goto out;
+ }
+ mytaskdata->plugin_log_id = "schema-compat-plugin";
+
+ /* set a destructor that will clean up schemadir for us when the task is complete */
+ slapi_task_set_destructor_fn(task, backend_shr_refresh_destructor);
+
+ /* Stash our task_data for use by the task thread */
+ slapi_task_set_data(task, mytaskdata);
+
+ /* start the schema reload task as a separate thread */
+ thread = PR_CreateThread(PR_USER_THREAD, backend_shr_refresh_thread,
+ (void *)task, PR_PRIORITY_NORMAL, PR_GLOBAL_THREAD,
+ PR_UNJOINABLE_THREAD, SLAPD_DEFAULT_THREAD_STACKSIZE);
+ if (thread == NULL) {
+ slapi_log_error(SLAPI_LOG_ERR, "schema-compat-plugin",
+ "backend_sch_refresh_task - Unable to create schema compat refresh task thread!\n");
+ *returncode = LDAP_OPERATIONS_ERROR;
+ rv = SLAPI_DSE_CALLBACK_ERROR;
+ } else {
+ /* thread successful */
+ rv = SLAPI_DSE_CALLBACK_OK;
+ }
+
+out:
+ return rv;
+}
/* Populate our data cache. */
void
backend_startup(Slapi_PBlock *pb, struct plugin_state *state)
{
- backend_shr_startup(state, pb, SCH_CONTAINER_CONFIGURATION_FILTER);
+ backend_shr_startup(state, pb, SCH_CONTAINER_CONFIGURATION_FILTER);
+ slapi_plugin_task_register_handler("Schema compatibility refresh task", backend_sch_refresh_task, pb);
}
void
=====================================
src/back-shr.c
=====================================
@@ -796,9 +796,11 @@ backend_shr_data_initialize_thread(time_t when, void *arg)
if (!cbdata->state->start_priming_thread) {
slapi_log_error(SLAPI_LOG_PLUGIN, cbdata->state->plugin_desc->spd_id,
- "Likely a shutdown occurred before we started \n");
+ "Shutdown occurred before we started or other priming thread is already running\n");
goto done;
}
+ /* We are going to prim, time to prevent other priming to start */
+ cbdata->state->start_priming_thread = 0;
cbdata->state->priming_tid = wrap_start_thread(&backend_shr_data_initialize_thread_cb, arg);
if (cbdata->state->priming_tid == NULL) {
@@ -811,11 +813,134 @@ backend_shr_data_initialize_thread(time_t when, void *arg)
"%s tree scan will start in about %d seconds!\n",
cbdata->state->plugin_desc->spd_id, PLUGIN_SCAN_DELAY);
}
+ /* Now it is primed let others priming to proceed */
+ cbdata->state->start_priming_thread = 1;
done:
wrap_mutex_unlock(cbdata->state->priming_mutex);
}
+/* routine that free the structure attached as task data */
+void
+backend_shr_refresh_destructor(Slapi_Task *task)
+{
+ if (task) {
+ task_data *mydata = (task_data *)slapi_task_get_data(task);
+ while (slapi_task_get_refcount(task) > 0) {
+ /* Yield to wait for the fixup task finishes. */
+ DS_Sleep(PR_MillisecondsToInterval(100));
+ }
+ if (mydata) {
+ /* mydata->state is global, do not free it
+ * mydata->plugin_log_id is a constant, do not free it
+ */
+ slapi_ch_free_string(&mydata->bind_dn);
+ slapi_ch_free_string(&mydata->filter);
+ /* Need to cast to avoid a compiler warning */
+ slapi_ch_free((void **)&mydata);
+ }
+ }
+}
+
+
+extern int slapi_td_set_dn(char *dn);
+
+/*
+ * Task thread
+
+ */
+void
+backend_shr_refresh_thread(void *arg)
+{
+ Slapi_Task *task = (Slapi_Task *)arg;
+ int rv = 0;
+ int total_work = 2;
+ task_data *td = NULL;
+
+ if (!task) {
+ return; /* no task */
+ }
+ slapi_task_inc_refcount(task);
+
+ /* Fetch our task data from the task */
+ td = (task_data *)slapi_task_get_data(task);
+ slapi_log_error(SLAPI_LOG_INFO, td->plugin_log_id, "refresh_thread --> refcount incremented.\n");
+
+ /* Initialize and set the bind dn in the thread data.
+ * Used for setting creatorname of the task entry.
+ */
+ slapi_td_set_dn(slapi_ch_strdup(td->bind_dn));
+
+ /* update task state to show it's running */
+ slapi_task_begin(task, total_work);
+
+ /* Check if refresh is not already running or will start soon */
+ if (td->state->ready_to_serve == 0) {
+ slapi_task_log_notice(task, "Refresh task already running or initial priming not completed yet.");
+ slapi_task_log_status(task, "Refresh task already running or initial priming not completed yet.");
+ slapi_log_error(SLAPI_LOG_INFO, td->plugin_log_id,
+ "backend_shr_refresh_thread - Refresh task already running or initial priming not completed yet\n");
+ goto done;
+ }
+
+ slapi_task_log_notice(task, "Refresh task starts\n");
+ slapi_log_error(SLAPI_LOG_INFO, td->plugin_log_id, "backend_shr_refresh_thread - Refresh task starts\n");
+ slapi_task_inc_progress(task);
+
+ if (slapi_is_shutting_down()) {
+ slapi_task_log_notice(task, "Server is shutting down; Refresh aborted.");
+ slapi_task_log_status(task, "Server is shutting down; Refresh aborted.");
+ slapi_log_error(SLAPI_LOG_ERR, td->plugin_log_id, "backend_shr_refresh_thread - Server is shutting down; Refresh aborted.");
+ } else {
+ struct backend_shr_data_init_cbdata *cbdata = NULL;
+
+ slapi_task_log_notice(task, "Refresh maps starting soon.");
+ slapi_task_log_status(task, "Refresh maps starting soon.");
+ slapi_log_error(SLAPI_LOG_INFO, td->plugin_log_id, "backend_shr_refresh_thread - Refresh maps starting soon.\n");
+
+ cbdata = (struct backend_shr_data_init_cbdata *) slapi_ch_malloc(sizeof(struct backend_shr_data_init_cbdata));
+ if (cbdata == NULL) {
+ slapi_log_error(SLAPI_LOG_FATAL,
+ td->plugin_log_id,
+ "failed to create a task for populating the maps");
+ rv = SLAPI_PLUGIN_FAILURE;
+ goto done;
+ }
+ cbdata->state = td->state;
+ cbdata->filter = td->filter;
+
+ /* disable access to the maps */
+ PR_AtomicSet(&td->state->ready_to_serve, 0);
+
+ /* Free the old maps and prepare the new ones */
+ map_done(td->state);
+ map_init(NULL, td->state);
+
+ /* Schedule the initialization of the maps */
+ slapi_eq_once(backend_shr_data_initialize_thread, cbdata, PR_SecondsToInterval(1));
+ PR_Sleep(PR_SecondsToInterval(1));
+
+ /* Then wait for its completion */
+ slapi_task_log_notice(task, "Refresh maps still going on.");
+ slapi_task_log_status(task, "Refresh maps still going on.");
+ while (td->state->ready_to_serve == 0) {
+ PR_Sleep(PR_SecondsToInterval(5));
+ }
+ slapi_task_inc_progress(task);
+
+ /* update task state to say we're finished */
+ slapi_task_log_notice(task, "Refresh maps task finished.");
+ slapi_task_log_status(task, "Refresh maps task finished.");
+ slapi_log_error(SLAPI_LOG_INFO, td->plugin_log_id, "backend_shr_refresh_thread - Refresh maps task finished.\n");
+
+ }
+done:
+
+ /* this will queue the destruction of the task */
+ slapi_task_finish(task, rv);
+ slapi_task_dec_refcount(task);
+ slapi_log_error(SLAPI_LOG_INFO, td->plugin_log_id, "backend_shr_refresh_thread <-- refcount decremented.\n");
+}
/* Scan for the list of configured groups and sets. */
void
backend_shr_startup(struct plugin_state *state,
@@ -1045,10 +1170,10 @@ static bool_t
backend_shr_entry_is_a_set(struct plugin_state *state,
Slapi_PBlock *pb, Slapi_Entry *e)
{
- return backend_shr_entry_matches(pb, e,
- state->plugin_base,
- LDAP_SCOPE_ONELEVEL,
- backend_entry_get_set_config_entry_filter());
+ return backend_shr_entry_matches(pb, e,
+ state->plugin_base,
+ LDAP_SCOPE_ONELEVEL,
+ backend_entry_get_set_config_entry_filter());
}
/* Build a filter which includes the basic_filter, if given, and ANDs that
=====================================
src/back-shr.h
=====================================
@@ -43,9 +43,10 @@ PRBool backend_shr_write_ignore(Slapi_PBlock *pb);
struct plugin_state;
+void backend_shr_refresh_destructor(Slapi_Task *task);
+void backend_shr_refresh_thread(void *arg);
void backend_shr_free_server_name(struct plugin_state *state, char *master);
-int backend_shr_read_server_name(Slapi_PBlock *pb, struct plugin_state *state,
- char **master);
+int backend_shr_read_server_name(Slapi_PBlock *pb, struct plugin_state *state, char **master);
void backend_shr_free_strlist(char **strlist);
char **backend_shr_dup_strlist_n(char **strlist, int n);
@@ -89,4 +90,5 @@ char *backend_shr_get_vattr_filter(struct plugin_state *state,
bool_t backend_shr_get_vattr_boolean(struct plugin_state *state,
Slapi_Entry *e, const char *attribute,
bool_t default_value);
+const char *backend_entry_get_set_config_entry_filter();
#endif
=====================================
src/backend.h
=====================================
@@ -87,11 +87,21 @@ void backend_get_set_config(Slapi_PBlock *pb, struct plugin_state *state,
void backend_free_set_config(char **bases, char *entry_filter);
/* Check if an entry is a set configuration, and add or remove one. */
-const char *backend_entry_get_set_config_entry_filter(void);
struct backend_set_config_entry_add_cbdata {
- struct plugin_state *state;
- Slapi_PBlock *pb;
+ struct plugin_state *state;
+ Slapi_PBlock *pb;
};
+/* This structure is used during the refresh tasks*/
+typedef struct _task_data
+{
+ struct plugin_state *state; /* used to provide the plugin state to the refresh thread */
+ char *bind_dn; /* not used ATM */
+ char *filter; /* it can be set in the task entry
+ * by default standard plugin filter are used
+ * NIS_MAP_CONFIGURATION_FILTER or SCH_CONTAINER_CONFIGURATION_FILTER
+ */
+ char *plugin_log_id; /* used for error log */
+} task_data;
int backend_set_config_entry_add_cb(Slapi_Entry *e, void *callback_data);
int backend_set_config_entry_delete_cb(Slapi_Entry *e, void *callback_data);
=====================================
src/plug-nis.c
=====================================
@@ -73,6 +73,15 @@ plugin_description = {
};
static struct plugin_state *global_plugin_state;
+/* This function is call by the refresh task
+ * it is required because with the task mechanism, plugin state
+ * is not present in pblock(SLAPI_PRIVATE) so it needs to be retrieved
+ * by the plugin task, before calling the shared task
+ */
+struct plugin_state *nis_get_plugin_state()
+{
+ return global_plugin_state;
+}
/* Populate the map cache, register with the local portmapper, and then start
* the plugin's work thread to answer requests using the cache. */
static int
@@ -598,7 +607,13 @@ nis_plugin_init(Slapi_PBlock *pb)
#endif
slapi_log_error(SLAPI_LOG_PLUGIN, state->plugin_desc->spd_id,
"registered plugin hooks\n");
- global_plugin_state = NULL;
+ /* The registered plugin callbacks retrieve the global_plugin_state
+ * from the pblock(SLAPI_PLUGIN_PRIVATE).
+ * The task mechanism does not provide the reference to global_plugin_state.
+ * So for the map refresh task, global_plugin_state should not be reset
+ * and it is provided by nis_get_plugin_state().
+ * global_plugin_state = NULL;
+ */
/* Note that the plugin was successfully loaded. */
slapi_log_error(SLAPI_LOG_PLUGIN, plugin_description.spd_id,
"plugin initialized\n");
=====================================
src/plug-sch.c
=====================================
@@ -79,6 +79,15 @@ plugin_description = {
};
static struct plugin_state *global_plugin_state;
+/* This function is call by the refresh task
+ * it is required because with the task mechanism, plugin state
+ * is not present in pblock(SLAPI_PRIVATE) so it needs to be retrieved
+ * by the plugin task, before calling the shared task
+ */
+struct plugin_state *schema_compat_get_plugin_state()
+{
+ return global_plugin_state;
+}
/* Handle the part of startup that needs to be done before we drop privileges,
* which for this plugin isn't much at all. */
static int
@@ -441,7 +450,13 @@ schema_compat_plugin_init(Slapi_PBlock *pb)
}
slapi_log_error(SLAPI_LOG_PLUGIN, state->plugin_desc->spd_id,
"registered plugin hooks\n");
- global_plugin_state = NULL;
+ /* The registered plugin callbacks retrieve the global_plugin_state
+ * from the pblock(SLAPI_PLUGIN_PRIVATE).
+ * The task mechanism does not provide the reference to global_plugin_state.
+ * So for the map refresh task, global_plugin_state should not be reset
+ * and it is provided by schema_compat_get_plugin_state().
+ * global_plugin_state = NULL;
+ */
/* Note that the plugin was successfully loaded. */
slapi_log_error(SLAPI_LOG_PLUGIN, plugin_description.spd_id,
"plugin initialized\n");
=====================================
src/plugin.h
=====================================
@@ -55,5 +55,6 @@ struct plugin_state {
void *cached_entries;
struct wrapped_rwlock *cached_entries_lock;
};
-
+struct plugin_state *nis_get_plugin_state();
+struct plugin_state *schema_compat_get_plugin_state();
#endif
=====================================
tests/azure/scripts/azure-run-base-tests.sh
=====================================
@@ -101,14 +101,14 @@ if [ "$install_result" -eq 0 ] ; then
firewalld_cmd --remove-service={freeipa-ldap,freeipa-ldaps,dns}
fi
-echo "Report memory statistics"
-cat /sys/fs/cgroup/memory/memory.memsw.failcnt
-cat /sys/fs/cgroup/memory/memory.memsw.limit_in_bytes
-cat /sys/fs/cgroup/memory/memory.memsw.max_usage_in_bytes
-cat /sys/fs/cgroup/memory/memory.failcnt
-cat /sys/fs/cgroup/memory/memory.max_usage_in_bytes
-cat /sys/fs/cgroup/memory/memory.limit_in_bytes
-cat /proc/sys/vm/swappiness
+echo "Report memory statistics (may fail in containers)"
+cat /sys/fs/cgroup/memory/memory.memsw.failcnt ||:
+cat /sys/fs/cgroup/memory/memory.memsw.limit_in_bytes ||:
+cat /sys/fs/cgroup/memory/memory.memsw.max_usage_in_bytes ||:
+cat /sys/fs/cgroup/memory/memory.failcnt ||:
+cat /sys/fs/cgroup/memory/memory.max_usage_in_bytes ||:
+cat /sys/fs/cgroup/memory/memory.limit_in_bytes ||:
+cat /proc/sys/vm/swappiness ||:
# Final result depends on the exit code of the ipa-run-tests
test "$tests_result" -eq 0 -a "$install_result" -eq 0
=====================================
tests/azure/scripts/azure-run-integration-tests.sh
=====================================
@@ -27,12 +27,12 @@ find "$PROJECT_TESTS_LOGSDIR" -mindepth 1 -maxdepth 1 -not -name '.*' -type d \
-exec tar --remove-files -czf {}.tar.gz {} \;
echo "Report memory statistics"
-cat /sys/fs/cgroup/memory/memory.memsw.failcnt
-cat /sys/fs/cgroup/memory/memory.memsw.limit_in_bytes
-cat /sys/fs/cgroup/memory/memory.memsw.max_usage_in_bytes
-cat /sys/fs/cgroup/memory/memory.failcnt
-cat /sys/fs/cgroup/memory/memory.max_usage_in_bytes
-cat /sys/fs/cgroup/memory/memory.limit_in_bytes
-cat /proc/sys/vm/swappiness
+cat /sys/fs/cgroup/memory/memory.memsw.failcnt ||:
+cat /sys/fs/cgroup/memory/memory.memsw.limit_in_bytes ||:
+cat /sys/fs/cgroup/memory/memory.memsw.max_usage_in_bytes ||:
+cat /sys/fs/cgroup/memory/memory.failcnt ||:
+cat /sys/fs/cgroup/memory/memory.max_usage_in_bytes ||:
+cat /sys/fs/cgroup/memory/memory.limit_in_bytes ||:
+cat /proc/sys/vm/swappiness ||:
exit $tests_result
=====================================
tests/azure/templates/test-jobs.yml
=====================================
@@ -48,9 +48,9 @@ steps:
- script: |
set -eux
free -m
- cat /sys/fs/cgroup/memory/memory.memsw.max_usage_in_bytes
- cat /sys/fs/cgroup/memory/memory.max_usage_in_bytes
- cat /proc/sys/vm/swappiness
+ cat /sys/fs/cgroup/memory/memory.memsw.max_usage_in_bytes ||:
+ cat /sys/fs/cgroup/memory/memory.max_usage_in_bytes ||:
+ cat /proc/sys/vm/swappiness ||:
condition: succeededOrFailed()
displayName: Host's memory statistics
View it on GitLab: https://salsa.debian.org/freeipa-team/slapi-nis/-/compare/eda65bf9446571dfde37c8a025f171a3ffa63463...45c264bd78e20f5d32f44c8cf357cb45d23ec547
--
View it on GitLab: https://salsa.debian.org/freeipa-team/slapi-nis/-/compare/eda65bf9446571dfde37c8a025f171a3ffa63463...45c264bd78e20f5d32f44c8cf357cb45d23ec547
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-freeipa-devel/attachments/20221121/08865e88/attachment-0001.htm>
More information about the Pkg-freeipa-devel
mailing list