[Pkg-freeipa-devel] Bug#1089367: libmozilla-ldap-perl: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 20:34:48 +0100 Niels Thykier <niels at thykier.net> wrote:
> Source: libmozilla-ldap-perl
> Version: 1.5.3-3
> Severity: important
> Tags: ftbfs
> Justification: FTBFS
> X-Debbugs-Cc: niels at thykier.net
> User: niels at thykier.net
> Usertags: rrr-no-as-default-issue
> 
> Dear maintainer,
> 
> During a test rebuild for building packages with
> `Rules-Requires-Root: no` as the default in `dpkg`,
> libmozilla-ldap-perl failed to rebuild.
> 
> [...]

Hi,

Please see attached as a suggested patch.

Best regards,
Niels

PS: I tried the VCS header, but the package does not appear to be 
imported to salsa (at least not under that URL).

-------------- next part --------------
diff -Nru libmozilla-ldap-perl-1.5.3/debian/changelog libmozilla-ldap-perl-1.5.3/debian/changelog
--- libmozilla-ldap-perl-1.5.3/debian/changelog	2018-12-04 11:40:45.000000000 +0100
+++ libmozilla-ldap-perl-1.5.3/debian/changelog	2024-12-28 12:46:58.000000000 +0100
@@ -1,3 +1,11 @@
+libmozilla-ldap-perl (1.5.3-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Have the package build without requring root.
+    (Closes: #1089367)
+
+ -- Niels Thykier <niels at thykier.net>  Sat, 28 Dec 2024 11:46:58 +0000
+
 libmozilla-ldap-perl (1.5.3-3) unstable; urgency=medium
 
   * control: Update VCS urls.
diff -Nru libmozilla-ldap-perl-1.5.3/debian/control libmozilla-ldap-perl-1.5.3/debian/control
--- libmozilla-ldap-perl-1.5.3/debian/control	2018-12-04 11:31:18.000000000 +0100
+++ libmozilla-ldap-perl-1.5.3/debian/control	2024-12-28 12:46:58.000000000 +0100
@@ -9,6 +9,7 @@
  quilt,
  libldap2-dev (>= 2.4.28),
  libnss3-dev
+Rules-Requires-Root: no
 Standards-Version: 4.2.1
 Vcs-Git: https://salsa.debian.org/freeipa-team/libmozilla-ldap-perl.git
 Vcs-Browser: https://salsa.debian.org/freeipa-team/libmozilla-ldap-perl.git
diff -Nru libmozilla-ldap-perl-1.5.3/debian/rules libmozilla-ldap-perl-1.5.3/debian/rules
--- libmozilla-ldap-perl-1.5.3/debian/rules	2014-08-11 11:21:59.000000000 +0200
+++ libmozilla-ldap-perl-1.5.3/debian/rules	2024-12-28 12:46:58.000000000 +0100
@@ -47,6 +47,11 @@
 	dh_installexamples examples/*
 	dh_installdocs CREDITS README 
 	dh_installchangelogs ChangeLog
+	# This chmod is unnecessary with `dh`, since it orders
+	# things differently. Though, it solves the problem here
+	# and now without doing a full analysis of whether the
+	# dh ordering can be used.
+	chmod -R u+rwX $(TMP)
 	dh_strip -a
 	dh_makeshlibs -a
 	dh_installdeb -a
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-freeipa-devel/attachments/20241228/96089ebf/attachment.sig>