[Pkg-freeipa-devel] [Git][freeipa-team/389-ds-base][master] 124 commits: Issue 5714 - UI - fix typo, db settings, log settings, and LDAP editor paginations
Timo Aaltonen (@tjaalton)
gitlab at salsa.debian.org
Mon Jan 8 16:05:31 GMT 2024
Timo Aaltonen pushed to branch master at FreeIPA packaging / 389-ds-base
Commits:
66e89b66 by Mark Reynolds at 2023-03-31T11:11:55-04:00
Issue 5714 - UI - fix typo, db settings, log settings, and LDAP editor paginations
Description:
- DB settings "Look Through Limit" was misspelled, and the "+" increment button was not working
- Configuring logs would not correctly enable/disable the save button
- LDAP Browser - Pagination was not working correctly when you search for attributes/objectclasses. We were also missing some "search" inputs for attributes in some of the forms.
relates: https://github.com/389ds/389-ds-base/issues/5714
Reviewed by: spichugi(Thanks!)
- - - - -
6033380a by James Chapman at 2023-04-04T07:17:50+01:00
Issue 5643 - Memory leak in entryrdn during delete (#5717)
Bug description: Failure to delete temp key buffer
Fix description: Delete temp key buffer on exit
Fixes: https://github.com/389ds/389-ds-base/issues/5643
Reviewed by: @mreynolds389 (Thank you)
- - - - -
7f16473a by Vladimir Cech at 2023-04-05T12:19:54+02:00
Issue 4758 - Add tests for WebUI
Description:
Added WebUI visibility tests for server tab, database tab, replication tab, schema tab, monitoring tab.
Relates: https://github.com/389ds/389-ds-base/issues/4758
Reviewed by: https://github.com/bsimonova (Thank you!)
- - - - -
a01e230f by James Chapman at 2023-04-10T22:29:51+01:00
Issue 5705 - Add config parameter to close client conns on failed bind (#5712)
Description: Malformed applications that ignore BIND return code can
load the server with unnecessary requests
Fix description: Add a config option that will allow the closure of a
client connection from server side when a BIND is failing.
relates: https://github.com/389ds/389-ds-base/issues/5707
Reviewed by: @droideck (Thank you)
- - - - -
1a788100 by James Chapman at 2023-04-11T12:51:01+01:00
Issue 5718 - Memory leak in connection table (#5719)
Bug description: duplicate multiple mem allocation cause leak
Fix description: remove duplicate allocation
Fixes: https://github.com/389ds/389-ds-base/issues/5718
Reviewed by: @Firstyear (Thank you)
- - - - -
56939cc3 by Vladimir Cech at 2023-04-13T10:30:01+02:00
Issue 4758 - Add tests for WebUI
Description:
Added WebUI visibility tests for Plugins tab, LDAP Browser tab.
Relates: https://github.com/389ds/389-ds-base/issues/4758
Reviewed by: @bsimonova @droideck (Thanks!)
- - - - -
6ae14bc8 by tbordaz at 2023-04-17T15:29:32+02:00
Issue 5726 - ns-slapd crashing in ldbm_back_upgradednformat (#5727)
Bug description:
With LDBM / BDB separation, LDBM functions like
upgradednformat need to initialize ldbminfo
Fix description:
call dblayer_setup in upgradednformat
relates: #5726
Reviewed by: Simon Pichugin (Thanks)
- - - - -
dd7d487a by Firstyear at 2023-04-21T10:29:09+10:00
Issue 5734 - RFE - Exclude pwdFailureTime and ContextCSN (#5735)
Bug Description: A customer reported an issue with openldap to 389ds migration. This was due to
their openldap instance using a number of openldap attributes that I had not encountered in other
migrations.
These attributes are operational to openldap only and can be safely excluded.
Fix Description: Exclude pwdFailureTime and ContextCSN
fixes: https://github.com/389ds/389-ds-base/issues/5734
Author: William Brown <william at blackhats.net.au>
Review by: ???
- - - - -
9a05477f by tbordaz at 2023-04-21T11:25:29+02:00
Issue 5156 - RFE that implement slapi_memberof (#5694)
Bug description:
The RFE #5156 implements a new slapi function slapi_memberof.
This function is described in
https://www.port389.org/docs/389ds/design/slapi_memberof.html
For a given target entry, it allows the caller to retrieve
all entries that have a membership relation to that entry.
Typically, retrieving the groups that the given entry
is memberof.
This PR contains the implementation of slapi_memberof.
This PR contains part of the tests of slapi_memberof.
It does not contain the tests that are based on
already computed 'memberof' attribute (memberof plugin).
Those remaining tests will be reviewed later
Fix description:
This PR contains the implementation of slapi_memberof.
The slapi_memberof function is called by the server or
plugins.
The tests implements a new extop plugins 2.3.4.5.113730.6.7.1
(test_slapi_memberof.c).
At startup the init function (test_slapi_memberof_init) of
the extop plugin read the plugin configuration entry. The
config entry contains params with which slapi_memberof
is called (scope, excludeScope, recurse, membership attr,...)
The extop receives a target entry as parameters and call
slapi_memberof with this target entry and the config params.
The test suite tests give examples of all params setting
except the flag=MEMBEROF_RECOMPUTE that is hardcoded
(new tests will change this flag)
relates: #5156
Reviewed by: Mark Reynolds, Simon Pichugin, William Brown (Very big thanks!!!)
- - - - -
87efeb29 by Mark Reynolds at 2023-04-25T15:21:47-04:00
Bump version to 2.4.0
- - - - -
18ef874d by Vladimir Cech at 2023-04-27T12:23:50+02:00
Issue 4758 - Add tests for WebUI
Description:
Added WebUI test for bug where RHDS instance won't load when backup directory is set to non existing directory.
Relates: https://github.com/389ds/389-ds-base/issues/4758
Reviewed by: @bsimonova (Thanks!)
- - - - -
881cade7 by Mark Reynolds at 2023-04-27T16:25:36-04:00
Issue 5156 - fix build breakage from slapi-memberof commit
Description: Function prototypes were not declared correctly and this breaks
the builds on new compilers.
relates: #5156
Reviewed by: ?
- - - - -
0f9a80ac by Mark Reynolds at 2023-04-28T08:21:24-04:00
Issue - Copy config files into backup directory
Description: Copy dse.ldif, schema files, certmap.conf, slapd-collations,
and NSS files into the backup. These files are not restored
during a bak2db, so they must be manaully restored (if needed)
relates: https://github.com/389ds/389-ds-base/issues/2562
Reviewed by: firstyear, spichugi, progier, and tbordaz (Thanks!!!!)
- - - - -
9132f07b by progier389 at 2023-04-28T17:02:29+02:00
Issue 5743 - Disabling replica crashes the server (#5746)
* Issue 5743 - Disabling replica crashes the server
Problem: Server crash when disabling replication on a supplier/hub/consumer because of a null pointer exception while trying to delete the changelog.
Solution is trivial: do not try to use NULL pointer.
I double checked that the changelog db is still deleted in SUPPLIER/HUB case
(without the fix the crash also occurs in these cases, I suspect that the changelog removal code is called twice)
- - - - -
2d1e1455 by Mark Reynolds at 2023-05-04T14:57:23-04:00
Issue 5749 - RFE - Allow Account Policy Plugin to handle inactivity and expiration at the same time
Description:
Currently Account Policy Plugin as a state attribute and alternate state attribute.
If the main state attribute is NOT present in the entry then it fails back to the
alternate state attribute.
This RFE adds a new setting that tells the plugin to check both state attributes.
The purpose of this is for expiration and inactivity, so this is meant to be used
when the alternate state attribute is 'passwordExpirationtime'. So if the main
state attribute is OK, it will then check the alternate state attribute for
inactivity.
relates: https://github.com/389ds/389-ds-base/issues/5749
Reviewed by: tbordaz & spichugi(Thanks!!)
- - - - -
ea0ed1f5 by tbordaz at 2023-05-08T11:16:54+02:00
Issue 5156 - build warnings (#5758)
- - - - -
3dd9bd36 by Mark Reynolds at 2023-05-08T08:28:07-04:00
Issue 5738 - RFE - UI - Read/write replication monitor info to .dsrc file
Description:
Allow UI to use the .dsrc replication monitor info, and also allow the UI to
write new report configurations. This prevents an admin from having to enter
this information every time they want to run a report
relates: https://github.com/389ds/389-ds-base/issues/5738
Reviewed by: spichugi(Thanks!)
- - - - -
a55fa308 by tbordaz at 2023-05-09T08:51:47+02:00
Issue 5704 - crash in sync_refresh_initial_content (#5720)
Bug description:
If the last record of the changelog is not accessible
then the session record is NULL. It crashes the server
when it is dereferenced.
I failed to reproduce it, including disabling/removing
'cn=changelog' backend/mapping tree. So I guess it
happens during rare dynamic.
Fix description:
Return a failure when the session cookie is not
initialized
relates: #5704
Reviewed by: Mark Reynolds (Thanks)
- - - - -
bcbad874 by tbordaz at 2023-05-09T15:06:55+02:00
Issue 5722 - RFE When a filter contains 'nsrole', improve response time by rewriting the filter (#5723)
Bug description:
'nsrole' is a virtual attribute and is not indexed.
With a poorly selective filter like below the search may be not indexed
"(&(nsrole=cn=managed_role,cn=suffix)(objectclass=posixAccount)))"
The RFE is to rewrite the filter component contains 'nsrole'
attribute type.
Rewritten component can then been indexed
Fix description:
For managed role, it replaces 'nsrole' with 'nsroleDN'
attribute type
For filtered roled, it replace the 'nsrole' component
with the nsRoleFilter value
relates: #5722
Reviewed by: Pierre Rogier (Thanks)
- - - - -
7c90259f by James Chapman at 2023-05-09T15:35:39+01:00
Issue 5752 - RFE - Provide a history for LastLoginTime (#5753)
Description: When a user did a successfully bind, the "LastLoginTime"
attribute is updated. We have now a request from our security department
to display the users last successful bind before the current one. When
we just read out this attribute the value is already updated, so that
the user did not see his real last successful
login, in fact he sees the current login date and time.
Fix description: Create a new Acount Policy attribute to store the
login time stamps for a successful bind.
relates: https://github.com/389ds/389-ds-base/issues/5752
Reviewed by: @droideck (Thank you)
- - - - -
05528f6d by Firstyear at 2023-05-11T00:25:13+10:00
Issue 5052 - BUG - Custom filters prevented entry deletion (#5060)
Bug Description: When a custom filter was provided, entries
which were deleted in AD did not have that event correctly
reflected in 389-ds. This was due to the behaviour that when
an entry in AD is deleted, it is marked with a "deleted" flag
which the objectClass=* filter would (accidentally) collect
when it did a search. However, a custom user filter being
specified would in some cases (such as a memberOf filter)
NOT show up the deletion since the entry was considered
to have moved out of scope rather than being a full delete.
Fix Description: In the case that we have a userfilter, we
wrap it in an OR condition that always requests isDeleted
flags so that we can correctly reflect the delete status.
fixes: https://github.com/389ds/389-ds-base/issues/5052
Author: William Brown <william at blackhats.net.au>
Review by: @mreynolds389 @tbordaz
- - - - -
5304d4f2 by Mark Reynolds at 2023-05-11T08:16:43-04:00
Issue 152 - RFE - Add support for LDAP alias entries
Description: Per RFC rfc4512#section-2.6 add support for Alias Entries.
Currently this is only designed to work with "base" searches.
Thanks for @anilech for the code contribution!!!
relates: https://github.com/389ds/389-ds-base/issues/152
Reviewed by: spichugi, tbordaz, and progier(Thanks!!!)
- - - - -
1b2458fe by Mark Reynolds at 2023-05-16T11:28:09-04:00
Issue 5765 - Improve installer selinux handling
Description: When labeling ports we retry on error, and we should do the same
when labeling files
relates: https://github.com/389ds/389-ds-base/issues/5765
Reviewed by: ?
- - - - -
fdc2d53d by tbordaz at 2023-05-16T18:55:20+02:00
Issue 5722 - fix compilation warnings (#5771)
- - - - -
e7ef61f9 by Mark Reynolds at 2023-05-18T09:11:02-04:00
Issue 5768 - CLI/UI - cert checks are too strict, and other issues
Description:
The certificate type checks for CA/server break if there are no certificate
extensions set (use openssl in that case to gather the info instead).
dscontainter needed to be updated for new cert checks, and UI adding certs
improvements.
relates: https://github.com/389ds/389-ds-base/issues/5768
Reviewed by: spichugi(Thanks!)
- - - - -
d95d7e96 by Mark Reynolds at 2023-05-18T09:16:12-04:00
Issue 5770 - RFE - Extend Password Adminstrators to allow skipping password info updates
Description:
Add new config setting to state that password admin updates should not update
entry's password state attributes.
relates: https://github.com/389ds/389-ds-base/issues/5770
Reviewed by: progier, tbordaz, spichugi (Thanks!)
- - - - -
234cb2ec by Mark Reynolds at 2023-05-18T10:36:31-04:00
Bump version to 2.4.1
- - - - -
37ec5cda by tbordaz at 2023-05-22T17:03:01+02:00
Issue 5751 - Cleanallruv task crashes on consumer (#5775)
Bug description:
During CL refactoring (changelog DB was integrated into the main DB #2621)
several parts of code (removed DB, export/import CL,
cleanallRUV,..) calls replica_get_cl_info to retrieve the
changelog of a replica. If the replica does not contain a
changelog (consumer) the returned pointer is NULL.
Some code assume the pointer is not NULL and derefence it.
Fix description:
For all calls to replica_get_cl_info, check the pointer
before referencing it
relates: #5751
Reviewed by: Mark Reynolds
- - - - -
79d04f47 by Mark Reynolds at 2023-05-25T15:43:35-04:00
Issue 5778 - UI - Remove error message if .dsrc is missing
Description: Having a .dsrc file is not required, so the UI should not report
an error if it's not present
relates: https://github.com/389ds/389-ds-base/issues/5778
Reviewed by: spichugi & progier(Thanks!)
- - - - -
c6b2236c by James Chapman at 2023-05-29T10:38:21+01:00
Issue 5646 - Various memory leaks (#5725)
Bug description: A memory leak occurs when a sync repl search is run
in refreshPersist mode. The connection from sync repl consumer is
closed without freeing up the ldap req ctrls.
Fix description: When the connection to the client is closed or on
shutdown free the request control structure if it exists.
relates: https://github.com/389ds/389-ds-base/issues/5646
Reviewed by: @progier389, @droideck, @Firstyear, @tbordaz (Thank you)
- - - - -
ba0e1ce0 by Simon Pichugin at 2023-06-06T07:58:01-07:00
Issue 5786 - Set minimal permissions on GitHub Workflows (#5787)
Set minimal permissions on our GitHub Workflows.
Defining minimal permissions secures you against erroneous or malicious behaviour from external jobs you call from your workflow. It's especially important in case they get compromised.
Fixes: https://github.com/389ds/389-ds-base/issues/5786
Reviewed by: @mreynolds389 (Thanks!)
- - - - -
7fbcb8da by Mark Reynolds at 2023-06-06T12:51:14-04:00
Issue 5786 - CLI - registers tools for bash completion
Description:
In newer versions of Fedora you need to register the CLI tools for bash
completion. Previously it worked out of the box, but now this
registration is required
relates: https://github.com/389ds/389-ds-base/issues/5785
Reviewed by: spichugi & viktor(Thanks!!)
- - - - -
a30a9e0d by Mark Reynolds at 2023-06-08T11:45:51-04:00
Issue 5789 - Improve ds-replcheck error handling
Description: When replication is not fully configured the tool outputs vague
messages. These should be cleaned up to indicate that
replication was not initialized. Also added healthcheck.
Relates: https://github.com/389ds/389-ds-base/issues/5789
Reviewed by: tbordaz, spichugi, progier (Thanks!!!)
- - - - -
3ddb1027 by Simon Pichugin at 2023-06-12T09:57:23-07:00
Issue 3527 - Add PROXY protocol support (#5762)
Description: Add support to 389-base for the PROXY protocol
for ACI evaluation and also for logging client queries.
The proxy protocol is described here:
http://www.haproxy.org/download/1.5/doc/proxy-protocol.txt
Fixes: https://github.com/389ds/389-ds-base/issues/3527
Reviewed by: @Firstyear, @progier389, @mreynolds389 (Thanks!)
- - - - -
99045500 by Vladimir Cech at 2023-06-13T11:28:23+02:00
Issue 4758 - Add tests for WebUI
Description:
Adding WebUI tests for bz1654238. Test for bz1654238 checks that you are able to create new entries in LDAP Browser tab.
Relates: https://github.com/389ds/389-ds-base/issues/4758
Reviewed by: @droideck (Thanks!)
- - - - -
eaabdd2a by tbordaz at 2023-06-14T10:50:53+02:00
Issue 5156 - (cont) RFE slapi_memberof reusing memberof values (#5744)
Bug description:
The RFE #5156 implements a new slapi function slapi_memberof.
This function is described in
https://www.port389.org/docs/389ds/design/slapi_memberof.html
A previous PR was relate to the implementation of
slapi_memberof, test plugin and tests to recompute membership
relations (MEMBEROF_RECOMPUTE)
Fix description:
This PR contains the remaining tests of slapi_memberof that
verify the ability of slapi_memberof to reuse 'memberof'
values. (MEMBEROF_REUSE_ONLY, MEMBEROF_REUSE_IF_POSSIBLE)
This PR also fixes some bugs in the slapi_membeof function
and the test plugin.
relates: #5156
Reviewed by: Pierre Rogier (thanks)
- - - - -
54cf07cc by Mark Reynolds at 2023-06-14T16:23:23-04:00
Issue 5785 - move bash completion to post section of specfile
Description: Need to move bash completion setup to %post section of specfile.
Previously it was done during the build process which is incorrect and breaks
builds.
relates: https://github.com/389ds/389-ds-base/issues/5785
Reviewed by: spichugi(Thanks!)
- - - - -
582f0294 by osenchenko at 2023-06-14T17:04:31-04:00
Issue 5781 - Bug handling return code of pre-extended operation plugin.
Issue 5781 - Bug handling return code of pre-extended operation plugin.
Bug Description: The return code of the plugin with the type "pre-extended operation" is not used when processing extended operation.Regardless of the plugin's return code, the operation continues to be processed.
Fix Description: Add additional condition in if statement
relates: https://github.com/389ds/389-ds-base/issues/5781
Author: osenchenko
Reviewed by: Mark Reynolds (thanks)
- - - - -
3cdc7d82 by Simon Pichugin at 2023-06-16T10:05:37-07:00
Issue 5798 - CLI - Add multi-valued support to dsconf config (#5799)
Description: Currently, we have two editable multi-valued attributes in cn=config:
nsslapd-haproxy-trusted-ip and nsslapd-referral.
Our current cn=config implementation doesn't support bunch ADD operations.
Make our CLI tools more robust so they can handle multi-valued attributes correctly.
Add add_many method to DSLdapObject.
Fixes: https://github.com/389ds/389-ds-base/issues/5798
Reviewed by: @mreynolds389 (Thanks!)
- - - - -
3b76ff7a by Simon Pichugin at 2023-06-19T14:12:00-07:00
Issue 3527 - Fix HAProxy x390x compatibility and compiler warnings (#5801)
Description: We need to support both big-endian (x390x) and little-endian (x86)
architectures, it's better to dynamically adjust the byte order in our test cases
based on the architecture of the system executing the tests.
Define the values depending on the architecture.
Fix minor compiler warnings.
Related: https://github.com/389ds/389-ds-base/issues/3527
Reviewed by: @mreynolds389 (Thanks!)
- - - - -
138f1bf3 by Simon Pichugin at 2023-06-21T09:06:28-07:00
Issue 5752 - CI - Add more tests for lastLoginHistorySize RFE (#5802)
Description: Add more tests for lastLoginHistorySize, including zero, negative,
non-integer test values.
Also, refactor the initial tests so we can expand the test suite easily.
Related: https://github.com/389ds/389-ds-base/issues/5752
Reviewed by: @jchapma (Thanks!)
- - - - -
ed8b5f3b by Mark Reynolds at 2023-06-21T15:26:46-04:00
Issue 5793 - UI - movce from webpack to esbuild bundler
Description:
To stay consistent and current with Cockpit (via https://github.com/cockpit-project/starter-kit)
we need to move from webpack to esbuild
relates: https://github.com/389ds/389-ds-base/issues/5793
Reviewed by: spichugi(Thanks!)
- - - - -
07477c6e by dependabot[bot] at 2023-06-22T15:53:11-04:00
Bump openssl from 0.10.52 to 0.10.55 in /src
Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.52 to 0.10.55.
- [Release notes](https://github.com/sfackler/rust-openssl/releases)
- [Commits](https://github.com/sfackler/rust-openssl/compare/openssl-v0.10.52...openssl-v0.10.55)
---
updated-dependencies:
- dependency-name: openssl
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support at github.com>
- - - - -
4b2f9ecd by Mark Reynolds at 2023-06-23T16:02:46-04:00
Issue 2375 - CLI - Healthcheck - revise and add new checks
Description:
Add check for
- unauthorized binds are allowed
- Access log buffering is disabled
- Security log buffering is disabled
- Make mapping tree check more robust for case
relates: https://github.com/389ds/389-ds-base/issues/2375
Reviewed by: spichugi(Thanks!)
- - - - -
b6cede51 by James Chapman at 2023-06-27T20:55:51+01:00
Issue 5755 - The Massive memory leaking on update operations (#5803)
Bug description: Memory leak with creation, modification and
deletion operations.
Fix description: When multiple search filters are used we use
set manipulation to construct the final idl results. In this
corner case we set the idl_set->compliment_head pointer which
is never freed.
relates: https://github.com/389ds/389-ds-base/issues/5755
Co-authored-by: Viktor Ashirov <vashirov at redhat.com>
Reviewed by: @mreynolds389 (Thank you)
- - - - -
f2c1e44b by John Obaterspok at 2023-06-29T14:31:50-04:00
Issue 5551 - Almost empty and not loaded ns-slapd high cpu load
Bug Description: stracing the ns-slapd process one can see nanosleep gets called a lot as we only sleep for 1ms
Fix Description: Increasing the sleep time from 1ms to 500ms and the cpu usage will drop drop a few percent and strace will be more usable
relates: https://github.com/389ds/389-ds-base/issues/5551
Reviewd by: @mreynolds389
- - - - -
c3bec8b1 by Simon Pichugin at 2023-07-04T19:47:46-07:00
Issue 5701 - CI - Add more tests for referral mode fix (#5810)
Description: Refactor basic referral state test to be correct
according to the current lib389 implementation.
Add more tests to the clu/dsconf_test.py suite, which covers
CLI referral state logic.
Related: https://github.com/389ds/389-ds-base/issues/5701
Reviewed by: @progier389 (Thanks!)
- - - - -
13152871 by James Chapman at 2023-07-05T14:20:00+01:00
Issue 5755 - Massive memory leaking on update operations (#5824)
Description: Correction of idl memory leak fix
Fix description: Initial mem leak fix (#5803) causing a SEGV during
basic search.
The inital memory leak occurs during idl_set manipulation when a filter
type LDAP_FILTER_AND, filter choice LDAP_FILTER_NOT and an empty set is
used. The complelement idl is stashed for a later intersection, but is
never freed when an empty set is used during set intersection.
The previous fix has been removed and the inital leak corrected.
relates: https://github.com/389ds/389-ds-base/pull/5803
Reviewed by: @tbordaz @progier389 (Thank you)
- - - - -
c853fd43 by multipleofzero at 2023-07-05T14:25:24-04:00
Issue #5822 - Allow empty export path for db2ldif
Bug Description:
Until recently, db2ldif did not require an export path to be specified
and would use a specified default location to create a timestamped file.
A recent commit introduced a check to ensure the targeted export file's
parent actually exists. This check is fine if a target filename is
provided, but it fails when no filename is provided; a use case that
was supported before.
Fix Description:
The check should only be done iff a filename for the export is provided.
relates: https://github.com/389ds/389-ds-base/issues/5822
Author: multipleofzero
Reviewed by: @droideck
- - - - -
1fa23145 by Mark Reynolds at 2023-07-06T14:26:57-04:00
Issue 5825 - healthcheck - password storage scheme warning needs more info
Description: Add the current/insecure scheme to the report, and state which
config setting is insecure.
relates: https://github.com/389ds/389-ds-base/issues/5825
Reviewed by: jchapman & spichugi(Thanks!!)
- - - - -
c058a2b5 by Simon Pichugin at 2023-07-06T12:24:48-07:00
Issue 5793 - UI - Fix minor crashes (#5827)
Description: After a massive move from webpack to esbuild bundler rework,
fix two minor crashes which happened because of minor copy-paste errors.
Related: https://github.com/389ds/389-ds-base/issues/5793
Reviewed by: @mreynolds389 (Thanks!)
- - - - -
97661cc9 by Mark Reynolds at 2023-07-07T14:10:49-04:00
Issue 5793 - UI - fix suffix selection in export modal
Description: Fix suffix selection which was not working, and fix crash
related to the move from webpack to esbuild (reload function
name)
relates: https://github.com/389ds/389-ds-base/issues/5793
Reviewed by: spichugi(Thanks!)
- - - - -
354d98df by Vladimir Cech at 2023-07-10T16:07:45+02:00
Issue 4719 - CI - Add dsconf add a PTA URL test
Description: This test checks that you are able to add a PTA URL through dsconf. Test tries to add new PTA URL and then check logs for message: "Successfully added URL".
Relates: https://github.com/389ds/389-ds-base/issues/4719
Reviewed by: @mreynolds389 @droideck (Thanks!)
- - - - -
22a2c235 by James Chapman at 2023-07-10T15:39:35+01:00
Issue 5752 - RFE - Provide a history for LastLoginTime (#5807)
Bug Description: For the lastloginhistory feature the user
can set the number of login histories that are saved by
modifing the lastloginhistorysize attribute. The CLI currently
allows setting this attribute value to 0 or a non positive int.
Fix Description: Add support for a lastloginhistorysize of 0 which
would disable the feature. Add CLI support for restricting non
positive int values.
relates: https://github.com/389ds/389-ds-base/issues/5752
Reviewed by: @droideck @mreynolds389 (Thank you)
- - - - -
005d08e5 by Mark Reynolds at 2023-07-10T14:10:04-04:00
Bump version to 2.4.2
- - - - -
9851f0ab by Simon Pichugin at 2023-07-12T15:28:25-07:00
Issue 3555 - UI - Fix audit issue with npm - stylelint (#5836)
Description: Update stylelint versions.
Run npm audit fix to address the vulnerability in stylelint.
Relates: https://github.com/389ds/389-ds-base/issues/3555
Reviewed by: @mreynolds389 (Thanks!)
- - - - -
f4f83eab by progier389 at 2023-07-13T10:43:33+02:00
issue 5833 - dsconf monitor backend fails on lmdb (#5835)
Problem:
On a suffix using lmdb, 'dsconf instance monitor backend userroot' fails because dn normalization cache data are missing.
Solution:
In fact the code was already in mdb_monitor.c but disabled by #if 0 and the fix is simply to remove the #if
Also added entrycache-hashtables in debug mode (to be aligned to what is done in bdb case)
Issue: 5833
Reviewed by: @jchapma, @mreynolds389 Thanks!
- - - - -
0d4b820b by Simon Pichugin at 2023-07-13T17:55:09-07:00
Issue 4169 - UI - Fix retrochangelog and schema Typeaheads (#5837)
Description: During PF4 Migration, a few typeaheads got broken.
Fix retroChangelog and schema typeahead selects.
Fix style errors (thanks, Mark!)
Related: https://github.com/389ds/389-ds-base/issues/4169
Reviewed by: @mreynolds389 (Thanks!)
- - - - -
4c6b2eca by Vladimir Cech at 2023-07-17T08:55:07+02:00
Issue 4758 - Add tests for WebUI
Description: Adding WebUI test for bz2029839. Test checks that Dictionary Check checkbox in Database/Password Policies/Global Policy/Syntax Checking is changed after cli command.
Relates: https://github.com/389ds/389-ds-base/issues/4758
Reviewed by: @droideck (Thanks!)
- - - - -
3c510e0a by progier389 at 2023-07-18T11:17:07+02:00
Issue 4551 - Paged search impacts performance (#5838)
* Issue 4551 - Paged search impacts performance
Problem:
Having a script looping doing a search with paged result impact greatly the performance of other clients
(for example ldclt bind+search rate decreased by 80% in the test case)
Cause:
Page result field in connection were protected by the connection mutex that is also used by the listener thread, in some cases this cause contention that delays the handling of new operations
Solution:
Do not rely on the connection mutex to protect the page result context but on a dedicated array of locks.
- - - - -
d6ebb570 by Simon Pichugin at 2023-07-20T18:03:10-07:00
Issue 3527 - UI - Add nsslapd-haproxy-trusted-ip to server setting (#5839)
Description: Add nsslapd-haproxy-trusted-ip attribute to
Server -> Server Settings -> Advanced Settings.
Move isValidIpAddress and isValidHostname to lib/tools.jsx.
Related: https://github.com/389ds/389-ds-base/issues/3527
Reviewed by: @mreynolds389 (Thanks!)
- - - - -
9709dba6 by Viktor Ashirov at 2023-07-25T15:22:57+02:00
Issue 5859 - dbscan fails with AttributeError: 'list' object has no attribute 'extends'
Bug Description:
There is a typo in dbscan:
```
> cmd.extends(['-f', indexfile])
E AttributeError: 'list' object has no attribute 'extends'
src/lib389/lib389/__init__.py:3057: AttributeError
```
Fix Description:
Fix the typo and fix the test
dirsrvtests/tests/suites/password/regression_test.py::test_unhashed_pw_switch
Fixes: https://github.com/389ds/389-ds-base/issues/5859
Reviewed-by: @progier389 (Thanks!)
- - - - -
d1932b9c by Viktor Ashirov at 2023-07-25T17:06:56+02:00
Issue 5856 - SyntaxWarning: invalid escape sequence '\,'
Bug Description:
An error is logged during rpm build:
/usr/lib/python3.12/site-packages/lib389/cli_conf/replication.py:1682: SyntaxWarning: invalid escape sequence '\,'
Fix Description:
Fix the typo.
Fixes: https://github.com/389ds/389-ds-base/issues/5856
Reviewed-by: @droideck (Thanks!)
- - - - -
1c573d97 by Viktor Ashirov at 2023-07-27T08:55:13+02:00
Issue 5864 - Server fails to start after reboot because it's unable to access nsslapd-rundir
Bug Description:
Sometimes after reboot dirsrv service fails to start:
EMERG - main - Unable to access nsslapd-rundir: No such file or directory
EMERG - main - Ensure that user "dirsrv" has read and write permissions on /run/dirsrv
EMERG - main - Shutting down.
We rely on systemd-tmpfiles for /run/dirsrv creation. But dirsrv service
doesn't explicitly wait for systemd-tmpfiles-setup.service to start.
This creates a race condition.
Fix Description:
dirsrv service should start only after systemd-tmpfiles-setup.service is finished,
add it as a dependency via `After=` and `Wants=`.
Fixes: https://github.com/389ds/389-ds-base/issues/5864
Reviwed-by: @Firstyear (Thanks!)
- - - - -
fa06cceb by Viktor Ashirov at 2023-07-31T12:20:13+02:00
Issue 5785 - CLI - arg completion is broken
Bug Description:
Files installed by 389-ds-base under
/usr/share/bash-completion/completions are not owned by 389-ds-base rpm
package.
Fix Description:
* Move the snippet for registering completions to %install section
and install them under builddir.
* Register bash completions in %files section so that they are owned by
the package.
Fixes: https://github.com/389ds/389-ds-base/issues/5785
Reviewed-by: @droideck (Thanks!)
- - - - -
96959cf7 by Simon Pichugin at 2023-07-31T17:21:24-07:00
Issue 5853 - Update Cargo.lock and fix minor warning (#5854)
Description: Run cargo update --manifest-path=./src/Cargo.toml.
Add minimum supported rust version field to the manifests.
Fix minor 'variable does not need to be mutable' error.
Another error:
error: using `.borrow()` on a double reference, which returns
`&concread::cowcell::CowCellReadTxn<CacheStats>` instead of borrowing the inner type
We're getting the error about borrowing a double reference because
we're trying to borrow a type that is already a reference.
Fix - use the type directly.
Set rust-version to 1.70 for better compatibility.
Related: https://github.com/389ds/389-ds-base/issues/5853
Fixes: https://github.com/389ds/389-ds-base/issues/5861
Reviewed by: @vashirov (Thanks!), @Firstyear (Thanks for the rust-version idea!)
- - - - -
92cc2b1e by progier389 at 2023-08-01T15:39:31+02:00
Issue 5867 - lib389 should use filter for tarfile as recommended by PEP 706 (#5868)
Problem:
tarfile interface evolved after CVE-2007-4559 and using object generated by tarfile.open without setting explicitly a filter has been obsoleted.
Solution:
Add an extraction_filter after every tarfile.open call
**Issue:** [5867](https://github.com/389ds/389-ds-base/issues/5867)
**Reviewed by:** @droideck Thanks !
- - - - -
3b2824fa by Viktor Ashirov at 2023-08-02T10:26:50+02:00
Issue 5877 - test_basic_ldapagent breaks test_setup_ds_as_non_root* tests
Bug Description:
`test_basic_ldapagent` creates `agent.conf` file that can't be read by
non-root user in `test_setup_ds_as_non_root*` tests.
Fix Description:
Move `agent.conf` file creation to a fixture to ensure it is deleted
after the test is finished.
Fixes: https://github.com/389ds/389-ds-base/issues/5877
Reviewed-by: @bsimonova (Thanks!)
- - - - -
469e9b84 by progier389 at 2023-08-02T14:35:16+02:00
Issue 5876 - CI Test random failure - Import (#5879)
Problem: Import CI test sometime fails because of a timing issue
Solution: Loops on waiting until task get created or until timeout expires
- - - - -
afdcca18 by tbordaz at 2023-08-02T14:44:42+02:00
Issue 5870 - ns-slapd crashes at startup if a backend has no suffix (#5871)
Bug description:
With $5598, the server checks at startup if it exists
some referrals entries in the various backends/suffixes.
If a backend has no defined suffix (not clear how it
occurs except crafting dse.ldif) the checking
triggers a sigsev
Fix description:
Check it exists a suffix before using it
- - - - -
ff9145b4 by James Chapman at 2023-08-02T14:01:01+01:00
Issue 5729 - Memory leak in factory_create_extension (#5814)
Bug description: Mem leak in sync repl operation extension code. In
syn persist when we release the connection, the operation extension
is not free'd.
Fix description: In syn persist when we release the connection, free the operation
extension if it exists.
relates: https://github.com/389ds/389-ds-base/issues/5729
Reviewed by: @droideck, @progier389 (Thank you)
- - - - -
171a3476 by Mark Reynolds at 2023-08-03T13:40:15-04:00
Bump version to 2.4.3
- - - - -
415c7480 by Viktor Ashirov at 2023-08-04T10:03:11+02:00
Issue 5872 - `dbscan()` in lib389 can return bytes
Bug Description:
When attribute encryption or changelog encryption is used, `dbscan()`
can return bytes instead of a string.
Fix Description:
* Update subprocess call to expect bytes instead of string.
* Revert changes to the tests done in
8bf7829ce3e3a8990fccd2fdbe7ae15ca1c8f0e7.
* Update entryrdn_test to expect output from dbscan as bytes.
Fixes: https://github.com/389ds/389-ds-base/issues/5872
Relates: https://github.com/389ds/389-ds-base/issues/5859
Reviewed-by: @progier, @droideck (Thanks!)
- - - - -
599db0a4 by progier389 at 2023-08-07T10:18:19+02:00
Issue 5883 - Remove connection mutex contention risk on autobind (#5886)
Problem: A contention on the connection c_mutex is blocking the listener thread when autobind is performed.
Solution: Let the listener thread skip the connection if the mutex is held by another thread
Reviewed by: @mreynolds389 , @droideck Thanks
- - - - -
0bf6b51d by Gilbert Kimetto at 2023-08-07T09:13:16-07:00
Issue 5848 - dsconf should prevent setting the replicaID for hub and consumer roles (#5849)
Bug Description: dsconf accepts the "replica-id" option when setting a hub or a consumer.
The replica configuration entry is correctly created ( replicaID is set to 65535 ).
we should prevent users setting the replicaID for hub and consumer roles because
the value is set automatically anyway.
Fix Description: Check if role is "consumer" or "hub" and if so deny option to set the ReplicaID.
Add tests.
Fixes: https://github.com/389ds/389-ds-base/issues/5848
Author: Gilbert Kimetto
Reviewed by: Simon Pichugin
- - - - -
b62bd43e by Vladimir Cech at 2023-08-08T12:50:07+02:00
Issue 4758 - Add tests for WebUI
Description:
Adding WebUI test for bz2018101. This test checks that you are able to create credentials and aliases through WebUI in monitoring tab.
Relates: https://github.com/389ds/389-ds-base/issues/4758
Reviewed by: @droideck
- - - - -
2dab9224 by progier389 at 2023-08-08T14:18:58+02:00
Issue 5872 - part 2 - fix is_dbi regression (#5887)
A one liner fix to handle a regression in nightly tests about is_dbi function (need to convert dbscan output back into string):
Issue: 5272 part 2
Reviewed by: @mreynolds389 Thanks!
- - - - -
454ee60f by James Chapman at 2023-08-08T13:35:27+01:00
Issue 5834 - AccountPolicyPlugin erroring for some users (#5866)
Bug Description: With the account policy plugin enabled and
lastloginhistory size set to non 0 an issue occurs during
simultaneous binds of the same user. In this case the timestamp
to be stored in the lastloginHistory attribute already exists from
a previous bind, and generates an error message.
A side effect of lastloginHistory feature is that the modifytimestamp
value is updated after a successful bind, even when the feature is
disabled.
Fix Description: Before a timestamp is added to the lastloginHistory
attribute a check is performed to make sure it doesnt already exist.
Ensure the entry is not modified when this feature is disabled.
Fixes: https://github.com/389ds/389-ds-base/issues/5834
Relates:https://github.com/389ds/389-ds-base/issues/5752
Reviewed by: @progier389, @tbordaz (Thank you)
- - - - -
89c2de50 by progier389 at 2023-08-08T17:27:16+02:00
Issue 4551 - Part 2 - Fix build warning of previous PR (#5888)
Fix build paged search resuilt PR warning in header fix
Issue: 4551
Reviewed by: @mreynolds389 Thanks
- - - - -
bfe5fe5d by Viktor Ashirov at 2023-08-10T16:13:33+02:00
Issue 5082 - slugify: ModuleNotFoundError when running test cases
Bug Description:
slugify module is used in WebUI tests for creating filenames for
screenshots. But it's often not installed by default, since it's not
required by lib389. WebUI tests are executed only when a WEBUI
environment variable is present, so we should import it under the same
condition.
Fix Description:
Import slugify module only when WEBUI environment variable is present
and WebUI tests are executed.
Reviewed-by: @progier389 (Thanks!)
Fixes: https://github.com/389ds/389-ds-base/issues/5082
- - - - -
087d486a by progier389 at 2023-08-11T15:44:50+02:00
Issue 5890 - Need a tester for testing multiple listening thread feature (#5891)
Problem: Need a specific tester for testing multiple listening thread feature.
Solution:
Having a python tool that open n connection then loops
waiting some time
select randomly a connection
perform a base search operation and aggregate elapsed time
display the result every second
Issue: 5890
- - - - -
e84564fe by progier389 at 2023-08-11T16:13:11+02:00
Issue 5894 - lmdb import error fails with Could not store the entry (#5895)
- - - - -
3dfe80f1 by progier389 at 2023-08-11T17:13:56+02:00
Issue i5846 - Crash when lmdb import is aborted (#5881)
Problem: Double free occurs in the writer thread queue when an import over lmdb aborts
Solution: fix the double free
- - - - -
4297d886 by progier389 at 2023-08-11T17:59:55+02:00
issue 5890 part 2 - Need a tester for testing multiple listening thread feature (#5897)
Problem: after latest commit --amend: elapsed time is now written every operation
instead of getting aggregated every seconds
Cause: I forgot that time.time() is returning a float instead of an int as in C
Fix: Convert time.time() result to int
Issue: 5890
- - - - -
68e91603 by Adadov at 2023-08-16T17:50:31-04:00
Bug Description:
Certificates encoded values are truncated if length is over 1000 characters.
Fix Description:
Add exception for every attribute matching .*certificate.*
Author: Adadov
Reviewed by: mreynolds
- - - - -
475ee01d by Stanislav Levin at 2023-08-17T18:01:41+02:00
Issue 5203 - outdated version in provided metadata for lib389
Bug Description:
There is a hardcoded version of `lib389` since
9dccfea39a2e0477cdad5463eb4ad4a25ac7ad68.
Fix Description:
Build `setup.py` from template.
Fixes: https://github.com/389ds/389-ds-base/issues/5203
Reviewed by: Simon Pichugin (thanks!)
Signed-off-by: Stanislav Levin <slev at altlinux.org>
- - - - -
63fd271f by tbordaz at 2023-08-17T18:15:42+02:00
Issue 5722 - improve testcase (#5904)
- - - - -
c1f95889 by James Chapman at 2023-08-28T16:40:49+01:00
Issue 5909 - Multi listener hang with 20k connections (#5910)
Bug Description: When the server is configured with multiple listeners,
the connection table is divided into multiple sub tables. These sub tables
are then mapped to a single freelist to enable efficient allocation of new
connections. Each sub table is a double linked list with element 0 used as
the head of the list. During the mapping of sub tables to freelist the
head of each sub table is incorrectly mapped to the freelist, creating a "hole"
in the freelist.
Fix Description: Skip element 0 of each sub table when mapping to the
single freelist.
Fixes: https//github.com/389ds/389-ds-base/issues/5909
Reviewed by: @vashirov (Thank you)
- - - - -
bacf8075 by markafarrell at 2023-08-30T14:19:11+02:00
pass instance correctly to ds_is_older (#5903)
Correctly pass instance to instance to ds_is_older when initializing PosixGroups class.
Currently this results in an error when connecting to a remote 389ds instance.
Fixes #5902
- - - - -
404da4c8 by progier389 at 2023-08-31T14:40:19+02:00
Issue 5902 - Fix previous commit regression (#5919)
Fix previous commit regression:
CI test test_schema_comparewithfiles fails with: AttributeError: SchemaLegacy object has no attribute _instance
Because SchemaLegacy is not a DSLdapObject and the instance is stored in conn instead of in _instance
Issue: 5902
Reviewed by: @tbodaz, (Thanks!)
- - - - -
c257ed7c by James Chapman at 2023-08-31T15:05:31+01:00
Issue 5909 - Multi listener hang with 20k connections (#5917)
Bug Description: A fix for connection sub-table to freelist mapping results
in an uninitialised head of the sub-table linked list.
Fix Description: During connection table creation, initialise all elements but
skip the list head during the mapping phase.
Fixes: https//github.com/389ds/389-ds-base/issues/5909
Reviewed by: @progier389 @tbordaz (Thank you)
- - - - -
b021fb25 by Mark Reynolds at 2023-08-31T12:40:40-04:00
Issue 5914 - UI - server settings page validation improvements and db index fixes
Description:
We were not correctly validating the config settings for numbers on the server settings page.
Database index add/delete models were crashing browser related to esbuild port and camelCase function names
relates: https://github.com/389ds/389-ds-base/issues/5914
Reviewed by: spichugi(Thanks!)
- - - - -
8b0e13cf by Simon Pichugin at 2023-08-31T11:19:05-07:00
Issue 5848 - Fix condition and add a CI test (#5916)
Description: Add a "positive" test for the issue and fix the condition
to make sure that 65535 and no --replica-id are correctly accepted.
Related: https://github.com/389ds/389-ds-base/issues/5848
Reviewed by: @mreynolds389 @tbordaz (Thanks!)
- - - - -
d3f94d49 by Simon Pichugin at 2023-08-31T11:19:35-07:00
Issue 5848 - Fix condition and add a CI test (#5916)
Description: Add a "positive" test for the issue and fix the condition
to make sure that 65535 and no --replica-id are correctly accepted.
Related: https://github.com/389ds/389-ds-base/issues/5848
Reviewed by: @mreynolds389 @tbordaz (Thanks!)
- - - - -
d650303d by Simon Pichugin at 2023-09-01T08:45:31-07:00
Issue 1115 - Add a CI test (#5913)
Description: Add a test to validate replication behaviour under
different operation types. Specifically, this test ensures
that modifications, deletions, and 'modrdn' operations are
replicated correctly across supplier instances.
Related: https://github.com/389ds/389-ds-base/issues/1115
Reviewed by: @progier389 (Thanks!)
- - - - -
7135e21a by Simon Pichugin at 2023-09-07T10:48:17-07:00
Issue 1081 - CI - Add more tests for overwriting x-origin issue (#5815)
Description: Add a test suite that tests an attributetype and
its x-origin values in a replicated environment s1c1 and s1h1c1.
Also, ensure the custom x-origin is correctly overwritten
in the replication event as 'user defined'.
Related: https://github.com/389ds/389-ds-base/issues/1081
Reviewed by: @progier389 (Thanks!)
- - - - -
63f88642 by Simon Pichugin at 2023-09-07T10:49:43-07:00
Issue 1317 - Add a CI test (#5923)
Description: Add a test that checks the situation when a recovered
supplier accepts direct updates before being in sync, replica to
that supplier and from that supplier is broken.
Related: https://github.com/389ds/389-ds-base/issues/1317
Reviewed by: @progier389 (Thanks!)
- - - - -
3e917225 by Simon Pichugin at 2023-09-12T12:39:09-07:00
Issue 1456 - Add a CI test that verifies there is no issue (#5927)
Description: Add a test which checks that targetattr behaves
correctly when a subtype is used.
Related: https://github.com/389ds/389-ds-base/issues/1456
Reviewed by: @progier389 (Thanks!)
- - - - -
9ca2e513 by Simon Pichugin at 2023-09-14T19:03:54-07:00
Issue 1802 - Improve ldclt man page (#5928)
Bug Description: ldclt is a complex tool. We should be providing worked examples
to help add context to the many parameters available.
Fix Description: Add a worked example from the addition of a set of users to
using them for a binding load test.
Fixes: https://github.com/389ds/389-ds-base/issues/1802
Author: wibrown
Review by: @progier389 and @jchapma (Thanks!)
Co-authored-by: William Brown <firstyear at redhat.com>
- - - - -
c3a69bb1 by progier389 at 2023-09-18T12:48:41+02:00
Issue 5761 - Worker thread dynamic management (#5796)
* Issue 5761 - Worker thread dynamic management
Objectives:
Allow to configure the number of worker threads without having to restart the server
Decrease the worker thread global mutex contention but removing the associated condition variable
==> Increase the "searchrate" performance
Solution: See https://github.com/389ds/389ds.github.io/blob/main/docs/389ds/design/worker-threads.md
Issue: 5761
Reviewed by: @tbordaz (Thanks!)
- - - - -
cb85204c by Simon Pichugin at 2023-09-19T16:38:04-07:00
Issue 843 - Add a warning to slapi_valueset_add_value_ext (#5925)
Description: The combination of SLAPI_VALUE_FLAG_DUPCHECK and SLAPI_VALUE_FLAG_PASSIN flags is not recommended for slapi_valueset_add_value_ext.
Using this combination could result in undefined behaviour related to memory management. If you need both flags, please use the slapi_valueset_add_attr_value_ext function instead and ensure proper cleanup if there's an error.
We don't use the function with the above flag combination, but someone in the community might (even though it's highly unlikely). Hence, as of now, it isn't worth investing more time into this, and the documentation should be updated with this change.
Related: https://github.com/389ds/389-ds-base/issues/843
Reviewed by: @progier389 (Thanks!)
- - - - -
e820ab70 by Simon Pichugin at 2023-09-20T18:25:30-07:00
Issue 1870 - Add a CI test (#5929)
Description: If two instances of the plugin are created with the same origin scope,
only the request of one of the plugins will be satisfied.
(i.e. template and instance A and B, that both make entries in ou A and B,
from ou=People, only A will work)
Related: https://github.com/389ds/389-ds-base/issues/1870
Author: wibrown
Reviser: spichugi
Reviewed by: @progier389 (Thanks!)
- - - - -
aa465605 by DesigNET at 2023-09-21T13:25:27-07:00
Issue 5732 - Localizing Cockpit's 389ds Plugin using CockpitPoPlugin (#5764)
Description: To enable localization for 389ds, we obtained CockpitPoPlugin from pkg/lib/cockpit-po-plugin.js in the old Cockpit, called it in webpack.config.js, and modified the files so that 389ds can handle language files (po files).
Relates: https://github.com/389ds/389-ds-base/issues/5732
Author: designet-inc-oss
Reviewed by: @mreynolds389, @vashirov, @droideck (Thanks!)
- - - - -
9633e8d3 by Simon Pichugin at 2023-09-27T15:40:33-07:00
Issue 1925 - Add a CI test (#5936)
Description: Verify that the issue is not present. Cover the scenario when
we remove existing VLVs, create new VLVs (with the same name) and then
we do online re-indexing.
Related: https://github.com/389ds/389-ds-base/issues/1925
Reviewed by: @progier389 (Thanks!)
- - - - -
02d33325 by progier389 at 2023-09-28T12:15:25+02:00
issue 5924 - ASAN server build crash when looping opening/closing connections (#5926)
* issue 5924 - ASAN server build crash when looping opening/closing connections
Issue: Got a crash due to:
1. Failure to get a connection slot because connection freelist is misshandled.
2. A confusion between listening and acceptedfd descriptor leaded to
close the listening descriptor while handing the error.
Solution:
Rename clearly the file descriptor variables
Close the accepted file descriptor in error handler
Rewrite the freelist management so that first connection chosen is the last released one.
(Code is simpler, this fix the end of list issue, and it avoid to spread the open connection over too much memory)
Issue: #5924
Reviewed by: @Firstyear, @vashirov, @droideck (Thanks !)
- - - - -
2afb0e3a by Simon Pichugin at 2023-10-04T16:58:05-07:00
Issue 5938 - Attribute Names changed to lowercase after adding the Attributes (#5940)
Bug Description: When working with the web console to edit the attributes
with capital and lowercase letters in their names. The capital letters within
the names of an attribute change whenever the attributes are added
to an object class.
Fix Description: Presevrer the case in both UI and CLI when doing
edit/add/list operations.
Fixes: https://github.com/389ds/389-ds-base/issues/5938
Reviewed by: @progier389 (Thanks!)
- - - - -
4f99f8bc by dependabot[bot] at 2023-10-10T16:26:45+02:00
Bump postcss from 8.4.24 to 8.4.31 in /src/cockpit/389-console (#5945)
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.24 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.4.24...8.4.31)
---
updated-dependencies:
- dependency-name: postcss
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support at github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- - - - -
415eeada by progier389 at 2023-10-13T12:21:37+02:00
Issue 5843 - dsconf / dscreate should be able to handle lmdb parameters (#5943)
* Issue 5843 - dsconf / dscreate should be able to handle lmdb parameters
Description:
dscreate changes:
- make db_lib a standard option instead of an advanced one
- add mdb_max_size as standard option
dsconf instance backend config set changes:
- add --mdb_max_size option associated with nsslapd-mdb-max-size
- add --mdb_max_readers option associated with nsslapd-mdb_max_readers
- add --mdb_max_dbs option associated with nsslapd-mdb_max_dbs
Issue: #5843
Reviewed by: @Firstyear and @droideck ( Thanks ! )
- - - - -
f52d10a1 by strzh at 2023-10-13T13:07:30+02:00
bugfix for --passwd-file not working on latest version (#5934)
bugfix for --passwd-file not working on latest version (#5934)
Fix a dsconf fails because a naming mismatch between argparse parameters and args attribute)
Solved by using consistent naming while keeping old name for compatibility
Issue: #5935
Reviewer: @tbordaz @progier389 @droideck
- - - - -
91c4f62f by progier389 at 2023-10-16T12:04:55+02:00
Issue 4843 - Fix dscreate create-template issue (#5950)
Regression with dscreate from-instance before creating first instance:
the target directory does not exists and a warning is inserted in the template file
which is then broken.
Fix is pretty trivial:
Select an existing directory to compute the file system free space.
Issue #5943
Reviewed by: @droideck (Thanks !)
- - - - -
1370c060 by Simon Pichugin at 2023-10-18T09:04:59-07:00
Issue 3555 - UI - Fix audit issue with npm - babel/traverse (#5959)
Description: Run npm audit fix to address the vulnerability
in babel/traverse.
Relates: https://github.com/389ds/389-ds-base/issues/3555
Reviewed by: @progier389 (Thanks!)
- - - - -
696f0ed2 by Viktor Ashirov at 2023-10-20T15:40:35+02:00
Issue 5960 - Subpackages should have more strict interdependencies
Bug Description:
`cockpit-389-ds` requires `389-ds-base` and `python3-lib389`, but it
should require the exact version and release as well. Without this it's
possible to update `cockpit-389-ds` without updating other sub-packages,
which can lead to incompatibilities between WebUI and underlying lib389
tools used by the WebUI.
Fix Description:
Update Requires for the subpackages to use version and release.
Fixes: https://github.com/389ds/389-ds-base/issues/5960
Reviewed-by: @progier389, @droideck (Thanks!)
- - - - -
6a8040d2 by Viktor Ashirov at 2023-10-20T15:43:07+02:00
Issue 5786 - Update permissions for Release workflow
Description:
Release workflow needs write access to create releases.
Fixes: https://github.com/389ds/389-ds-base/issues/5786
Reviewed-by: @droideck (Thanks!)
- - - - -
8e379e26 by Simon Pichugin at 2023-10-24T09:17:57-07:00
Issue 5966 - CLI - Custom schema object is removed on a failed edit (#5967)
Description: When the failure happens during a custom schema edit operation
in both CLI and UI (because it uses the CLI command), we first remove
the old schema object, and only then do we add the new one (edited).
Bring the old schema object on the failed attempt.
Resolves: https://github.com/389ds/389-ds-base/issues/5966
Reviewed by: @mreynolds389 (Thanks!)
- - - - -
91d1df69 by progier389 at 2023-10-25T15:13:13+02:00
Revert "Issue 5761 - Worker thread dynamic management (#5796)" (#5970)
This reverts commit c3a69bb19ee0733027bdea5da9e4bcbb9b0cd0ba about the
Worker thread dynamic management feature because it caused a regression
in freeipa CI tests due to a massive performance loss during a total update
( https://issues.redhat.com/browse/IDMDS-3781 )
Issue: #5761
Reviewed by: @tbordaz (Thanks!)
- - - - -
9d0ebfe5 by progier389 at 2023-10-31T12:08:32+01:00
Issue 5973 - Fix fedora cop RawHide builds (#5974)
Problem: @389ds/389-ds-base-nightly copr nigthly builds faild on
fedora-rawhide-s390x and fedora-rawhide-x86_64
Solution:
[1] Work around a gcc cpp bug by moving stavfs.h include line
before ldbm-backend.h include line
[2] Do not use large file API on LP64 architecture
Reviewed by: @tbordaz , @droideck (Thanks !)
- - - - -
17106c3e by Simon Pichugin at 2023-10-31T16:51:23-07:00
Issue 5971 - CLI - Fix password prompt for repl status (#5972)
Description: dsconf replication status is failing with 'Invalid credentials'
when the password of the Directory Manager is different on servers.
Ask for each instance's password separately.
Expand the help message in CLI for replication and agreement status commands.
Fixes: https://github.com/389ds/389-ds-base/issues/5971
Reviewed by: @tbordaz (Thanks!)
- - - - -
2cb07156 by James Chapman at 2023-11-15T11:44:15+00:00
Bump version to 2.4.4
- - - - -
d7018fc5 by Timo Aaltonen at 2024-01-08T16:42:02+02:00
ack nmu
- - - - -
af8ffb00 by Timo Aaltonen at 2024-01-08T16:43:03+02:00
Merge tag '389-ds-base-2.3.4' into m
- - - - -
eacb44c9 by Timo Aaltonen at 2024-01-08T17:12:54+02:00
Merge branch 'master' into m
- - - - -
7d015a1c by Timo Aaltonen at 2024-01-08T17:18:02+02:00
version bump
- - - - -
39f6c83d by Timo Aaltonen at 2024-01-08T18:04:00+02:00
rules: Generate lib389/setup.py.
- - - - -
b825e636 by Timo Aaltonen at 2024-01-08T18:04:15+02:00
releasing package 389-ds-base version 2.4.4+dfsg1-1
- - - - -
30 changed files:
- .github/workflows/compile.yml
- .github/workflows/lmdbpytest.yml
- .github/workflows/npm.yml
- .github/workflows/pytest.yml
- .github/workflows/release.yml
- .github/workflows/validate.yml
- Makefile.am
- VERSION.sh
- debian/changelog
- debian/control
- debian/rules
- dirsrvtests/conftest.py
- + dirsrvtests/tests/perf/ltest.py
- dirsrvtests/tests/suites/acl/acl_test.py
- dirsrvtests/tests/suites/basic/basic_test.py
- + dirsrvtests/tests/suites/basic/haproxy_test.py
- + dirsrvtests/tests/suites/clu/dsconf_pta_add_url_test.py
- dirsrvtests/tests/suites/clu/dsconf_test.py
- dirsrvtests/tests/suites/clu/dsctl_dblib_test.py
- dirsrvtests/tests/suites/config/config_test.py
- dirsrvtests/tests/suites/ds_logs/ds_logs_test.py
- dirsrvtests/tests/suites/export/export_test.py
- dirsrvtests/tests/suites/healthcheck/health_config_test.py
- dirsrvtests/tests/suites/healthcheck/healthcheck_test.py
- dirsrvtests/tests/suites/import/import_test.py
- dirsrvtests/tests/suites/indexes/entryrdn_test.py
- + dirsrvtests/tests/suites/memory_leaks/allids_search_test.py
- dirsrvtests/tests/suites/password/regression_test.py
- dirsrvtests/tests/suites/plugins/accpol_test.py
- dirsrvtests/tests/suites/plugins/managed_entry_test.py
The diff was not included because it is too large.
View it on GitLab: https://salsa.debian.org/freeipa-team/389-ds-base/-/compare/bdc80aa4d5937f9cff6d6bb92a5ad71eac8d3229...b825e636d118fab4e212be6fbbba324e15c578d7
--
View it on GitLab: https://salsa.debian.org/freeipa-team/389-ds-base/-/compare/bdc80aa4d5937f9cff6d6bb92a5ad71eac8d3229...b825e636d118fab4e212be6fbbba324e15c578d7
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-freeipa-devel/attachments/20240108/ae67e37d/attachment-0001.htm>
More information about the Pkg-freeipa-devel
mailing list