[Pkg-freeipa-devel] Debian NEW review of jss 5.10.1-1: ACCEPTED

[Timo Aaltonen]

Thanks for the review and suggestions! Comments below:

awm at debian.org kirjoitti 29.9.2026 klo 13.31:
> The Debian NEW review of jss 5.10.1-1 has been completed.
> 
> Decision: ACCEPTED
> Reviewer: Andrew McMillan
> 
> Review comment:
> 
> Hi,
> 
> Some Minor Packaging issues...
> 
> 1. dh_auto_test runs ctest in the wrong directory (rules:47)
> 
> The CMake build is configured/built into build2 (rules:15,39,43), but the test override runs cd build && ctest. The build/ directory is just an empty upstream placeholder (only .gitkeep), so the native test suite never actually runs against the built tree. The trailing || true then silently swallows the failure, so the error is invisible. This should be build2.

yes indeed.. fixed!

> Relatedly, override_dh_auto_clean cleans build2 but never the stale build/ dir;

build/ comes from upstream git, I don't see a reason to remove it. 
Nothing ends up there during package build.

> 2. debian/not-installed glob doesn't match the real install path
> 
> The file contains debian/tmp/jss/tests/*, but tests/CMakeLists.txt installs to ${}/jss/tests/bin (i.e. debian/tmp/usr/share/jss/tests/bin/...). The missing usr/share/ means dh_missing can't suppress those uninstalled test scripts, and it's a confusing/stale entry.
> 

There's actually something wrong in the upstream files, 
$SHARE_INSTALL_PREFIX isn't getting used there.. so it is currently 
correct :)

> 3. debian/watch is likely broken
> 
> Matching-Pattern: .*/releases/tag/@ANY_VERSION@
> Filename-Mangle: s/@ANY_VERSION@$/jss-$1.tar.gz/
> 
> The Filename-Mangle references $1, but the Matching-Pattern defines no capture group, so $1 is undefined. Combined with a Source: pointing at an HTML tags page (no downloadable tarball), uscan can't construct/fetch jss-<ver>.tar.gz.
> 

Yep, I didn't even use it but the gentarball target.. Fixed.


-- 
t