[Pkg-freeradius-maintainers] Bug#859087: Bug#859087: freeradius-mysql.postintst reloads config of not-running-now freeradius

[Michael Stapelberg]

The following patch should address this issue:

--- i/debian/freeradius-mysql.postinst
+++ w/debian/freeradius-mysql.postinst
@@ -5,7 +5,11 @@ set -e

 case "$1" in
   configure)
-    invoke-rc.d freeradius force-reload
+    # Only reload when FreeRADIUS is running, see #859087
+    if invoke-rc.d freeradius status 1>/dev/null 2>&1
+    then
+      invoke-rc.d freeradius force-reload
+    fi
     ;;
 esac

I’ll add it for the next upload, but that will take a while since Debian is
currently in a freeze.


On Thu, Mar 30, 2017 at 9:52 AM, Mihail Vasilev <mickvav at gmail.com> wrote:

> Package: freeradius-mysql
> Version: 2.2.5+dfsg-0.2
> Severity: normal
>
> Dear Maintainer,
>
> I am running a master-slave installation of 2 debian servers, on which the
> filesystem with database is mounted only on master node (this is ensured by
> heartbeat). Thus, I have no running mysql on slave host.
> As a result, when I try to update freeradius-mysql package, it tries to
> make freeradius reload it's config without thinking that it's not running
> and
> will cause error, as we are operating on the slave host (and directories
> for log files, for example, are not accessible right now).
>
> The result was in aptitude marking package as broken and tries to rerun
> freeradius-mysql.postinst script on every other package install/update
> operation.
>
> As it's quite annoying, I've just commented out reload line in postinst
> script
> and things became right for me.
>
> But I think it would be wiser for the upstream to add some check in
> .postinst
> scripts, which call force-reload action on service only if it's already
> running.
> If freeradius is not running right now - it may be done on purpose.
>
> I've checked .postinst script in 3.0.12 release of the package - it became
> much shorter, but there is stil no check in this place.
>
>
> -- System Information:
> Debian Release: 8.7
>   APT prefers stable-updates
>   APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
> Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
>
> Versions of packages freeradius-mysql depends on:
> ii  freeradius        2.2.5+dfsg-0.2
> ii  libc6             2.19-18+deb8u7
> ii  libmysqlclient18  5.5.54-0+deb8u1
> ii  zlib1g            1:1.2.8.dfsg-2+b1
>
> freeradius-mysql recommends no packages.
>
> freeradius-mysql suggests no packages.
>
> -- debconf-show failed
>
> _______________________________________________
> Pkg-freeradius-maintainers mailing list
> Pkg-freeradius-maintainers at lists.alioth.debian.org
> https://lists.alioth.debian.org/mailman/listinfo/pkg-
> freeradius-maintainers
>



-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-freeradius-maintainers/attachments/20170330/0f47efea/attachment.html>