[Pkg-freeradius-maintainers] Bug#932113: freeradius-ldap: postinst script can fail on upgrades

[Kim-Alexander Brodowski]

Package: freeradius-ldap
Version: 3.0.17+dfsg-1.1
Severity: normal
Tags: patch

Dear Maintainer,

while upgrading a test machine to Buster we've encountered the following
issue:

Job for freeradius.service failed because the control process exited with error code.
See "systemctl status freeradius.service" and "journalctl -xe" for details.
invoke-rc.d: initscript freeradius, action "force-reload" failed.
dpkg: error processing package freeradius-ldap (--configure):
 installed freeradius-ldap package post-installation script subprocess returned error exit status 1

I'm not 100% certain what might have caused the reload to fail, but
since we're replacing all config files with upstream versions while
upgrading there are a number of things that can go wrong.

In any case I believe that invalid config files should never cause a
package installation/configuration/removal to fail if no further harm is to be expected.

Therefore I suggest the following change:

--- freeradius-ldap.postinst	2019-07-15 12:58:47.761127820 +0200
+++ /var/lib/dpkg/info/freeradius-ldap.postinst	2019-07-15 12:58:59.061231799 +0200
@@ -5,7 +5,7 @@

 case "$1" in
   configure)
-    invoke-rc.d freeradius force-reload
+    invoke-rc.d freeradius force-reload || true
     ;;
 esac

Kind regards,
Kim-A. Brodowski

-- System Information:
Debian Release: 10.0
  APT prefers proposed-updates
  APT policy: (500, 'proposed-updates'), (500, 'stable')
Architecture: i386 (x86_64)
Foreign Architectures: amd64

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages freeradius-ldap depends on:
ii  freeradius     3.0.17+dfsg-1.1
ii  libc6          2.28-10
ii  libldap-2.4-2  2.4.47+dfsg-3

freeradius-ldap recommends no packages.

freeradius-ldap suggests no packages.

-- no debconf information