Bug#437313: hex-a-hop: Too many compiler warnings on build

[Jens Seidel]

Package: hex-a-hop
Version: 0.0.20070315-2
Severity: minor
Tags: patch upstream

Hi, I tried to build hex-a-hop to test the German translation and maybe
to work on bug #436469 but got too many error messages to enjoy the game!

I added -Wall and -W to the upstream Makefile and fixed all warnings.

At least the following part should be checked! Does it fix an error, is
the format string wrong or can the last arguments indeed be ignored?

-					sprintf(optionSlotName[i], "Continue game %d (All Clear!)", i+1, p.general.completionPercentage, p.general.masteredPercentage);
+					sprintf(optionSlotName[i], "Continue game %d (All Clear!)", i+1/*, p.general.completionPercentage, p.general.masteredPercentage*/);

The patch is against upstream tar ball without debian patches.

PS: I really do not like stupid DOS endings in source code. Can this be
changed?

Jens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hex-a-hop.diff
Type: text/x-diff
Size: 13554 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20070811/ead130c9/attachment.diff